From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA3BCD1284 for ; Tue, 2 Apr 2024 11:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 585A36B0099; Tue, 2 Apr 2024 07:20:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5363A6B009A; Tue, 2 Apr 2024 07:20:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FDB26B009B; Tue, 2 Apr 2024 07:20:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F7426B0099 for ; Tue, 2 Apr 2024 07:20:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E99871A06AB for ; Tue, 2 Apr 2024 11:20:41 +0000 (UTC) X-FDA: 81964349082.04.ACEC04E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id C873E80028 for ; Tue, 2 Apr 2024 11:20:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NnExroUT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="lBv/XW6m"; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712056840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; b=7iQa70vQgqYkhsaMwBIxQKsrNnzrpU2K9lo6I7k1G4gXzNxH13e3fr5mm5SOJQ8hJ+84AW +AbgWFTKcBiidyjq3uRud2OjaQu7NsjTcTVHWL992/rSdJnAPX4tRjgQ3Mr3Y2WB+NKWxW DEgzIy+2FIPjkeCvcoh7iJReHSsgh74= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NnExroUT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="lBv/XW6m"; spf=pass (imf30.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712056840; a=rsa-sha256; cv=none; b=5HPucvh0J1epQZspmZJUzimKO9eV+m7QAVyXb726dOocaeuBbeaQxXjNZTwa7dIb8cuHvz WKie9UVNmGlQjTk9mmkard4YDThtWcjhUhmXwRDL5wWUOJZbtu67Lnm97GqOdhWeqla7ly u57gF1mT588QR5V0mDQs723pe8c2/gc= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 52C6622419; Tue, 2 Apr 2024 11:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712056838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; b=NnExroUT5vh/JpIUPeU+/Mg0nEpSEqcSvofpvlMqhpkjGO4a0AX6onoxENkOrRCFsVB/ED J9tPeDE/m2BGDSM8cy/dnPENfLIaFlF/k1zxagj0zvUK4XNCpiRbWb+tf35M3W6NYJqudo CWY0Jxa0580cCwhVAZVDNefnfTvIQLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712056838; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apA0Uu4D1AgfLqcwFbImK2prYt2oHJJeyB/JlM/93O4=; b=lBv/XW6mYKDUmkY/I0LALpdkywTpCO8tOoTCxrk/8M+0QNllVNsDrpjXe7tF7t9OwBr9HZ vTSo5OjReWMd82Cg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id D3E5B13357; Tue, 2 Apr 2024 11:20:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id UYQtMQXqC2YVKAAAn2gu4w (envelope-from ); Tue, 02 Apr 2024 11:20:37 +0000 Date: Tue, 2 Apr 2024 13:22:02 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko Subject: Re: [PATCH v3 3/3] mm,page_owner: Fix accounting of pages when migrating Message-ID: References: <20240326063036.6242-1-osalvador@suse.de> <20240326063036.6242-4-osalvador@suse.de> <50f31489-b5c3-480e-a7db-20edbbb2c9c2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50f31489-b5c3-480e-a7db-20edbbb2c9c2@suse.cz> X-Spamd-Bar: / X-Rspamd-Queue-Id: C873E80028 X-Rspam-User: X-Stat-Signature: jqms6zxwt77ku6wj3zfqssp14c4hbkay X-Rspamd-Server: rspam01 X-HE-Tag: 1712056839-977657 X-HE-Meta: U2FsdGVkX18P4NvaGJVg94qfoIe3Y9ou7F+wJm68EBo5GGUBVeVRpIDBsGuIeGXUMKrFvVTGMu0n52sve3iY57pA+4V2Z2ZoRV1yyydZAMOcHc2zGwTroB1N1rziPE4ftBkMtR3MtrjOxg1v2Wh+4Kwr56lUpSTebPzguaVUFHVYOsnbvHZuYXF+mtvtb/XaJQ9F4qcP7IcNOqNsOle/dq7aNA97W17gapnldWuy+3hiX84QJ/713NIkyx42qnlLkue7dge4l4oUuMbs4oTmAZ5G+AcExlC9nS0veo8eQj38EDyDPMjwVgKOtlyNYq++pTo78QSA+b70g8C6J45ZfFRu2dZoLspU/LrIGu8utRS+3AlkE6OmIreapdoDanhXNsrcUHGDh06/pjnXYU/STfrX4soxeHhBIjBDsR32IfFBVFKQgQldsvGIQrxgNRDupqYlnfBxBrNe0/0fnGoizTk6uyarIE7kWQhMCpGnl2pKOQa6rmvCDgooHWz0jO2YnUQCIChNLuEypwxW5Xo7oH0urNjVmdxpHxnyK7WuD+8Z9FEBJpniceVupt2zKv8U8bChOIdM7YudKeUK56/bg5fWYrfnZsb45TZj3VO5OzAp8gtqaqrQadGL9pNA9g7oPHT2kaDGFGLxcpVgdIVTkzN9KIHA3DyuEnN5pG/StYT4ASCX0vCilZOjey+wv4Gd3FNtkQbC0nE/97Wmv7q1C7TpMnwbkdhzrNN5kAsxQhuTrTM+WOBccTAgxjvN8h569NCykCx3f11caw5R2vpJgd+qSksU6gTsr2KTDylfym0KjaMDfY/DTKHtd9gqO/Vp3FL20bECtHzHvGOBIkoYhLlPY8CWAEgQ2HGeB33CtychhLzRNMkGmpQpJW6ws9oALB5jX1hgzWAgFkm7RvpuULVjFuiyvsEyf6nwYo3a1N00L1wADJrJvQbVtfM7L5ceNlUw4TllrdAk5gkWV/x t2J/6Wml GyFFtdtXPCJIoFAuQUKOU2ohhm1iiPfFfSVL0GIvDFhZQrPeXwCIKayXS1Em+i+tv/onbnq/+ibIhIaKdMqX1Mp50h7pi041jhTm4mqxWtoV79nF9OAPtaO5I252PMLwTplyHatQHuKaOWCvOh2K1kfdHbIx+wc/vQbl2yKLcdjVbmMhBcncl0eTrB6vhM6MC5q5cyezEGUcJP3FcEYRhxQdkPA7V3byFguMhu/kXGPk0IlpyZb1x53mNhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 02, 2024 at 12:26:51PM +0200, Vlastimil Babka wrote: > Can the migration still fail after __folio_copy_owner()? That goes again to > the comment you changed in patch 1/3. If it can, this will kinda create a > mess with the old folio's handles not reflecting reality? (although > refcounts will be ok) According to my research (I replied in patch#1), no, migration cannot fail after __folio_copy_owner(), so we are safe here (Tm). -- Oscar Salvador SUSE Labs