From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D30C4345F for ; Thu, 11 Apr 2024 22:02:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B7276B0098; Thu, 11 Apr 2024 18:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 366266B0099; Thu, 11 Apr 2024 18:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22D9B6B009A; Thu, 11 Apr 2024 18:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 03F5E6B0098 for ; Thu, 11 Apr 2024 18:02:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B6663160D24 for ; Thu, 11 Apr 2024 22:02:39 +0000 (UTC) X-FDA: 81998626038.04.73EBB74 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id 8801B16001E for ; Thu, 11 Apr 2024 22:02:37 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X+pN7o0A; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712872958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qyhuPp9+PLD3/FaKDQyfJcp3bUMLi0OXXMTjXjpObkI=; b=RPmFlf+g5IvzaDFrQbl8S/jD1Ul9QlhbGfIscYFZKNV1YOHLvXHbzqMzRcflj8Cw+hOD7p oGLddN9BKtJAKCpTH39fghrPlYtyUv/UGXY7tocm+lDTEkLDcpEt0P6GDfULJn7bH9bKLy +C5XVffW7sx9MYkLfBn82HfI1TmzszM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=X+pN7o0A; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712872958; a=rsa-sha256; cv=none; b=LVgegk5FKxbeKYDUIXM3tM87CiNpDMZG/4LWXQaYWGKWI1+fhag6zvxyVqmCJehgMq8sQy G9vT/jZXbTV6WHyfWorArHHdybbvTcBsssB/kl4wyCq2L1Fqhp8qQEAKez37xlabK2L3g5 8h0Ots+whHu0a4taisTgTQl22I+ZMHw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qyhuPp9+PLD3/FaKDQyfJcp3bUMLi0OXXMTjXjpObkI=; b=X+pN7o0ASwJvbb8sZjisqvHc9U S1oDtJiTROq5HjdUKHRfkWVJ1cmt3HZZvlrEQ8elY3jXUbfRBWMDPY0XU63wlxzK0Go37Ph0Dvum2 MLmMIDHcvXg9td6JZodWRiXKQstQgypz+aa340w0Hcrj0QxN2N07TuZ92855ZggESqb3+d135qLQJ lUQR/ODGdTgnKb4/CW1XW5QeTpH5gX+Cp0peOKqSlpmZRjPF5j10vwWhFVCQnuuv4N4lwzvLZg0gD 1I1FDim+JToPqknbIKzovH712PVd2xoVkWuhsR8lK4aqIIgMK7JaZ73ES8CzZsckSgNDK6nZ3okNI plNROAVA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rv2V6-00000007ozr-3wjA; Thu, 11 Apr 2024 22:02:33 +0000 Date: Thu, 11 Apr 2024 23:02:32 +0100 From: Matthew Wilcox To: Peter Xu Cc: "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Lokesh Gidra , Alistair Popple Subject: Re: [PATCH] mm: Always sanity check anon_vma first for per-vma locks Message-ID: References: <20240410170621.2011171-1-peterx@redhat.com> <20240411171319.almhz23xulg4f7op@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 8801B16001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8ycz4ux8hgrakmid5qd3ctbnzjewtdka X-HE-Tag: 1712872957-221717 X-HE-Meta: U2FsdGVkX1+sJUysysADm16jmcaeumTZ1wZe/dGB4GenPRlOqY+vnURm3+X9L0XVXhGUdZib7Oe1Tlx1aimHNQz5J3XDpc0IFzIlVp0p9ux4TTSArDnhOSAk7lCaQ9+IyHAS8JaVGqg6kZiL7h9vtFImCDafmS+1/Ut8eBqRAGDKb6lhqXRmg/bcViYVkf+vLqiYtqh+8X0u4NjRftbWfdDWHTA+CrnwcNlP2BdN4isolXfQh+Ory3t3Q+n+zCzSwXi4dTtvyRnpyUTfBqblIbADxN1F5cOfH2TIVakey7r2LmRECRRqlbzg8d81M7SPNfog7aVaB+LLOzrovQi3qZSUkcuo/H6WRYTjQLrb7r5Z9Zpev0E1pzMkftrrISwcB3KL22abPG91Q7gMdrgYy9qaPlHRb9/bxE5ps619xjt5Dk+5l6t7j3JYn9vqgUoW0OR7uUN3bkDojzo+A6D7UhzOzLYwVSjv7k1aQ4kthyEZeDCSqs90wCSfZjQcA+Qm8L0al2Brh4I/Km0E0IYB7hn4L95wKsPpKRTi8hVc+sEaO5jyCQHuLu5nlR/lQoHUrylZTw9C0k9df03xXHdkpIbneZvYBENcZ2BUbecGei0OPXyaJ147ObMq+pULu2qN7z4I24KPlHYjF9aI6LOxuw3CiC6NmUG5/DB7rRo0FzH1sFVSNOzKPiET1/9l6adfITkmkOqLageKpUm5QCbjtMgCmcvrOAQYn564JABnqUpdeHMqq1AFrnQUk7Ec+i1jfNK+8wFpkiiCQRGyY1xDQK1zjH6S+p4VRKq60DoUItuSMOojzdz9mYy3fH4V4zHt7SYEgJ3r/i7wnE40/CFKUuOyOw2h+6fameR4zdaXyCiEapKFG1GjPl7YU+EWGEvYSyI9h94LkNrACTCb+HOqxgFSo9lrjSERxu6S93haLVCbyIMNjYTsD5IPiij5d9oHmDuDotj/Htr4gzZdP01 BPlptNR2 wbMGCTFKA43vosSAVavHyXs9LJuMMUxyP3D9ymD0FBEC6s1K4J890tFsURkk/BEjTZjd+5TnbVAJ9EzU9dwlfD5Y+24I5QtB66hDVy1m8irIL+gGExbO87ruTx/euBhU3sSG0yXKpsgpGU4+pLDlMOLIO5nhWEERUAf3TxVxWuqQK+QB1ZBf6IEvOvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 11, 2024 at 05:46:45PM -0400, Peter Xu wrote: > On Thu, Apr 11, 2024 at 10:27:56PM +0100, Matthew Wilcox wrote: > > On Thu, Apr 11, 2024 at 05:12:02PM -0400, Peter Xu wrote: > > > The question is whether that's intended to make it as complicated. For > > > example, why don't we check anon_vma for anonymous too later when prepare > > > anon_vma, however we do it late for file memory. AFAICT there's nothing > > > special with file memory in this case. > > > > Yes, it's absolutely intended. If anything, anon memory is the special > > case that checks up-front. > > > > Congratulations on adding additional instructions to the common case. > > I don't understand why you persist with your nonsense. Please stop. > > How many instructions it takes for a late RETRY for WRITEs to private file > mappings, fallback to mmap_sem? Doesn't matter. That happens _once_ per VMA, and it's dwarfed by the cost of allocating and initialising the COWed page. You're adding instructions to every single page fault. I'm not happy that we had to add extra instructions to the fault path for single-threaded programs, but we at least had the justification that we were improving scalability on large systems. Your excuse is "it makes the code cleaner". And honestly, I don't think it even does that. > Did you even finish reading the patch at all? Yes, I read the whole thing. It's garbage.