Re: [PATCH V4 1/4] mm/memory_hotplug: Prevalidate the address range being added with platform

[David Hildenbrand <david@redhat.com>]

On 25.01.21 03:58, Anshuman Khandual wrote:
> This introduces mhp_range_allowed() which can be called in various memory
> hotplug paths to prevalidate the address range which is being added, with
> the platform. Then mhp_range_allowed() calls mhp_get_pluggable_range()
> which provides applicable address range depending on whether linear mapping
> is required or not. For ranges that require linear mapping, it calls a new
> arch callback arch_get_mappable_range() which the platform can override. So
> the new callback, in turn provides the platform an opportunity to configure
> acceptable memory hotplug address ranges in case there are constraints.
> 
> This mechanism will help prevent platform specific errors deep down during
> hotplug calls. This drops now redundant check_hotplug_memory_addressable()
> check in __add_pages() but instead adds a VM_BUG_ON() check which would
> ensure that the range has been validated with mhp_range_allowed() earlier
> in the call chain. Besides mhp_get_pluggable_range() also can be used by
> potential memory hotplug callers to avail the allowed physical range which
> would go through on a given platform.
> 
> This does not really add any new range check in generic memory hotplug but
> instead compensates for lost checks in arch_add_memory() where applicable
> and check_hotplug_memory_addressable(), with unified mhp_range_allowed().
> 
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Reviewed-by: Oscar Salvador <osalvador@suse.de>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>

[...]

> +
> +struct range mhp_get_pluggable_range(bool need_mapping)
> +{
> +	const u64 max_phys = (1ULL << MAX_PHYSMEM_BITS) - 1;
> +	struct range mhp_range;
> +
> +	if (need_mapping) {
> +		mhp_range = arch_get_mappable_range();
> +		if (mhp_range.start > max_phys) {
> +			mhp_range.start = 0;
> +			mhp_range.end = 0;
> +		}
> +		mhp_range.end = min_t(u64, mhp_range.end, max_phys);
> +	} else {
> +		mhp_range.start = 0;
> +		mhp_range.end = max_phys;
> +	}
> +	return mhp_range;
> +}
> +EXPORT_SYMBOL_GPL(mhp_get_pluggable_range);


Some people might prefer the EXPORT_SYMBOL_GPL() going to the actual
user (patch #4), I don't care :) Thanks!

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb