From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FAAC433B4 for ; Wed, 5 May 2021 11:14:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 327AC613C7 for ; Wed, 5 May 2021 11:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 327AC613C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 795006B006C; Wed, 5 May 2021 07:14:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71D286B006E; Wed, 5 May 2021 07:14:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 549216B0070; Wed, 5 May 2021 07:14:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 34C806B006C for ; Wed, 5 May 2021 07:14:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E5822A763 for ; Wed, 5 May 2021 11:14:26 +0000 (UTC) X-FDA: 78106918932.25.74407D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 72972C0007C9 for ; Wed, 5 May 2021 11:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620213265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vlQdZDxdtDpmyzdzOMVSqfZvSbkAtbDp7XD0iOszPH0=; b=bN89x2WkqM3hWoxF6nGJ3ULulxZp57y5i8X0Elzaen8B+p7OtvJ+NfFKVb7dzENqZsM2QD 9Y1YHuqHBZM16xo0KzpdBwozWEkFy6wH9qv1G/y0Ht8mH/4VXRjm4kBVIaQ7C1Q6HBwedF LeN2KlyjsWKbOmQnT2f7rddlYgseZWI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551---9OO2qQM-WI7WA0QjS2fw-1; Wed, 05 May 2021 07:14:24 -0400 X-MC-Unique: --9OO2qQM-WI7WA0QjS2fw-1 Received: by mail-wr1-f72.google.com with SMTP id h104-20020adf90710000b029010de8455a3aso557660wrh.12 for ; Wed, 05 May 2021 04:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vlQdZDxdtDpmyzdzOMVSqfZvSbkAtbDp7XD0iOszPH0=; b=IvYAPTnc+iPLZAtf/7x+K4c34UAHNEvWXp4ZrMFnOcqwYL6/wY4fkPeIu8CyAmMNeo 6mHTxcnNVmNpWAz3DVdmn6WrjpKSh6BDwUpl8/C2fOR9YJz7VRaTf/YFohN+YnQvDVBf 1FM9dn7aiXDzj+PQvavt338nb/kOkdBed7LBl9FEMoFvOwUjUnVbyt+QAoRQ9aAdipQa txI7tHEwWVlOlJrea48xpDWj0vdv9V3HJabQ+9bpoHN8i6N6YBey2jri6wQCzakMGXVW Ka+oFP9L7nyb8SQfre31yLL5vdyhq8+3PJUsmPAiUYEfI40tag25hPaq+x0DcS51Ngy1 7X5A== X-Gm-Message-State: AOAM532Hl+fW4CA8/daesNdEi4bC/mmDIJf+R9SXjGlFzl9v71YIFu6D zzlEHzcF0dnTsMZYZBvzjxvvH3Vf+aA8orzPqaNFGxBm9DUkxXVTLnKa0Irmxso8hN1BuU8DOZp QkQaMc3julzo= X-Received: by 2002:a5d:6e11:: with SMTP id h17mr4099504wrz.331.1620213263184; Wed, 05 May 2021 04:14:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbp+IuFL9y7PdYXvXqJOPhuWFItd6hzVhZYzE8i1fkoAg5gdrqwoi11M+U5pAkhFB1b+BhwA== X-Received: by 2002:a5d:6e11:: with SMTP id h17mr4099479wrz.331.1620213262965; Wed, 05 May 2021 04:14:22 -0700 (PDT) Received: from [192.168.3.132] (p5b0c63bc.dip0.t-ipconnect.de. [91.12.99.188]) by smtp.gmail.com with ESMTPSA id i13sm19403759wrs.12.2021.05.05.04.14.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 04:14:22 -0700 (PDT) Subject: Re: [PATCH] nommu: remove __GFP_HIGHMEM in vmalloc/vzalloc To: Chen Li , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <875z00rnp8.wl-chenli@uniontech.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 5 May 2021 13:14:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <875z00rnp8.wl-chenli@uniontech.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bN89x2Wk; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf03.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: k8uehyo4co8n53rxi9tba1yxwmz6hza1 X-Rspamd-Queue-Id: 72972C0007C9 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620213259-875146 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.05.21 14:44, Chen Li wrote: > > From mm/nommu.c: > void *__vmalloc(unsigned long size, gfp_t gfp_mask) > { > /* > * You can't specify __GFP_HIGHMEM with kmalloc() since kmalloc() > * returns only a logical address. > */ > return kmalloc(size, (gfp_mask | __GFP_COMP) & ~__GFP_HIGHMEM); > } > > nommu's __vmalloc just uses kmalloc internally and elimitates __GFP_HIGHMEM, > so it makes no sense to add __GFP_HIGHMEM for nommu's vmalloc/vzalloc. > > Signed-off-by: Chen Li > --- > mm/nommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index 5c9ab799c0e6..339a2f2eb1aa 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -233,7 +233,7 @@ long vwrite(char *buf, char *addr, unsigned long count) > */ > void *vmalloc(unsigned long size) > { > - return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM); > + return __vmalloc(size, GFP_KERNEL); > } > EXPORT_SYMBOL(vmalloc); > > @@ -251,7 +251,7 @@ EXPORT_SYMBOL(vmalloc); > */ > void *vzalloc(unsigned long size) > { > - return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM | __GFP_ZERO); > + return __vmalloc(size, GFP_KERNEL | __GFP_ZERO); > } > EXPORT_SYMBOL(vzalloc); > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb