From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E39C7EE2F for ; Wed, 1 Mar 2023 16:21:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB41C6B0071; Wed, 1 Mar 2023 11:21:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3C976B0072; Wed, 1 Mar 2023 11:21:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADDE66B0073; Wed, 1 Mar 2023 11:21:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9EDB36B0071 for ; Wed, 1 Mar 2023 11:21:24 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6A756C0C63 for ; Wed, 1 Mar 2023 16:21:24 +0000 (UTC) X-FDA: 80520844488.19.2567EAD Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf08.hostedemail.com (Postfix) with ESMTP id AD562160021 for ; Wed, 1 Mar 2023 16:21:21 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M8iGO0RB; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677687682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zXpzuxOMceLSpxAI0XqAv2WmprFOCnIAyBS8Ee1CVWI=; b=Z7kAwbAznLaOChP8CBkLL+YedZsmkbLUQKZRF0xz/HUtjW1LpZYEw6EAOkbwN5+P3lCrzF jnuG3Zgm6vqAHIHgFEG5PBW59artoW5z6TGlPCS+zxXmMzY20kLmsL810HtR18QAcD1mve y40JBimgnXylx+LO5YWKjWQ4hzn3M+E= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M8iGO0RB; spf=pass (imf08.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677687682; a=rsa-sha256; cv=none; b=zXTE3gbbotGpobvkOZIYmPENcsjmUpSSEuxuyHnHP9ApwCwYimY8h5xJU0g9hbKwG4miE4 i7VmuduJJjKYJ9sTUKoQPqApN8GiUEYgLXSr3+ONlQnVIITG0uNCeCqY8pPWDgJSBtzBSd ubqSh6S6A62WTeeqLYRcujl3iLEVqLM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677687681; x=1709223681; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=99e5KN1R/O+8i5rO5OW9FmQOG2BY+kuQaZF2MSYyEdI=; b=M8iGO0RBerhIbnLOrvJiYTSNYeo9zX9cPkpoYtVvfYd+1Eponnt9p5Dw 7Y5sqMewGCyM6awCi5NJlElUXQok3PPNSc3OQdEneJ/D+4f5JDVuOm/gR 62M2b82vKb8NjOAuf3ToqgChD7UE63JlQxHP7zUk4p05yngG1P2ygXziR cl8g56tNAkRLmnu5x2iA+xK5x+FD632nczLA/1ldaBJfHhBt2NF4t88RI SdZv10rVvNKIfcJYu0c6PWinu41Hu1brv1K2DmDlXOWbnzdQYi5OthXWK 0peRpPOul3sWRsYO1oTF3/wgec4M0ddViPhsi+X5qKJ5pQsZ8BmAUGGyD Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="335942703" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="335942703" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 08:21:19 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="674623570" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="674623570" Received: from asaha3-mobl1.amr.corp.intel.com (HELO [10.251.12.67]) ([10.251.12.67]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 08:21:18 -0800 Message-ID: Date: Wed, 1 Mar 2023 08:21:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH RFC v8 17/56] x86/fault: Add support to handle the RMP fault for user address Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, Brijesh Singh , Jarkko Sakkinen References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-18-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230220183847.59159-18-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AD562160021 X-Stat-Signature: tb8oq5bxjk9kasctd7e5s1qqcbdz3fsr X-Rspam-User: X-HE-Tag: 1677687681-746423 X-HE-Meta: U2FsdGVkX19dd1dAuSao45IGHp05LYGJ+4BKHmD+l62eizG2d0SzA3PujPVEW3m+dZK7BSVQqYdwXEdhSV55r4+Ey5/Wdyehdz+2xUt70sXEfDIOUblP43QOAaj3zPZanjfpndwT139wQNwWkyqo1wlQ+JVoW67DqodvJdpTeAigHpsNUaeXZL7XXGSX8juClKxWUBUOoc1Bn1/C5WUrHOtMNuF+r1LB6QI0KEeNzDe57zzMeNEKAYqCghi2do1i2HOdd3n7Ae9MiN0Qb4pznqaOcSUN9e0i+3TngD18u7wF1eSU+nBJ9E0eGf4qK+o/FkNjtVuCbu/ieaBqJz/1QunXTyCmEyobclMRPiUyzGoO+tmpPwOULMkhkAWR+DMV6avAWJcTnCf/PsYk5z6xu/N3Y1BNNvf4RRRguvGjnLmtjM9cTrjGk2whYMGPwAzYsuHydl5WaOeYGMSjnlDjyfA8B4RRpLY1oi980OSOD/fx4T03oo8ITLRvLtle4dynpVwTx2pXgfa07jYXOLbQNWAHLUY/nlsveXv8VX+949ui+YR/OJNyxSB/5UED/uIcjohZREfOea5DCu4oXaPtNZpftTBwTHGi4t2yZLyKC+jOpMngalZ6VHt23dt+5J61AGn2nW4oylBiNEyrnypkwsQ1mvI0lMTLe7qwtzd85hGD3zFe09yso7ST7Ud00/MNYfHewIM3wyAMvG+bpX9ZbPBEBQNIPx5G4u72Mc06sF3ystQEidZpLoWazOYfwE1A/w9K8rdl9UkNEZyX81n42t+i/lAETi0PLiVtidMKkDhWaNObp3gubXYpi2+Eay+Iry56BJX/AyMeoWGjtDEBHCOIFCtfTkRmjZmBVAo6GoOR9hbHuPv3r79eRcvZ6NsEERvlZzqsOwC+2yvK8uYu0HGVHesljPko3xfX1cnn81GcDf+AJYF3MaGN9C93qO3gRoGSa6/n68C6+J+SWwE 6xR9yXTb tkgvqMr0Ei69YYBv+tSSj/LSfUH9hUxy8KVXW2E2zSLKYObDIi6SUDZzox3idgzHgmmmVjzF4AgSlAru3eiIr1QIa4w3+Ky4pVCt4q0V2xtwbtpZSDk1VrIZO9gjPjaFxEL1DB6dM3hQRjtsQNstLuMJBKFmOuXvKoMWm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/20/23 10:38, Michael Roth wrote: > +static int handle_split_page_fault(struct vm_fault *vmf) > +{ > + __split_huge_pmd(vmf->vma, vmf->pmd, vmf->address, false, NULL); > + return 0; > +} > + > /* > * By the time we get here, we already hold the mm semaphore > * > @@ -5078,6 +5084,10 @@ static vm_fault_t __handle_mm_fault(struct vm_area_struct *vma, > pmd_migration_entry_wait(mm, vmf.pmd); > return 0; > } > + > + if (flags & FAULT_FLAG_PAGE_SPLIT) > + return handle_split_page_fault(&vmf); I asked this long ago, but how do you prevent these faults from occurring on hugetlbfs mappings that can't be split?