From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005A9C433DF for ; Sat, 11 Jul 2020 01:40:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A55C420674 for ; Sat, 11 Jul 2020 01:40:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="MTFO5KuR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A55C420674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A9A88D0005; Fri, 10 Jul 2020 21:40:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 359208D0001; Fri, 10 Jul 2020 21:40:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26EBB8D0005; Fri, 10 Jul 2020 21:40:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 11F688D0001 for ; Fri, 10 Jul 2020 21:40:57 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9B76B2C1F for ; Sat, 11 Jul 2020 01:40:56 +0000 (UTC) X-FDA: 77024091312.05.crush34_1003f3126ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 75DC218027FAD for ; Sat, 11 Jul 2020 01:40:56 +0000 (UTC) X-HE-Tag: crush34_1003f3126ed3 X-Filterd-Recvd-Size: 3982 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 01:40:55 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 10 Jul 2020 18:39:05 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 10 Jul 2020 18:40:54 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 10 Jul 2020 18:40:54 -0700 Received: from [10.2.51.208] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 11 Jul 2020 01:40:54 +0000 Subject: Re: [PATCH v2 3/6] mm: Print head flags in dump_page To: "Matthew Wilcox (Oracle)" , CC: Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport References: <20200709202117.7216-1-willy@infradead.org> <20200709202117.7216-4-willy@infradead.org> From: John Hubbard Message-ID: Date: Fri, 10 Jul 2020 18:40:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709202117.7216-4-willy@infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594431545; bh=Dbknv+00/8jvvQSUZkALViY64wa8HT9wFEbqYsDypj8=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=MTFO5KuRA3xwk/rxTT/wj9XKRBNfhCyXe7XZLD5jYChWJru2orG5WGeoGmQNzLs42 yODlRgv4HpsR2ZGW8CLqHYv34yPOhOqEZ+k/UKhyv6k30irpnP+nDMYlASQzhGINaM KrJPh/l0vVOk/AXV8AHX4X2omei/nPirs0lrK20v5t4Nffvi2KdtXXaMkax+mdksuo 8xqe6vQRTc2J9BUodwmHZTg6T+dzQRfo+tBlAAKqSdq//hNYIShD8G2gr2YgKQY/Jw aliUiSwyv1j1Vfh1q3YhuSQdpXGEPAqyo9qiAOgZjYsrt7+DWzLDfK4HnmvB9Uvw9i g+9bJ537lWxUA== X-Rspamd-Queue-Id: 75DC218027FAD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-07-09 13:21, Matthew Wilcox (Oracle) wrote: > Tail page flags contain very little useful information. Print the head > page's flags instead. While the flags will contain "head" for tail pages, > this should not be too confusing as the previous line starts with the > word "head:" and so the flags should be interpreted as belonging to > the head page. Yes, OK. I'm still *slightly* disappointed about the tail page showing "head" in the flags, but that's a minor complaint and we've seen that it's actually pretty hard to do better, given the situation. And overall, the output is definitely way better than before this series. Thanks for all the cleanup! Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/debug.c b/mm/debug.c > index f35c1ae1a7a5..d2ffc926d8f5 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -162,7 +162,7 @@ void __dump_page(struct page *page, const char *reason) > out_mapping: > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > > - pr_warn("%sflags: %#lx(%pGp)%s\n", type, page->flags, &page->flags, > + pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags, > page_cma ? " CMA" : ""); > > hex_only: >