From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6317ECE58C for ; Thu, 10 Oct 2019 00:46:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 97629206C0 for ; Thu, 10 Oct 2019 00:46:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Pcv2RYJi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97629206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 582B86B0006; Wed, 9 Oct 2019 20:46:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B628E0005; Wed, 9 Oct 2019 20:46:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2EA8E0003; Wed, 9 Oct 2019 20:46:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 14C5E6B0006 for ; Wed, 9 Oct 2019 20:46:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 94400180AD7C3 for ; Thu, 10 Oct 2019 00:46:22 +0000 (UTC) X-FDA: 76026033804.08.wave56_379c7a5d65112 X-HE-Tag: wave56_379c7a5d65112 X-Filterd-Recvd-Size: 4342 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Oct 2019 00:46:21 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9A0iLlM171680; Thu, 10 Oct 2019 00:46:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=wUw24dYwtRzDhdQ0o8HSROqGQRo01O5bW3h5i/yV0YA=; b=Pcv2RYJi0amWYNl6TCUmkcbjGAM5sjbz7jTIlFs2/MKodKTj2PV631IsY4xMYJFZZnqy k8lk7AzWgZmd8xOf+cemErBCvwQV38bmGlnVeCDdDi7Dp6C+SALF42S7u7ldrgD/CphO 5l6JouFMsSSpBzvrrLwLnmBaEgXQ45o4iuTXXp1FRjvn0AQPdnocmDQ+HnfmTia4qHlk 7hRowDQb9yvSffzX6g3y/PtlVzWEqk7gyupPwz0dj4Z1C5f0j72BxKbmnbdaAWy3SCbC DPSZ7TnSJN9TresoCGKzDXPqtDTEUFd8PSgPWyZa6ABrbI1LEKTCmls87Hlnlvhk4Bbf eA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2vek4qqx6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Oct 2019 00:46:07 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9A0cujo051434; Thu, 10 Oct 2019 00:46:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2vhhsnm5ee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Oct 2019 00:46:07 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9A0jxYL026366; Thu, 10 Oct 2019 00:45:59 GMT Received: from [192.168.1.222] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Oct 2019 17:45:59 -0700 Subject: Re: [PATCH -next] userfaultfd: remove set but not used variable 'h' To: YueHaibing , Andrea Arcangeli , "Joel Fernandes (Google)" , Andrew Morton , Stephen Rothwell , Wei Yang , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20191009122740.70517-1-yuehaibing@huawei.com> From: Mike Kravetz Message-ID: Date: Wed, 9 Oct 2019 17:45:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191009122740.70517-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9405 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910100003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9405 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910100004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/9/19 5:27 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': > mm/userfaultfd.c:217:17: warning: > variable 'h' set but not used [-Wunused-but-set-variable] > > It is not used since commit 78911d0e18ac ("userfaultfd: use vma_pagesize > for all huge page size calculation") > Thanks! That should have been removed with the recent cleanups. > Signed-off-by: YueHaibing Reviewed-by: Mike Kravetz -- Mike Kravetz