From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9AFC433E6 for ; Tue, 5 Jan 2021 18:28:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0AC422CE3 for ; Tue, 5 Jan 2021 18:28:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0AC422CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C2608D00A4; Tue, 5 Jan 2021 13:28:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 074648D00A3; Tue, 5 Jan 2021 13:28:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED0628D00A4; Tue, 5 Jan 2021 13:28:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id D0B048D00A3 for ; Tue, 5 Jan 2021 13:28:22 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8DB86180AD81D for ; Tue, 5 Jan 2021 18:28:22 +0000 (UTC) X-FDA: 77672556444.21.geese48_4802f74274db Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 60FD0180442C0 for ; Tue, 5 Jan 2021 18:28:22 +0000 (UTC) X-HE-Tag: geese48_4802f74274db X-Filterd-Recvd-Size: 4340 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Jan 2021 18:28:21 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id s130so176664wme.0 for ; Tue, 05 Jan 2021 10:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=L2nfB5IDe6UR5zw3FZON/Z4AbH3dOVMSon2hvUv5xm8=; b=bRtGkcqXoe/bYVma5AcnnGEw1YbmPZW7e5RZXt5m1DN0wQ9mvEH4lwvMIKdWFu4pK0 gUbgLnCx+fZ9UPd+dvdcgg9Li0HTeBQOJLIaB+1EZgkC+J8Hqs5lDgOR5xNVOiBm26P3 jbqkhqEe7I2Ens74zeOsbOmJPbG/DNqEhlSfd3HTqf9FbJ/EsmPHLRmbu3in6OgZji8S /WW5QKCaOxuXsbSEuZ5ZuXa6BS7q2MwZcaNyQwhHpcPaGbcQ3zZpZYW84NWjyRw+5hqG xVADG0uids3vUoGlqxxeXHkD8gJeVLIyGbNVXR5qPlikY/okOEcDp1UK/bbzGd1wm0J2 7F4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=L2nfB5IDe6UR5zw3FZON/Z4AbH3dOVMSon2hvUv5xm8=; b=cW4VAiwy9p+lT6YO+pVIaB7RsKpB/Nf71NTFnsvBIm5qqHug6A5oLfqzJHUdIMCYnc Lev1ABFmyVo5YzUyJN3gvzOSgAmOMuzybs/evPWXxD0U4NGuNUUqn3IS9nu/Oq+Rkxpd gMyxv29PegxAELXX54ZCX6xR0DKYg2dkz2bntVhi+/jq6rTvFoAPCwbz9GGU1neOeTEE 8dbUhIMVQmnMr7ZyJbaGIlGLg/ki4eiTEUFNJZIkALjy1PX6BPUJ18nFHXOQ+w4Rnhwu nIeG5rbwZnG2aG64xV8Tlk4VFf0sjOplAqn8LCQEVoWMgdy8m/FQpy3QLxgBolK6ofmc pwXg== X-Gm-Message-State: AOAM5324Y7P5MM7zNIB8uhMSSH3q7EejT+D1llE+uHd55KGsXb2jyfYu rhPgn88ahGqzy12wsHl8ZXPRxu7/naxEV7VK X-Google-Smtp-Source: ABdhPJxm3lGUAgt1hjvEO/hnJ/HMsTuIHIRoW/Dg0H1aF9WW7wHG1xDYIpDPY8Dcc0/roDN0xvdsNxb67+kdPpfe X-Received: from andreyknvl3.muc.corp.google.com ([2a00:79e0:15:13:7220:84ff:fe09:7e9d]) (user=andreyknvl job=sendgmr) by 2002:adf:f18a:: with SMTP id h10mr893184wro.244.1609871300796; Tue, 05 Jan 2021 10:28:20 -0800 (PST) Date: Tue, 5 Jan 2021 19:27:51 +0100 In-Reply-To: Message-Id: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.29.2.729.g45daf8777d-goog Subject: [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL From: Andrey Konovalov To: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver Cc: Andrew Morton , Will Deacon , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It might not be obvious to the compiler that the expression must be executed between writing and reading to fail_data. In this case, the compiler might reorder or optimize away some of the accesses, and the tests will fail. Add compiler barriers around the expression in KUNIT_EXPECT_KASAN_FAIL. Signed-off-by: Andrey Konovalov Link: https://linux-review.googlesource.com/id/I046079f48641a1d36fe627fc8827a9249102fd50 --- lib/test_kasan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index dd3d2f95c24e..b5077a47b95a 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -79,7 +79,9 @@ static void kasan_test_exit(struct kunit *test) NULL, \ &resource, \ "kasan_data", &fail_data); \ + barrier(); \ expression; \ + barrier(); \ KUNIT_EXPECT_EQ(test, \ fail_data.report_expected, \ fail_data.report_found); \ -- 2.29.2.729.g45daf8777d-goog