From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30F6C4361B for ; Tue, 8 Dec 2020 09:07:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20BB523A7F for ; Tue, 8 Dec 2020 09:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20BB523A7F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 833546B0068; Tue, 8 Dec 2020 04:07:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2D36B006C; Tue, 8 Dec 2020 04:07:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FA0A6B006E; Tue, 8 Dec 2020 04:07:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 591256B0068 for ; Tue, 8 Dec 2020 04:07:57 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 201908249980 for ; Tue, 8 Dec 2020 09:07:57 +0000 (UTC) X-FDA: 77569537794.02.talk00_0b07096273e5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 077ED10097AA0 for ; Tue, 8 Dec 2020 09:07:57 +0000 (UTC) X-HE-Tag: talk00_0b07096273e5 X-Filterd-Recvd-Size: 3078 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 09:07:55 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0UHyFft1_1607418468; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UHyFft1_1607418468) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Dec 2020 17:07:49 +0800 Subject: Re: [PATCH 09/11] mm: fold __update_lru_size() into its sole caller To: Yu Zhao , Andrew Morton , Hugh Dickins Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201207220949.830352-1-yuzhao@google.com> <20201207220949.830352-10-yuzhao@google.com> From: Alex Shi Message-ID: Date: Tue, 8 Dec 2020 17:07:48 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201207220949.830352-10-yuzhao@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Reviewed-by: Alex Shi =E5=9C=A8 2020/12/8 =E4=B8=8A=E5=8D=886:09, Yu Zhao =E5=86=99=E9=81=93: > All other references to the function were removed after > commit a892cb6b977f ("mm/vmscan.c: use update_lru_size() in update_lru_= sizes()") >=20 > Signed-off-by: Yu Zhao > --- > include/linux/mm_inline.h | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) >=20 > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index 7183c7a03f09..355ea1ee32bd 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -24,7 +24,7 @@ static inline int page_is_file_lru(struct page *page) > return !PageSwapBacked(page); > } > =20 > -static __always_inline void __update_lru_size(struct lruvec *lruvec, > +static __always_inline void update_lru_size(struct lruvec *lruvec, > enum lru_list lru, enum zone_type zid, > int nr_pages) > { > @@ -33,13 +33,6 @@ static __always_inline void __update_lru_size(struct= lruvec *lruvec, > __mod_lruvec_state(lruvec, NR_LRU_BASE + lru, nr_pages); > __mod_zone_page_state(&pgdat->node_zones[zid], > NR_ZONE_LRU_BASE + lru, nr_pages); > -} > - > -static __always_inline void update_lru_size(struct lruvec *lruvec, > - enum lru_list lru, enum zone_type zid, > - int nr_pages) > -{ > - __update_lru_size(lruvec, lru, zid, nr_pages); > #ifdef CONFIG_MEMCG > mem_cgroup_update_lru_size(lruvec, lru, zid, nr_pages); > #endif >=20