From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 186B2C6377D for ; Thu, 22 Jul 2021 11:52:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F1A261355 for ; Thu, 22 Jul 2021 11:52:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F1A261355 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C303C6B0036; Thu, 22 Jul 2021 07:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0786B005D; Thu, 22 Jul 2021 07:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACF926B006C; Thu, 22 Jul 2021 07:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 8FAF06B0036 for ; Thu, 22 Jul 2021 07:52:31 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3B2A6181AEF3C for ; Thu, 22 Jul 2021 11:52:31 +0000 (UTC) X-FDA: 78390061302.39.9E14E8D Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf30.hostedemail.com (Postfix) with ESMTP id EE44DE00182E for ; Thu, 22 Jul 2021 11:52:30 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id g22so8154478lfu.0 for ; Thu, 22 Jul 2021 04:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ypKqM7KTx5GpDb/y7PGXXY/nEaOI08qXqRMcMGLHsKU=; b=Co2isklHqoeK+dVakSgNHl1oaYC9tuYysc/z5nwhR3VrEEJOloyqQJolx8feidgI2N ElgwJgIBswly6hyU6XFqmMNhxtXQxVGpf1WbmLUeWByCdqiGWCg5e/FUzZsmVQQAxooB X/Zw56MlS/+Y9Kbd7goKvDrb1ckkoQnynCg5lcAUSz+HQMbh1lbYMWy4z+fANVX0uyP8 UfQiHSRYYGGlClGYooUJffvGkMxOxwj91cM0DHyXxrc6/rrEA6FaWUfWXMmNB1CmnQgE pWPzKf/cxv9issJjiSM4eE320SYJBlYjwTccZ01uEu159EFWzwb/dRYqDvIaaIA6S4Bm ESGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ypKqM7KTx5GpDb/y7PGXXY/nEaOI08qXqRMcMGLHsKU=; b=U7Ke4QE/mPbmE059ptLr5ztRnyxFt4Q8TbTwKBf5sHPS4uF84TJM0mX9xwKKjRbQzZ 3Va7hIxuYJ3m0+07MQRJNhWVrNc6XAZ8GgC5a/VE1Ti2VSs34UJbHrWULt1tYCi69ABV oW1VSxbqwHZcB7AYnIQdSFN1Nht5+dJOi3SwzH9Lqe+/gqWGfJkR3IrN2qgc4ja7oeV9 l5gNYWuz+aJaBzsHQqWkiIqPM+b/klIIwD8ZvYs5aQjOHqbAAVtazkbKY02U+lcRRz7X LnqRy5nybneLj+HrnmJ/aE4I71O+H79hMBlsBFPt7eGwS0DsnDfVzWd+kc+7tGImaCjD TB4Q== X-Gm-Message-State: AOAM532TjMhtAlIm5vPcDQtxpAR+EYX3s3VCU6jJw5RV9ogRN3YrZV3p DkTs40+TxIbF7Rw+6MtlIvU= X-Google-Smtp-Source: ABdhPJyQqV5j32AB3JiK3JxX8PRQKtaHRVok6krIaVVBKgiYVsFhCKwwo1GtwUnNXDsB5GfcKeqEJA== X-Received: by 2002:a05:6512:68c:: with SMTP id t12mr12714146lfe.224.1626954749387; Thu, 22 Jul 2021 04:52:29 -0700 (PDT) Received: from [192.168.2.145] (79-139-184-182.dynamic.spd-mgts.ru. [79.139.184.182]) by smtp.googlemail.com with ESMTPSA id l21sm2623692ljc.94.2021.07.22.04.52.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jul 2021 04:52:29 -0700 (PDT) Subject: Re: [PATCH v14 062/138] mm/migrate: Add folio_migrate_copy() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-63-willy@infradead.org> From: Dmitry Osipenko Message-ID: Date: Thu, 22 Jul 2021 14:52:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-63-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE44DE00182E X-Stat-Signature: fe1u1q9kk5hg4m3y1bx6twdtexd6tgrk Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Co2isklH; spf=pass (imf30.hostedemail.com: domain of digetx@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=digetx@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1626954750-71015 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 15.07.2021 06:35, Matthew Wilcox (Oracle) =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > This is the folio equivalent of migrate_page_copy(), which is retained > as a wrapper for filesystems which are not yet converted to folios. > Also convert copy_huge_page() to folio_copy(). >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/migrate.h | 1 + > include/linux/mm.h | 2 +- > mm/folio-compat.c | 6 ++++++ > mm/hugetlb.c | 2 +- > mm/migrate.c | 14 +++++--------- > mm/util.c | 6 +++--- > 6 files changed, 17 insertions(+), 14 deletions(-) Hi, I'm getting warnings that might be related to this patch. [37020.191023] BUG: sleeping function called from invalid context at mm/u= til.c:761 [37020.191383] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 29,= name: kcompactd0 [37020.191550] CPU: 1 PID: 29 Comm: kcompactd0 Tainted: G W = 5.14.0-rc2-next-20210721-00201-g393e9d2093a1 #8880 [37020.191576] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) [37020.191599] [] (unwind_backtrace) from [] (show_st= ack+0x11/0x14) [37020.191667] [] (show_stack) from [] (dump_stack_lv= l+0x2b/0x34) [37020.191724] [] (dump_stack_lvl) from [] (___might_= sleep+0xed/0x11c) [37020.191779] [] (___might_sleep) from [] (folio_cop= y+0x3f/0x84) [37020.191817] [] (folio_copy) from [] (folio_migrate= _copy+0x11/0x1c) [37020.191856] [] (folio_migrate_copy) from [] (__buf= fer_migrate_page.part.0+0x215/0x238) [37020.191891] [] (__buffer_migrate_page.part.0) from [] (buffer_migrate_page_norefs+0x19/0x28) [37020.191927] [] (buffer_migrate_page_norefs) from [= ] (move_to_new_page+0x4d/0x200) [37020.191960] [] (move_to_new_page) from [] (migrate= _pages+0x521/0x72c) [37020.191993] [] (migrate_pages) from [] (compact_zo= ne+0x589/0xb60) [37020.192031] [] (compact_zone) from [] (proactive_c= ompact_node+0x53/0x6c) [37020.192064] [] (proactive_compact_node) from [] (k= compactd+0x20b/0x238) [37020.192096] [] (kcompactd) from [] (kthread+0x123/= 0x140) [37020.192134] [] (kthread) from [] (ret_from_fork+0x= 11/0x1c) [37020.192164] Exception stack(0xc1751fb0 to 0xc1751ff8)