From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2ABAC433F5 for ; Mon, 7 Feb 2022 18:20:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B7026B0074; Mon, 7 Feb 2022 13:20:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 365806B0075; Mon, 7 Feb 2022 13:20:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C0A6B0078; Mon, 7 Feb 2022 13:20:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 1A8DF6B0074 for ; Mon, 7 Feb 2022 13:20:47 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D63D4181CB2C1 for ; Mon, 7 Feb 2022 18:20:46 +0000 (UTC) X-FDA: 79116799692.18.F31BAB6 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf16.hostedemail.com (Postfix) with ESMTP id 7CC05180003 for ; Mon, 7 Feb 2022 18:20:46 +0000 (UTC) Received: by mail-qk1-f171.google.com with SMTP id g145so11680246qke.3 for ; Mon, 07 Feb 2022 10:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=I2DL4qfJF0wopDmaBBJJTApXAPXSGaVHG9z0BUOLoOE=; b=YbIKyftG6woux+8E1fgQAiMqIm0TvfqEDBedwgGD1Uwetzo9ic30PxX8iS6T8ocVPu /UN9gvBNac/kfAGnW2Tdm1B84NCCvsL2yNqm0iKD7yhZdUvAx7V+EyVe1LXZ/vLFoQtk TaKlKfsCnhc6OiCPjwIUEYKxBBv30KKyQwyDvfgyevj9sv5kK+0PVHXK0KLpjEmR60cc YZiIaiCQ3F8+DqssVfipX1f0QMEyYkKMT3KH2B6EgA0FcClk7mgRuXt1469TcnJ+ukDx WHlIOl4TclX3+0tnMZx8IOih5iFplVmQzdt0xVHT21WzmS3GEePsQiEy5dnfuS7kcCus InAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=I2DL4qfJF0wopDmaBBJJTApXAPXSGaVHG9z0BUOLoOE=; b=tGci9u4jznoep2a7a9lMujIKSGlS/UA7m1NHaULTQCyDA0w1UTZ9sJ8HE0z8WH5L7G jfT4PNVKqKcmIw5owCgvjX7eFskoytcfHpIOtHvoGanE4eeRS7ZQvNUP9e+X0z26ozS9 xaV6MVT+BYeUC2PBhiPwOqu+KZtq15M5Fm072gXQmdStSrSQlpPNRHmjA8l1d710Gd91 VpfXJFJ921IvR/HPEQUfjLNeRZevPw8nM1wqfp+1GMpiAOvJVAXmJYizdT85R/jwmtLV U+n9GAgU3gpf+civ8jchMMWHgEHMjiF+95lL4nPbCWEcvhl9PKdg/hUOOt2xpPHA0xn5 q/3A== X-Gm-Message-State: AOAM5317h/eIleckKX+cIc+FUwZKUhbbldpPcBDKeRw31HG9zwD6YT9I tHeKLobHLdvO0AyFdxzDdORqpQ== X-Google-Smtp-Source: ABdhPJyD9GfKfmksb7UZOqPKAtYdNuGTXOOd/DmqknB0tstTGMTuqgIX2/xe3DLPraRPnj8G/jUSKA== X-Received: by 2002:a05:620a:4614:: with SMTP id br20mr615237qkb.172.1644258045571; Mon, 07 Feb 2022 10:20:45 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id i20sm6133901qtx.44.2022.02.07.10.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 10:20:44 -0800 (PST) Date: Mon, 7 Feb 2022 10:20:23 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Michal Hocko , Vlastimil Babka , "Kirill A. Shutemov" , David Hildenbrand , Alistair Popple , Johannes Weiner , Rik van Riel , Suren Baghdasaryan , Yu Zhao , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/13] mm/munlock: rework of mlock+munlock page handling In-Reply-To: Message-ID: References: <8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7CC05180003 X-Stat-Signature: p9c73i3nq8kkf9r5zc4si8eda1zgqemw Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YbIKyftG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of hughd@google.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspam-User: nil X-HE-Tag: 1644258046-312933 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 6 Feb 2022, Matthew Wilcox wrote: > On Sun, Feb 06, 2022 at 01:27:41PM -0800, Hugh Dickins wrote: > > Here it is based on 5.17-rc2, applies also to -rc3, almost cleanly to > > mmotm 2022-02-03-21-58 (needs two easy fixups in mm/huge_memory.c); but > > likely to conflict (I hope not fundamentally) with several concurrent > > large patchsets. > > Most of this patchset hasn't arrived here yet, but I would be > _delighted_ to rebase the folio conversion on top of this. What > convoluted code it is! I am so glad you've cleaned this up; I was > dreading doing the rest of the mlock file. That's a very generous offer: thank you. I'd been looking at it the other way round, afraid that it would be getting in your way: but now think you're right, that the cleanup there will help your work. I had found mm/mlock.c unexpectedly difficult to deal with when doing shmem huge pages, and IIRC Kirill had the same experience. Hugh