From: Yang Shi <yang.shi@linux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Hugh Dickins <hughd@google.com>,
kirill.shutemov@linux.intel.com, aarcange@redhat.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially
Date: Fri, 14 Feb 2020 09:17:26 -0800 [thread overview]
Message-ID: <a6ee0597-dc5f-6aaf-4651-f588cc62599c@linux.alibaba.com> (raw)
In-Reply-To: <20200214154021.kgeon6i76yfdbaa5@box>
On 2/14/20 7:40 AM, Kirill A. Shutemov wrote:
> On Thu, Feb 13, 2020 at 04:38:01PM -0800, Yang Shi wrote:
>> Hi Kirill,
>>
>>
>> Would you please help review this patch? I don't know why Hugh didn't
>> response though I pinged him twice.
> I have not noticed anything wrong with the patch.
>
> But the function gets ugly beyond the reason. Any chance you could
> restructure it to get somewhat maintainable? (It's not easy, I know).
Yes, those goto looks not neat. I'm going to give it a try. Any
suggestion is absolutely welcome.
>
next prev parent reply other threads:[~2020-02-14 17:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 0:42 [v2 PATCH] mm: shmem: allow split THP when truncating THP partially Yang Shi
2019-12-05 0:15 ` Hugh Dickins
2019-12-05 0:50 ` Yang Shi
2020-01-14 19:28 ` Yang Shi
2020-02-04 23:27 ` Yang Shi
2020-02-14 0:38 ` Yang Shi
2020-02-14 15:40 ` Kirill A. Shutemov
2020-02-14 17:17 ` Yang Shi [this message]
2020-02-25 3:46 ` Hugh Dickins
2020-02-25 18:02 ` David Hildenbrand
2020-02-25 20:31 ` Hugh Dickins
2020-02-26 17:43 ` Yang Shi
2020-02-27 1:16 ` Matthew Wilcox
2020-02-27 1:47 ` Hugh Dickins
2020-02-27 1:37 ` Hugh Dickins
2020-02-20 18:16 ` Alexander Duyck
2020-02-21 9:07 ` Michael S. Tsirkin
2020-02-21 9:36 ` David Hildenbrand
2020-02-22 0:39 ` Alexander Duyck
2020-02-24 10:22 ` David Hildenbrand
2020-02-25 0:13 ` Alexander Duyck
2020-02-25 8:09 ` David Hildenbrand
2020-02-25 16:42 ` Alexander Duyck
2020-02-21 18:24 ` Yang Shi
2020-02-22 0:24 ` Alexander Duyck
2020-02-26 17:31 ` Yang Shi
2020-02-26 17:45 ` David Hildenbrand
2020-02-26 18:00 ` Yang Shi
2020-02-27 0:56 ` Hugh Dickins
2020-02-27 1:14 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ee0597-dc5f-6aaf-4651-f588cc62599c@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).