From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B588C43331 for ; Wed, 1 Apr 2020 18:55:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A596206F5 for ; Wed, 1 Apr 2020 18:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HSkwMdGj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A596206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCC6C8E0008; Wed, 1 Apr 2020 14:55:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA4608E0006; Wed, 1 Apr 2020 14:55:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB9AF8E0008; Wed, 1 Apr 2020 14:55:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id AF91A8E0006 for ; Wed, 1 Apr 2020 14:55:36 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 66829824805A for ; Wed, 1 Apr 2020 18:55:36 +0000 (UTC) X-FDA: 76660189872.01.ice35_30e8535a21f21 X-HE-Tag: ice35_30e8535a21f21 X-Filterd-Recvd-Size: 4841 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Apr 2020 18:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=g+zmGJ2+G9hNWUAMUsh52VSSKxFQTXVxsgcRUv3kCKw=; b=HSkwMdGjJTzeDKg6viAgg+vkYX GwWikN3woD12qqHVvV7ZHlDBuSnIT1YTLhhPxnYeVhU4Yz0w22ayIAzSGGNCEEH3ESWk2Of0bsMU/ dG0H9jo2k7LKZZep+4GqrDqfz7gda+n57tRazqwm0NtWpHChHNHExKMuQaHVOKIjVTNZsLgekVjVB ETytEzAil0LGP9C/6DiupNZY0kRjExHiViQlWPo3nNbK3R5aGeyag92MZI3KBpNK3UjeJxk/U9Ng8 RaPo+1ZWEAkLxis4FKl6f+lSrhmDY1a51cw8esCzD2Yt7ZzKeDLwwC0kkohK8jmUgrXJhRy6f60cJ K5QabcFg==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJiVz-0003u7-Lp; Wed, 01 Apr 2020 18:55:03 +0000 Subject: Re: [PATCH v2 4/4] hugetlbfs: clean up command line processing To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org Cc: Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-5-mike.kravetz@oracle.com> From: Randy Dunlap Message-ID: Date: Wed, 1 Apr 2020 11:55:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-5-mike.kravetz@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/1/20 11:38 AM, Mike Kravetz wrote: > With all hugetlb page processing done in a single file clean up code. > - Make code match desired semantics > - Update documentation with semantics > - Make all warnings and errors messages start with 'HugeTLB:'. > - Consistently name command line parsing routines. > - Check for hugepages_supported() before processing parameters. > - Add comments to code > - Describe some of the subtle interactions > - Describe semantics of command line arguments > > Signed-off-by: Mike Kravetz > --- Hi Mike, One nit, please see below: > .../admin-guide/kernel-parameters.txt | 35 ++++--- > Documentation/admin-guide/mm/hugetlbpage.rst | 44 +++++++++ > mm/hugetlb.c | 96 +++++++++++++++---- > 3 files changed, 142 insertions(+), 33 deletions(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 1bd5454b5e5f..de653cfe1726 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -832,12 +832,15 @@ > See also Documentation/networking/decnet.txt. > > default_hugepagesz= > - [same as hugepagesz=] The size of the default > - HugeTLB page size. This is the size represented by > - the legacy /proc/ hugepages APIs, used for SHM, and > - default size when mounting hugetlbfs filesystems. > - Defaults to the default architecture's huge page size > - if not specified. > + [HW] The size of the default HugeTLB page size. This Drop one "size" above? > + is the size represented by the legacy /proc/ hugepages > + APIs. In addition, this is the default hugetlb size > + used for shmget(), mmap() and mounting hugetlbfs > + filesystems. If not specified, defaults to the > + architecture's default huge page size. Huge page > + sizes are architecture dependent. See also > + Documentation/admin-guide/mm/hugetlbpage.rst. > + Format: size[KMG] -- ~Randy