From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49385C433DB for ; Tue, 23 Mar 2021 06:33:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7694619B4 for ; Tue, 23 Mar 2021 06:33:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7694619B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE72B6B0102; Tue, 23 Mar 2021 02:33:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBE196B0105; Tue, 23 Mar 2021 02:33:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CACDA6B0107; Tue, 23 Mar 2021 02:33:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id B1D766B0102 for ; Tue, 23 Mar 2021 02:33:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 721911804EE3A for ; Tue, 23 Mar 2021 06:33:23 +0000 (UTC) X-FDA: 77950172286.05.DB2624B Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf02.hostedemail.com (Postfix) with ESMTP id 39A9A40001DE for ; Tue, 23 Mar 2021 06:33:21 +0000 (UTC) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F4M1z2lVvzNqTS; Tue, 23 Mar 2021 14:30:47 +0800 (CST) Received: from [10.174.178.163] (10.174.178.163) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Tue, 23 Mar 2021 14:33:14 +0800 Subject: Re: [PATCH] mm: process_vm_access: Remove duplicate include of compat.h To: Wan Jiabing , Andrew Morton CC: , , References: <20210323032322.262579-1-wanjiabing@vivo.com> From: Miaohe Lin Message-ID: Date: Tue, 23 Mar 2021 14:33:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210323032322.262579-1-wanjiabing@vivo.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.163] X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39A9A40001DE X-Stat-Signature: hm7srdm1bi3qbwpfqioszfiymnt8k5a5 Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=szxga05-in.huawei.com; client-ip=45.249.212.191 X-HE-DKIM-Result: none/none X-HE-Tag: 1616481201-91576 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000729, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/3/23 11:23, Wan Jiabing wrote: > linux/compat.h has been included at line 8.So we remove > the duplicate one at line 12. > line 12 one is added via eb351d75ce1e ("mm/process_vm_access.c: include compat.h") to fix the build error: mm/process_vm_access.c:277:5: error: implicit declaration of function 'in_compat_syscall'; did you mean 'in_ia32_syscall'? [-Werror=implicit-function-declaration] There might be something wrong. > Signed-off-by: Wan Jiabing > --- > mm/process_vm_access.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c > index f5fee9cf90f8..4bcc11958089 100644 > --- a/mm/process_vm_access.c > +++ b/mm/process_vm_access.c > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > #include > #include > #include >