From: David Hildenbrand <david@redhat.com>
To: Naoya Horiguchi <naoya.horiguchi@linux.dev>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Yang Shi <shy828301@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Muchun Song <songmuchun@bytedance.com>,
Jane Chu <jane.chu@oracle.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter counter
Date: Mon, 26 Sep 2022 10:05:05 +0200 [thread overview]
Message-ID: <a99f0684-b075-7fc5-082a-2c0cc706574b@redhat.com> (raw)
In-Reply-To: <20220923141204.GA1484969@ik1-406-35019.vs.sakura.ne.jp>
> /*
> @@ -2414,6 +2417,10 @@ int unpoison_memory(unsigned long pfn)
> unlock_mutex:
> mutex_unlock(&mf_mutex);
> if (!ret || freeit) {
> + /*
> + * TODO: per-memory_block counter might break when the page
> + * size to be unpoisoned is larger than a memory_block.
> + */
Hmm, but that happens easily e.g., with 1 GiB hugetlb page and 128 MiB
memory section/block size. What would be the right thing to do here? The
TODO should rather spell that out instead of just stating the problem.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-26 8:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:13 [PATCH v3 0/4] mm, hwpoison: improve handling workload related to hugetlb and memory_hotplug Naoya Horiguchi
2022-09-21 9:13 ` [PATCH v3 1/4] mm,hwpoison,hugetlb,memory_hotplug: hotremove memory section with hwpoisoned hugepage Naoya Horiguchi
2022-09-24 11:43 ` Miaohe Lin
2022-09-28 1:26 ` Naoya Horiguchi
2022-09-28 9:32 ` Miaohe Lin
2022-10-07 0:45 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-08 2:33 ` Miaohe Lin
2022-09-21 9:13 ` [PATCH v3 2/4] mm/hwpoison: move definitions of num_poisoned_pages_* to memory-failure.c Naoya Horiguchi
2022-09-24 11:53 ` Miaohe Lin
2022-09-28 2:05 ` Naoya Horiguchi
2022-09-28 7:56 ` Miaohe Lin
2022-09-21 9:13 ` [PATCH v3 3/4] mm/hwpoison: pass pfn to num_poisoned_pages_*() Naoya Horiguchi
2022-09-21 9:13 ` [PATCH v3 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter Naoya Horiguchi
2022-09-23 8:26 ` [PATCH v4 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter counter Naoya Horiguchi
2022-09-23 14:12 ` [PATCH v5 " Naoya Horiguchi
2022-09-24 12:27 ` Miaohe Lin
2022-10-07 0:47 ` HORIGUCHI NAOYA(堀口 直也)
2022-09-26 8:05 ` David Hildenbrand [this message]
2022-10-07 0:52 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99f0684-b075-7fc5-082a-2c0cc706574b@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jane.chu@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).