From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E780C76191 for ; Thu, 25 Jul 2019 10:15:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 221912173E for ; Thu, 25 Jul 2019 10:15:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 221912173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC3DB8E0064; Thu, 25 Jul 2019 06:15:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4DDF8E0059; Thu, 25 Jul 2019 06:15:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17C58E0064; Thu, 25 Jul 2019 06:15:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by kanga.kvack.org (Postfix) with ESMTP id 7B7528E0059 for ; Thu, 25 Jul 2019 06:15:28 -0400 (EDT) Received: by mail-qt1-f197.google.com with SMTP id m25so43958050qtn.18 for ; Thu, 25 Jul 2019 03:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MYph+B4VbzLyXAelEHxgcdgrVqf769vIHx4OcqBIquI=; b=Vvmwi0ebERUTELp9EJk8JH8ZMUxOdD2vqICDppHaORkZM28O5tVfcdlMoPJIhY/ST7 +Wpcs2FK6nuFHLqK1PzwWhEWzTvxhopptFRaQpe+rpw7a+2AsnJIhMDSSj7SSDUq0QOh 6ZV0ZJGp//kVSqeKPahTiAH8cINm8XBuPc3QWXdbrSX4My9VueUzHnDgI7imQM3UnFH6 IYzvJrgULg3izS646AT+sXGFfZDUyJKvWTXIQI5vrgDsL10ejp199Zk8Mmco0UTDXBJ7 6z80/y5xcQkjOVA8hRokw65esiV/zZNT7eqHSs+orG4j3eARi4U+96wOJ0nZAHcLjc1i VRhw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAUz7J4MjhNl1M+NWPh+lzDpyHAB/rDQotpgN9t28fRLYjGp013d 9tw+z0GjPP8zkqf0r015B2bi26BJ77YNYX8JeIH4eQXzDl80j+HijjSssaDXAzqWJiRfzED18AN AFF2o2ALV25rBMIHdqRe6jfjv7z/GNowYJ2aD0pULx3gGf6BUdMYXzvrRF3BnDqthfA== X-Received: by 2002:a37:b0c6:: with SMTP id z189mr57730448qke.208.1564049728299; Thu, 25 Jul 2019 03:15:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUv+EawpTbrwuS0dZ91Rg1UfxSOslB/UOhvVr0P5St39egm2cLYBqHbwMi5b2NSFozFxfF X-Received: by 2002:a37:b0c6:: with SMTP id z189mr57730421qke.208.1564049727837; Thu, 25 Jul 2019 03:15:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564049727; cv=none; d=google.com; s=arc-20160816; b=LPt7dYNk3vPsEgrSSoYf6RDINr+CEHxNZQJbY36K1q98OaQKh1eYHXbL+KgfXf75vX eJS3D02hp53Ef50rPJrQBZRrqaseBD5Ra5nITES5l/kDlTwYrTRz09Ogt7ops2CMDH3C HqpyLPTHWl6ws5FwNEfoA7l5hjsYIsqVjcm9rrBilnt9Voeaj4cfXeY0gXoHToa37Z73 gLHs9ff6JC5PfKZ4pDcs8fhYXauOi9pc071yRhasjHmNGOz9OyOEJh5ua7HgULXM5SNa T6yuCrDl1ooaLLXNRuUJIwWvV27HkEMa17OaFeAJjJR2XAOSWDXVZMlELuYSXB/tjQSv DXVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=MYph+B4VbzLyXAelEHxgcdgrVqf769vIHx4OcqBIquI=; b=OyDytyDzLKc4/MoZXw8jvomwMlEjFLgZpdBrfiR0I+7IECHTZQ9VpdD9D6D/HZgO8A XpIcKCcVOmwnfYQQXvT09tYPM0Jpgq1m78gYlRSOLvgENICCOzBXWlu3IHI6oMOtKdOL l9tdDgxSIAFAz6uj2MTAE8PGN0jE6E96Gig9BKJUE5zOB883ov7UHE5dDO/lVOskBHhn 4f+FvzuG29W1EMQIajF/rmwIZ0m3+Fh37bdQ6S1GXKRPmxJHm3e+4RqEoMpBX4dAkrcJ jkUcCMHDrkpdWz0Dz5smYcVHUbUkdnXmg+TRRUw/lh1xpD3G8cpjknWIlQx4w0/vti3S lcDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id w69si31364617qkb.209.2019.07.25.03.15.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 03:15:27 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C051285546; Thu, 25 Jul 2019 10:15:26 +0000 (UTC) Received: from [10.36.117.212] (ovpn-117-212.ams2.redhat.com [10.36.117.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D64619C68; Thu, 25 Jul 2019 10:15:24 +0000 (UTC) Subject: Re: [PATCH v2 2/5] mm,memory_hotplug: Introduce MHP_VMEMMAP_FLAGS To: Oscar Salvador Cc: Dan Williams , Andrew Morton , Michal Hocko , Pavel Tatashin , Jonathan Cameron , Anshuman Khandual , Vlastimil Babka , Linux MM , Linux Kernel Mailing List References: <20190625075227.15193-1-osalvador@suse.de> <20190625075227.15193-3-osalvador@suse.de> <20190725092751.GA15964@linux> <71a30086-b093-48a4-389f-7e407898718f@redhat.com> <20190725094030.GA16069@linux> <6410dd7d-bc9c-1ca2-6cb7-d51b059be388@redhat.com> <20190725101322.GA16385@linux> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Thu, 25 Jul 2019 12:15:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190725101322.GA16385@linux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 25 Jul 2019 10:15:27 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.07.19 12:13, Oscar Salvador wrote: > On Thu, Jul 25, 2019 at 12:04:08PM +0200, David Hildenbrand wrote: >> As I said somewhere already (as far as I recall), one mode would be >> sufficient. If you want per memblock, add the memory in memblock >> granularity. >> >> So having a MHP_MEMMAP_ON_MEMORY that allocates it in one chunk would be >> sufficient for the current use cases (DIMMs, Hyper-V). >> >> MHP_MEMMAP_ON_MEMORY: Allocate the memmap for the added memory in one >> chunk from the beginning of the added memory. This piece of memory will >> be accessed and used even before the memory is onlined. > > This is what I had in my early versions of the patchset, but I do remember > that Michal suggested to let the caller specify if it wants the memmaps > to be allocated per memblock, or per whole-range. > > I still think it makes somse sense, you can just pass a large chunk > (spanning multiple memory-blocks) at once and yet specify to allocate > it per memory-blocks. > > Of course, I also agree that having only one mode would ease things > (not that much as v3 does not suppose that difference wrt. range vs > memory-block). I prefer simplicity. No user, no implementation. We can easily add this later on if there is a good reason/user. -- Thanks, David / dhildenb