From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E01C4332F for ; Tue, 15 Feb 2022 08:32:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BB296B007B; Tue, 15 Feb 2022 03:32:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36B3E6B007D; Tue, 15 Feb 2022 03:32:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25BF56B007E; Tue, 15 Feb 2022 03:32:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 17CED6B007B for ; Tue, 15 Feb 2022 03:32:49 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C3C7F8249980 for ; Tue, 15 Feb 2022 08:32:48 +0000 (UTC) X-FDA: 79144348416.11.246AF9B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id 3BC2AA0003 for ; Tue, 15 Feb 2022 08:32:48 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JyZ712cxKz9shW; Tue, 15 Feb 2022 16:31:09 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 16:32:45 +0800 Subject: Re: [PATCH 03/10] mm/truncate: Convert invalidate_inode_page() to use a folio To: "Matthew Wilcox (Oracle)" , , References: <20220214200017.3150590-1-willy@infradead.org> <20220214200017.3150590-4-willy@infradead.org> From: Miaohe Lin Message-ID: Date: Tue, 15 Feb 2022 16:32:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220214200017.3150590-4-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3BC2AA0003 X-Stat-Signature: ymqmqz1akfnmpdh1u1xd7ornyrqx337z Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1644913968-254430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/15 4:00, Matthew Wilcox (Oracle) wrote: > This saves a number of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- LGTM. Thanks. Reviewed-by: Miaohe Lin > mm/truncate.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index e5e2edaa0b76..b73c30c95cd0 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -281,14 +281,15 @@ EXPORT_SYMBOL(generic_error_remove_page); > */ > int invalidate_inode_page(struct page *page) > { > - struct address_space *mapping = page_mapping(page); > + struct folio *folio = page_folio(page); > + struct address_space *mapping = folio_mapping(folio); > if (!mapping) > return 0; > - if (PageDirty(page) || PageWriteback(page)) > + if (folio_test_dirty(folio) || folio_test_writeback(folio)) > return 0; > if (page_mapped(page)) > return 0; > - if (page_has_private(page) && !try_to_release_page(page, 0)) > + if (folio_has_private(folio) && !filemap_release_folio(folio, 0)) > return 0; > > return remove_mapping(mapping, page); >