From: "Xu, Yanfei" <yanfei.xu@windriver.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: remove duplicate codes of setting compound_nr
Date: Wed, 3 Feb 2021 13:24:36 +0800 [thread overview]
Message-ID: <ac1da539-a7c6-610b-b1bf-c36989dd2603@windriver.com> (raw)
In-Reply-To: <20210203044055.89618-1-yanfei.xu@windriver.com>
Sorry. Please ignore this patch, it's incorrect.
Thanks,
Yanfei
On 2/3/21 12:40 PM, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
>
> set_compound_order() set both of page's compound_order and
> compound_nr. It's no need to assign to compound_nr again, so
> remove it.
>
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
> ---
> mm/hugetlb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index a3e4fa2c5e94..ac249b1583de 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1228,7 +1228,6 @@ static void destroy_compound_gigantic_page(struct page *page,
> }
>
> set_compound_order(page, 0);
> - page[1].compound_nr = 0;
> __ClearPageHead(page);
> }
>
>
prev parent reply other threads:[~2021-02-03 5:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 4:40 [PATCH] mm/hugetlb: remove duplicate codes of setting compound_nr yanfei.xu
2021-02-03 5:24 ` Mike Kravetz
2021-02-03 5:24 ` Xu, Yanfei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac1da539-a7c6-610b-b1bf-c36989dd2603@windriver.com \
--to=yanfei.xu@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).