From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F549C10DCE for ; Wed, 18 Mar 2020 04:27:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2999A20768 for ; Wed, 18 Mar 2020 04:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jkHBtYzv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2999A20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86AEE6B0003; Wed, 18 Mar 2020 00:27:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81C2E6B0006; Wed, 18 Mar 2020 00:27:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 758436B0007; Wed, 18 Mar 2020 00:27:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 5CB496B0003 for ; Wed, 18 Mar 2020 00:27:02 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 87968180AD81F for ; Wed, 18 Mar 2020 04:27:02 +0000 (UTC) X-FDA: 76607197884.26.leaf13_5a8adc0fa7f55 X-HE-Tag: leaf13_5a8adc0fa7f55 X-Filterd-Recvd-Size: 4058 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Mar 2020 04:27:02 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id b22so6951324pgb.6 for ; Tue, 17 Mar 2020 21:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5hQqpSvt4tC1ihG/h6rOXKsZco8EGDS57uVaABs5Le8=; b=jkHBtYzvhoglTRpv8FIvWUG1DiqqLYXPKxhZV2s2u/ECys5cNUub5EMaQiEN0fSxyZ 6ZWxl+i2i9+jvb26DEbLyueO+Oz7femIGgayHCiqm+TL7MuREo9NyKVHuvfjjrIBW1yV zd2mi+gdahuqchxUqDeAqiiIFzfudI3QqtKTSep2DThD4cu5aii4SOt6ycbS8KvhRqSj aAL+KkEkNqUXB2a/hxVpBZaw0tmDPAD3yuc0VDjV1gqzBHcljWEHYSNfVduv8/FUkzsj 9uY0PxmdVqk3GsnUdthJfLSDwzCpf6QLGIG1HXkA1v1loK5ety8WUcvzosjvPuW5lG8N Jm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5hQqpSvt4tC1ihG/h6rOXKsZco8EGDS57uVaABs5Le8=; b=hozOfLAAO20IbIQ1SWMejETlUh3SsHjstdoxyu+5h7KaaoaT+m2MDZYM7NjyFPaveX Zv6XZif2ifpEL9k/PUUQEaKGlwmfkn6hF7MpHTnF7mKjaJDo+lI9IXJTk4MaTwNXhjn4 QuIfGSJjFGgJN1ZvKg5UuLmLie4Xw8Bl/WsJlNms091HmQERg35kE9yn+AKnhbrm3CmR cBKMJnXKUmb/tAAZx0/5AaHkONFSqfUskAcjTsQ071yB5j4ntZ1hMLFz3QpFQLLxsYaS ubESgiO1KDuIPkhju2xGVBxgES4Q9ZTUs3CAtZWY1ZB9J4jXaZ4lfALHmeHagPyrzT0k WW2w== X-Gm-Message-State: ANhLgQ3AI9FA7d7oesjcjQ+G0nc2gDv/+y83Tuhz0Lkcr4zynPEQUPIe ffA3vch+AfMK4ekpcCcVCvYzrOIb X-Google-Smtp-Source: ADFU+vuEqeBjNJTai5hfGuGalMaXMFOYwL2YIKQ432GnBQqykUaK8C7+PoU2vhjSjm3AY9Npbkd6Ww== X-Received: by 2002:a63:7e49:: with SMTP id o9mr2776478pgn.80.1584505620617; Tue, 17 Mar 2020 21:27:00 -0700 (PDT) Received: from [10.80.50.61] ([203.205.141.39]) by smtp.gmail.com with ESMTPSA id h4sm4400087pfo.87.2020.03.17.21.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2020 21:27:00 -0700 (PDT) Subject: Re: [PATCH] mm: Fix a comment typo To: James Bottomley , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <0783042a-244c-0c2e-091d-e7002718d73f@gmail.com> <1584503945.15565.23.camel@HansenPartnership.com> From: brookxu Message-ID: Date: Wed, 18 Mar 2020 12:26:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1584503945.15565.23.camel@HansenPartnership.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thank you very much for your reply, it should be my misunderstanding, thanks again~ James Bottomley wrote on 2020/3/18 11:59: > On Wed, 2020-03-18 at 11:42 +0800, brookxu wrote: >> Signed-off-by: Chunguang Xu >> >> --- >> mm/page-writeback.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/page-writeback.c b/mm/page-writeback.c >> index 2caf780..2acf754 100644 >> --- a/mm/page-writeback.c >> +++ b/mm/page-writeback.c >> @@ -1271,7 +1271,7 @@ static void wb_update_dirty_ratelimit(struct >> dirty_throttle_control *dtc, >> */ >> >> /* >> - * dirty_ratelimit will follow balanced_dirty_ratelimit iff >> + * dirty_ratelimit will follow balanced_dirty_ratelimit if > Are you sure it's a mistake? iff means if and only if which would be > reasonable unless the condition is only implies. > > James >