From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFDDC05027 for ; Thu, 26 Jan 2023 08:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46356B0071; Thu, 26 Jan 2023 03:46:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF7126B0072; Thu, 26 Jan 2023 03:46:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9701D6B0073; Thu, 26 Jan 2023 03:46:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 85DC96B0071 for ; Thu, 26 Jan 2023 03:46:28 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 53DC2AAF4A for ; Thu, 26 Jan 2023 08:46:28 +0000 (UTC) X-FDA: 80396318856.13.A62B36E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 30D47180016 for ; Thu, 26 Jan 2023 08:46:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fFTZAUpR; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674722786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2UJoQG8XqIV2gdZ5V2M7MUTXNJ4+fqx8kSeoZEHtCyE=; b=fNvE1f6TVFbC7pSeWs6wi6h4nlVz3FtiIt5qMko/kjH8dwyReoEKfDQVbxqVbFWKc5zQRr UQFwyCNgNCCtjiit5/ZnRG6X5Pf1G8sbsdmzkbap1ayygmmkmhKaBLUYbgrJv2CTVeUk2K 4TIZ3jdsO627N3gykgh5B6lT7YQPXUg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fFTZAUpR; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674722786; a=rsa-sha256; cv=none; b=2FKTzFXkWzGnUMlaMsThhqpu8d24TNbT8fb+x53r8evbEIGVmHyDC9M2hPjue2ZnsBucDe u325xm6b8t+z1hh8QHIDgUcpF8dizsYP2hLSG4BInPDKlrx5x8HmXd1qJtxRhsdEK5H9Jk hzawC0lhbR5GiLlCS/1aAa0z7QXGgqU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674722785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2UJoQG8XqIV2gdZ5V2M7MUTXNJ4+fqx8kSeoZEHtCyE=; b=fFTZAUpR5q28s7Uet941qdLepkTtb2t0It4YuTuZFi4jN2RIA9spWt79z4IwysMLl+Ky2K wkpOmkwPAwyj9pHYdsafRSPE3DG6EBDksSdXArmfx6Fp7LVS6kif4WUZYZ+KHTRq5aQ4ys Pnm58OjAIF4UBQeQ35lRhxSguv0EM/0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-574-5yXlhRL5Memhg7_Stv3_0A-1; Thu, 26 Jan 2023 03:46:23 -0500 X-MC-Unique: 5yXlhRL5Memhg7_Stv3_0A-1 Received: by mail-wm1-f69.google.com with SMTP id j8-20020a05600c190800b003db2dc83dafso704239wmq.7 for ; Thu, 26 Jan 2023 00:46:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2UJoQG8XqIV2gdZ5V2M7MUTXNJ4+fqx8kSeoZEHtCyE=; b=MuxTKb/lapVvvrSFCLNlRzD3cUaj71nZlTxCntDYUP4amVgguyWfh5RtViGUo/tVIT KiaIBQ9r2nxIbg1w11AYhWlDlh/7qq54Yn8dX5gfT9nxL69pCCUmycRAotRr00PDd0iY j1y4GQVn/fv9Nqos6U4+SxB4RNuQMUbdvtuuoZpyRSqb5sDJydJaKdPaSl2EOlIFg1C8 sykqaINg9xr7LTzQl6RVK5KE2Kxjt04TUNzJpRrce9O8Hu30kDgeD99/cAAlkdSm7os4 xUaAZyO4gaTM3IaiD97iwRcnuJSwGNZtJOWXQ3BGREd2bWc0GSQdTLVa3Rfxob9fXxOl QLfQ== X-Gm-Message-State: AFqh2krmsI4si3uKJghDOOBjl8nTQghzn1h3bSGXwINJqRTYImIxJKdP o4iZ88m1G0A+/XY40u2whgh/5graJcdrXgfREStMyhqZh4iZEtGVtzH+Z3zhqJwe0rBVvUI7rxp SlY5u+msSU2E= X-Received: by 2002:a05:600c:714:b0:3d9:ed30:79d with SMTP id i20-20020a05600c071400b003d9ed30079dmr34687560wmn.18.1674722781974; Thu, 26 Jan 2023 00:46:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXtafnDCs+MxdtjVDkOlNHLIvv1Gu+xFfV8rFc8O/8mrsHf9iNdy6mNIXFzLYO+oSkffev3lmA== X-Received: by 2002:a05:600c:714:b0:3d9:ed30:79d with SMTP id i20-20020a05600c071400b003d9ed30079dmr34687520wmn.18.1674722781631; Thu, 26 Jan 2023 00:46:21 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id p20-20020a05600c2e9400b003d9862ec435sm824806wmn.20.2023.01.26.00.46.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 00:46:21 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 09:46:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v5 18/39] mm: Handle faultless write upgrades for shstk To: "Edgecombe, Rick P" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Eranian, Stephane" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "akpm@linux-foundation.org" , "Yang, Weijiang" , "Lutomirski, Andy" , "arnd@arndb.de" , "jamorris@linux.microsoft.com" , "linux-doc@vger.kernel.org" , "bp@alien8.de" , "Schimpe, Christina" , "x86@kernel.org" , "mike.kravetz@oracle.com" , "tglx@linutronix.de" , "andrew.cooper3@citrix.com" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Cc: "Yu, Yu-cheng" References: <20230119212317.8324-1-rick.p.edgecombe@intel.com> <20230119212317.8324-19-rick.p.edgecombe@intel.com> <7f63d13d-7940-afb6-8b25-26fdf3804e00@redhat.com> <50cf64932507ba60639eca28692e7df285bcc0a7.camel@intel.com> <1327c608-1473-af4f-d962-c24f04f3952c@redhat.com> <8c3820ae1448de4baffe7c476b4b5d9ba0a309ff.camel@intel.com> <4d224020-f26f-60a4-c7ab-721a024c7a6d@redhat.com> <899d8f3baaf45b896cf335dec2143cd0969a2d8a.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <899d8f3baaf45b896cf335dec2143cd0969a2d8a.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 30D47180016 X-Stat-Signature: pnefnpkfbc4a8dwesif13zbt8qfu3533 X-HE-Tag: 1674722786-682730 X-HE-Meta: U2FsdGVkX1/Y0vFWpcQEUoddwqwDCjNKwtyJkvS6bHvHK9p/qtHXFRY2ch1vb+xRnDHaTc4mr1LXYNQSioIphE4JGIPFDEw1sVwOPzhg4xE3b6LT38z60Kg1O2A1Hb71HZ/zoB9lnE23YasoShawJpiVGMG3MmbKO7VKcUNA9z4m42/khMd3BRhg/S8lFyji/ZINpxG1OQ6RSO27xyKpjKhO2JR7A7u0ar7eSQane0TQipJE+unUhTd19UQWZ7hiz0WigEwXl2DHxgasuT5mZKp7fJC8o/m9WJM/Vi5ng+yACJ4AM7EFTT3JUhhYkpJ4L91ui8m/29M3D6OXeoW06k/bqEAIEtpb/fVmzrIFNCCGq9dQSyXxXeYwJt3yW2527OioGJBE3XY8/7/CwnszziThGAlKEdRvAnbzfMHb+TvZWpsl5zDK8wmrDlbk67jjfOp1wsh3+m0gVEtfhQfhQHFyUaFxjRSh/PddnNtg+Wtazxax4vxBLcG2cnLvfiYY/ZA6eutx3W2Hrtc3Wp1p9S5G6IdtDYix7zJNzxwtHBxy2InKR5HrsoGk7dq1DOJ7hca268W5K48qF1UNzIJMboUo5+c77I60yVMqoDbjJjh84moV7ivhf4C0f98Pv5AzAUfefZfgku+mBLcjtJTHDHHHZLKReliNXfJLi4Mkei4GWPVDiM1bIBuDz5qAAP2PLTJxAOOj4z5yvolXOX7SulC/ekZHfD63/AjzGriXcirL4LuNeaZeosl2kenXg5tC/cJyXDUNLlkWn4ZRWUUxcbI71EhUuUUJ7PsJKM35c0vLu2KRaewuZNl+wuOTLXHdQwcajf4BYcKlUxpq7SEXGBF5Oiw8YpYpr+QxKr1vcWBmQ7us5aIs8Kvp8VnRrEcwW5dCslyQOzNRyxRIzZIESaO9MSD1ymTFGd3NrtLkJobEWGu5naEy1r3NF2cC/aUvT906PlcMHH1IPkDx+ar 17RZq4sm lXiOED4L4PV3dAy014qYHN0vpn3ff4CqBZ5k5XdUaHCEicFhsTwYlQbLn+/b9QQaP2WvUEy0XCKAikWMgKrjqydTK7HWJyHwXSBERmgugMS7YrsYIwBMtGgvgN+C3C5hHQmOfmKvPCEAbhsDI6rNsGhcSd+WxBvmhlfiMWwH/U7r6GUzzhT9R+qyuL0ZYZ8zHXQ/WxsWSTzTNKVbVjbvt358w4zUWj0BhWuc2+X1lCBWtzsFj3Fq6p3IqyX6QQHUTF/097614tx2pYML7CpQqwnjcw+1ptZeiiH/HSf91TAAfj05FbGrseBFHv59VWMUl4fU9gvXsYBKy+qC8hC1pHkqkV4KXJJz/ZGmdp99SeIqjnC4VmdUNq7JFEKmZvg+Kir2UooqXtaSCZHVdQGMQSMyM0+vlEZLEl37ZzNTfnVbraBxucqsPq0PyWH13oh1RC7Dr5b0ckxna9ay56SsKPqgWzNBxu1UEA0sQNTpO4RWOo3jh4Y0BeD8LErKNb4v7Sar5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.01.23 01:59, Edgecombe, Rick P wrote: > On Wed, 2023-01-25 at 10:43 -0800, Rick Edgecombe wrote: >> Thanks for your comments and ideas here, I'll give the: >> pte_t pte_mkwrite(struct vm_area_struct *vma, pte_t pte) >> ...solution a try. > > Well, it turns out there are some pte_mkwrite() callers in other arch's > that operate on kernel memory and don't have a VMA. So it needed a new Why not pass in NULL as VMA then and document the semantics? The less similarly named but slightly different functions, the better :) -- Thanks, David / dhildenb