From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C76C6FD1F for ; Sun, 19 Mar 2023 07:23:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 126A1900003; Sun, 19 Mar 2023 03:23:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D79C900002; Sun, 19 Mar 2023 03:23:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2EE2900003; Sun, 19 Mar 2023 03:23:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E9D00900002 for ; Sun, 19 Mar 2023 03:23:01 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9892C0263 for ; Sun, 19 Mar 2023 07:23:01 +0000 (UTC) X-FDA: 80584806162.09.611A378 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf07.hostedemail.com (Postfix) with ESMTP id 5E62A4000E for ; Sun, 19 Mar 2023 07:22:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of chenjun102@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=chenjun102@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679210579; a=rsa-sha256; cv=none; b=Er3uMe17UrbwwVF/m8XN1P3eWtoROXiQLfVTdkQHYhXujc1MhVoz7KmgzTDTsmHi1m0jkj HPJTLA8SxrrRWcq7sWbSrqKze8dLjMoOt+vhBDVWwuh1vCXkeoUmgR6/TOz+MpEXdLWrD+ HJxBrfUMC5qlzMTnKvpuIbUkoj+KhB0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of chenjun102@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=chenjun102@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679210579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:references; bh=GSK/eKhszd2t1usNa4gnNbkO0DX3d7NEXSdwog9eafw=; b=Wgv13u7gE2qID0OR8CUlAHpE9RUFFXSOSwDL5hoc2FxwK/NoYvgcSoDB5gmyTcJGkiJnzn ZlP4qU6A1c2l+zXN6ftB52JvGQE3dNj7cDUV94lJgZIwH8ZZyDb3SOiiq1ScF/Sa8OjXeT kPkC+EoZVS/Z+fXZiONgOh3lKHjDBXY= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PfTpc39qjz9tTN; Sun, 19 Mar 2023 15:22:32 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 19 Mar 2023 15:22:50 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.021; Sun, 19 Mar 2023 15:22:50 +0800 From: "chenjun (AM)" To: Vlastimil Babka , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" , Hyeonggon Yoo <42.hyeyoo@gmail.com> CC: "xuqiang (M)" , "Wangkefeng (OS Kernel Lab)" Subject: Re: [PATCH] mm/slub: Reduce memory consumption in extreme scenarios Thread-Topic: [PATCH] mm/slub: Reduce memory consumption in extreme scenarios Thread-Index: AQHZVnGyqCLx+d0GeECeM+z9zE2Dsg== Date: Sun, 19 Mar 2023 07:22:50 +0000 Message-ID: References: <20230314123403.100158-1-chenjun102@huawei.com> <0cad1ff3-8339-a3eb-fc36-c8bda1392451@suse.cz> <344c7521d72e4107b451c19b329e9864@huawei.com> <8c700468-245d-72e9-99e7-b99d4547e6d8@suse.cz> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.178.43] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 5E62A4000E X-Rspamd-Server: rspam01 X-Stat-Signature: ksqyxs7atsce8sgfyrtzg8eneid9md8u X-HE-Tag: 1679210577-186739 X-HE-Meta: U2FsdGVkX19/yPPCEwp+FaZEj2GjWXXs97FwoyJLx1Cn1OeLZqjLlWn1vEWYaQHQbTTXh+mwmChtBxrBlSZwvCStRZ8/wIDuyPShKqkNZXk+wqZBmLeUK2jp8O1TFsiJiU3qX+/cCgdR18VCAfWElg+7BG96Iv3f5rSymfPYTd0Um80+mccr0grkOLs8oxk0x3d2GyQyD1Qrn1oDRIP/O7bWZMlqf9w6/WdXd5/6tDuPdP7L+oKtDqaJq+dlaIztOoj+bsS75UA+4oYs9DtNu7LI7ukAHmewKk3kZJ6ZGVmfkIlz4BDmKEI/R5i1HaR3QUzO+TcgtXQOVPq/JIkP8TsHTDM1vdSSttbo6m3Zha383XjBstzv0aLkvOazWNwhQ39sCWoPar3bVms4M7Zit01nb9jik3D0+zCPvJ77tEjhgAnSYhl1NHdxKif6gd8nlAZI7j9Cx/27a5jGMohWzVN4Wlh9LWoFnQO7Ho5oD5Y1t2HcTCUyIalXh+zkWRUsbGzKNrLFTJt0ch4YWetG4q0tWzF4PZ8MgAhW04l+Rb+n+pL6sa9BCdT5IDr2GTfqU45fWBOGtjgDyMX+5ypCZ4jkvRLAkUOdKhIudNn6bvfBILrMJO2RVrl9DMCfrHD2ll/zGT2c78VzHS4xEPBxrZglv0yvJ5+NSD/VojK7WXnNtJpiCEl4v0RndEihOeQjI8rFeQmgkTd3+8M0xlBPt8bgBUdhgKV4jz6pc7gMix5aVmzWEzDjOR2QS5XBFj4JlFOgYU/S4CwL6kJ0T2l3d/c3drQ/V4F1sl1M+nXd+xv/n/x3OOE+K653vMHxDk3lCN4RgzgLnhSHG3rlMmtMoGncbb6rZ95mTcipWfCuaar3yW8oD/XURo5YWJOI2XkcCyFBmjXCiXktWeURaRpRteGQRRJb6ymvr2hWhmadl/Izm2OR7fJJa5InbYiyeKtgiM5b7MsxIxQac1SXvgw f7S1ko0y OjGOU4cke+UyuHMg08XJwbDQjMLLVenP0XWoSpujvrBgKEF26GiNIjefIbx5F1BisgfifDIpCTdRKP7p3O4eIBdPUTu/1KZvloKzo39lDQgkC0kpc5Bkfcxbj8dZVQM1mm1DBpiD8K6uheApbATQIZ7igEid/rSOL8iB7naObq1VmABHtM4CSRNhs8LFdNX0l+Yt66dIRKSA9BszqwiUzKkbthBsz63uTnJtVn5PhtwlBhrczu+IZkEqV6UAKwF1yD108Knoj0y5a+TI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =1B$B:_=1B(B 2023/3/17 20:06, Vlastimil Babka =1B$B On 3/17/23 12:32, chenjun (AM) wrote:=0A= >> =1B$B:_=1B(B 2023/3/14 22:41, Vlastimil Babka =1B$B>>> pc.flags =3D gfpflags;=0A= >>>> +=0A= >>>> + /*=0A= >>>> + * when (node !=3D NUMA_NO_NODE) && (gfpflags & __GFP_THISNODE)=0A= >>>> + * 1) try to get a partial slab from target node with __GFP_THISNODE= .=0A= >>>> + * 2) if 1) failed, try to allocate a new slab from target node with= =0A= >>>> + * __GFP_THISNODE.=0A= >>>> + * 3) if 2) failed, retry 1) and 2) without __GFP_THISNODE constrain= t.=0A= >>>> + */=0A= >>>> + if (node !=3D NUMA_NO_NODE && !(gfpflags & __GFP_THISNODE) && try_th= isnode)=0A= >>>> + pc.flags |=3D __GFP_THISNODE;=0A= >>>=0A= >>> Hmm I'm thinking we should also perhaps remove direct reclaim possibili= ties=0A= >>> from the attempt 2). In your qemu test it should make no difference, as= it=0A= >>> fills everything with kernel memory that is not reclaimable. But in pra= ctice=0A= >>> the target node might be filled with user memory, and I think it's bett= er to=0A= >>> quickly allocate on a different node than spend time in direct reclaim.= So=0A= >>> the following should work I think?=0A= >>>=0A= >>> pc.flags =3D GFP_NOWAIT | __GFP_NOWARN |__GFP_THISNODE=0A= >>>=0A= >>=0A= >> Hmm, Should it be that:=0A= >>=0A= >> pc.flags |=3D GFP_NOWAIT | __GFP_NOWARN |__GFP_THISNODE=0A= > =0A= > No, we need to ignore the other reclaim-related flags that the caller=0A= > passed, or it wouldn't work as intended.=0A= > The danger is that we ignore some flag that would be necessary to pass, b= ut=0A= > I don't think there's any?=0A= > =0A= > =0A= =0A= If we ignore __GFP_ZERO passed by kzalloc=1B$B!$=1B(B kzalloc will not work= .=0A= Could we just unmask __GFP_RECLAIMABLE | __GFP_RECLAIM?=0A= =0A= pc.flags &=3D ~(__GFP_RECLAIMABLE | __GFP_RECLAIM)=0A= pc.flags |=3D __GFP_THISNODE=0A=