From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5142C433EF for ; Tue, 25 Jan 2022 03:42:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29BCF6B0081; Mon, 24 Jan 2022 22:42:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23BB96B0083; Mon, 24 Jan 2022 22:42:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12B9E6B0085; Mon, 24 Jan 2022 22:42:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 00B676B0081 for ; Mon, 24 Jan 2022 22:42:02 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A7F4794FA0 for ; Tue, 25 Jan 2022 03:42:02 +0000 (UTC) X-FDA: 79067410884.30.F40FDF4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 392E540006 for ; Tue, 25 Jan 2022 03:42:01 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1A911FB; Mon, 24 Jan 2022 19:42:00 -0800 (PST) Received: from [10.163.42.113] (unknown [10.163.42.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 478853F766; Mon, 24 Jan 2022 19:41:57 -0800 (PST) Subject: Re: [RFC V1 08/31] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT To: Andreas Schwab Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org, Thomas Bogendoerfer , linux-m68k@lists.linux-m68k.org References: <1643029028-12710-1-git-send-email-anshuman.khandual@arm.com> <1643029028-12710-9-git-send-email-anshuman.khandual@arm.com> <87mtjl8bnl.fsf@igel.home> From: Anshuman Khandual Message-ID: Date: Tue, 25 Jan 2022 09:12:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87mtjl8bnl.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 392E540006 X-Stat-Signature: wxmt7itin85693yg3wuz4pw1g57358ym X-Rspam-User: nil Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-HE-Tag: 1643082121-358918 X-Bogosity: Ham, tests=bogofilter, spamicity=0.347608, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/22 7:43 PM, Andreas Schwab wrote: > On Jan 24 2022, Anshuman Khandual wrote: > >> +pgprot_t vm_get_page_prot(unsigned long vm_flags) >> +{ >> + switch (vm_flags & (VM_READ | VM_WRITE | VM_EXEC | VM_SHARED)) { >> + case VM_NONE: >> + return __pgprot(pgprot_val(PAGE_NONE_C)|_PAGE_CACHE040); > > _PAGE_CACHE040 should only be present when running on a 040 or 060. > Right, seems like I have missed the conditionality on CPU_IS_040_OR_060 while moving the code, will fix it.