From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8CCC43381 for ; Thu, 18 Mar 2021 15:59:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA64264E6B for ; Thu, 18 Mar 2021 15:59:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA64264E6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 314C36B006C; Thu, 18 Mar 2021 11:59:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EC2B6B0072; Thu, 18 Mar 2021 11:59:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B39C6B0073; Thu, 18 Mar 2021 11:59:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 019626B006C for ; Thu, 18 Mar 2021 11:59:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AD75D181AF5CC for ; Thu, 18 Mar 2021 15:59:53 +0000 (UTC) X-FDA: 77933455866.07.3A1993C Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf07.hostedemail.com (Postfix) with ESMTP id C3835A000649 for ; Thu, 18 Mar 2021 15:59:43 +0000 (UTC) IronPort-SDR: zElviUO59FK2HiCUG+DhOq7ShBholyotb7OZsWzRMMYN4kV5XZV8k/dq+pP9C7j0uqGikE/Jrn AMp65ZND92XQ== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="189086044" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="189086044" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 08:59:30 -0700 IronPort-SDR: kKWFS1pQmad2W49zFYAOG3ZxMvGCyh3Me0VkpNZIi7D+3z5rwfmc2LOnv0QgzMFM+kR/tdiT/+ a9w/Ya8Irwgw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="450527286" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.36.121]) ([10.209.36.121]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 08:59:29 -0700 Subject: Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap() To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Peter Collingbourne , Andrew Morton References: <20210316151054.5405-1-yu-cheng.yu@intel.com> <20210316151054.5405-22-yu-cheng.yu@intel.com> <20210318114232.GD19570@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Thu, 18 Mar 2021 08:59:28 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210318114232.GD19570@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: 7eh99kgehc3td41x3d8m94d9hc7ncxcs X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C3835A000649 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mga14.intel.com; client-ip=192.55.52.115 X-HE-DKIM-Result: none/none X-HE-Tag: 1616083183-899917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/18/2021 4:42 AM, Borislav Petkov wrote: > On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote: >> There was no more caller passing vm_flags to do_mmap(), and vm_flags was >> removed from the function's input by: >> >> commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). >> >> There is a new user now. Shadow stack allocation passes VM_SHSTK to >> do_mmap(). Re-introduce vm_flags to do_mmap(), but without the old wrapper >> do_mmap_pgoff(). > > Why does this matter at all? > > $ git grep do_mmap_pgoff > $ > Right, do_mmap_pgoff() was removed by commit 45e55300f114. This patch does not add back the wrapper. Instead, add vm_flags to do_mmap(). Please advice if I misunderstand the question. Thanks, Yu-cheng