From: Christoph Lameter <cl@linux.com>
To: Roman Gushchin <guro@fb.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Rik van Riel <riel@redhat.com>,
kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: make allocation counters per-order
Date: Thu, 6 Jul 2017 10:02:33 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1707060958010.24679@east.gentwo.org> (raw)
In-Reply-To: <1499346271-15653-1-git-send-email-guro@fb.com>
On Thu, 6 Jul 2017, Roman Gushchin wrote:
> +#define PGALLOC_EVENTS_SIZE (MAX_NR_ZONES * MAX_ORDER)
> +#define PGALLOC_EVENTS_CUT_SIZE (MAX_NR_ZONES * (MAX_ORDER - 1))
> +#define PGALLOC_FIRST_ZONE (PGALLOC_NORMAL - ZONE_NORMAL)
You are significantly increasing the per cpu counters (ZONES *
MAX_ORDER * cpus!!!). This will increase the cache footprint of critical
functions significantly and thus lead to regressions.
Typically counters for zones are placed in the zone structures but
you would also significantly increase the per zone counters ...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-06 15:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 13:04 [PATCH] mm: make allocation counters per-order Roman Gushchin
2017-07-06 13:19 ` Mel Gorman
2017-07-06 14:46 ` Roman Gushchin
2017-07-06 15:47 ` Mel Gorman
2017-07-06 16:43 ` Roman Gushchin
2017-07-06 17:16 ` Mel Gorman
2017-07-06 18:00 ` Debabrata Banerjee
2017-07-06 20:02 ` Mel Gorman
2017-07-16 13:27 ` Roman Gushchin
2017-07-16 13:29 ` Roman Gushchin
2017-07-16 13:55 ` [v2] " kbuild test robot
2017-07-06 14:54 ` [PATCH] " Debabrata Banerjee
2017-07-06 15:51 ` Mel Gorman
2017-07-06 16:12 ` Debabrata Banerjee
2017-07-06 16:43 ` Mel Gorman
2017-07-06 15:02 ` Christoph Lameter [this message]
2017-07-07 1:54 ` kbuild test robot
2017-07-07 6:06 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707060958010.24679@east.gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=riel@redhat.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).