From: David Rientjes <rientjes@google.com>
To: Henry Burns <henryburns@google.com>
Cc: Vitaly Wool <vitalywool@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vitaly Vul <vitaly.vul@sony.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Xidong Wang <wangxidong_97@163.com>,
Shakeel Butt <shakeelb@google.com>,
Jonathan Adams <jwadams@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/z3fold.c: Lock z3fold page before __SetPageMovable()
Date: Tue, 2 Jul 2019 11:58:48 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1907021158360.67286@chino.kir.corp.google.com> (raw)
In-Reply-To: <20190702005122.41036-1-henryburns@google.com>
On Mon, 1 Jul 2019, Henry Burns wrote:
> __SetPageMovable() expects it's page to be locked, but z3fold.c doesn't
> lock the page. Following zsmalloc.c's example we call trylock_page() and
> unlock_page(). Also makes z3fold_page_migrate() assert that newpage is
> passed in locked, as documentation.
>
> Signed-off-by: Henry Burns <henryburns@google.com>
> Suggested-by: Vitaly Wool <vitalywool@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2019-07-02 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 0:51 [PATCH v2] mm/z3fold.c: Lock z3fold page before __SetPageMovable() Henry Burns
2019-07-02 1:00 ` Shakeel Butt
2019-07-02 1:16 ` Henry Burns
2019-07-02 21:19 ` Andrew Morton
2019-07-02 22:17 ` Henry Burns
2019-07-02 22:24 ` Andrew Morton
2019-07-03 5:53 ` Vitaly Wool
2019-07-03 16:39 ` Henry Burns
2019-07-03 5:54 ` Vitaly Wool
2019-07-02 9:53 ` Vitaly Wool
2019-07-02 18:58 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1907021158360.67286@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=henryburns@google.com \
--cc=jwadams@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=shakeelb@google.com \
--cc=vitaly.vul@sony.com \
--cc=vitalywool@gmail.com \
--cc=wangxidong_97@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).