From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FCEDC432C1 for ; Tue, 24 Sep 2019 20:47:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55043207FD for ; Tue, 24 Sep 2019 20:47:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55043207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F2B156B0007; Tue, 24 Sep 2019 16:47:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDBA76B0008; Tue, 24 Sep 2019 16:47:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA2DF6B000A; Tue, 24 Sep 2019 16:47:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id B84F46B0007 for ; Tue, 24 Sep 2019 16:47:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 65B37180AD802 for ; Tue, 24 Sep 2019 20:47:53 +0000 (UTC) X-FDA: 75971000826.21.tramp23_a9e5898cd245 X-HE-Tag: tramp23_a9e5898cd245 X-Filterd-Recvd-Size: 2613 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Sep 2019 20:47:52 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 513AF3E9FB; Tue, 24 Sep 2019 20:47:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 4FE343E9E5; Tue, 24 Sep 2019 20:47:52 +0000 (UTC) Date: Tue, 24 Sep 2019 20:47:52 +0000 (UTC) From: cl@linux.com X-X-Sender: cl@www.lameter.com To: "Darrick J. Wong" cc: dsterba@suse.cz, Vlastimil Babka , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Ming Lei , Dave Chinner , Matthew Wilcox , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, James Bottomley , linux-btrfs@vger.kernel.org, Roman Gushchin , Johannes Weiner Subject: Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two) In-Reply-To: <20190923175146.GT2229799@magnolia> Message-ID: References: <20190826111627.7505-1-vbabka@suse.cz> <20190826111627.7505-3-vbabka@suse.cz> <20190923171710.GN2751@twin.jikos.cz> <20190923175146.GT2229799@magnolia> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 23 Sep 2019, Darrick J. Wong wrote: > On Mon, Sep 23, 2019 at 07:17:10PM +0200, David Sterba wrote: > > On Mon, Sep 23, 2019 at 06:36:32PM +0200, Vlastimil Babka wrote: > > > So if anyone thinks this is a good idea, please express it (preferably > > > in a formal way such as Acked-by), otherwise it seems the patch will be > > > dropped (due to a private NACK, apparently). > > Oh, I didn't realize ^^^^^^^^^^^^ that *some* of us are allowed the > privilege of gutting a patch via private NAK without any of that open > development discussion incovenience. There was a public discussion about this issue and from what I can tell the outcome was that the allocator already provides what you want. Which was a mechanism to misalign objects and detect these issues. This mechanism has been in use for over a decade.