From: David Rientjes <rientjes@google.com>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org,
tj@kernel.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org,
guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: fix a deadlock in show_slab_objects()
Date: Thu, 3 Oct 2019 12:56:51 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1910031255100.88296@chino.kir.corp.google.com> (raw)
In-Reply-To: <1570131869-2545-1-git-send-email-cai@lca.pw>
On Thu, 3 Oct 2019, Qian Cai wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index 42c1b3af3c98..922cdcf5758a 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4838,7 +4838,15 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
> }
> }
>
> - get_online_mems();
> +/*
> + * It is not possible to take "mem_hotplug_lock" here, as it has already held
> + * "kernfs_mutex" which could race with the lock order:
> + *
> + * mem_hotplug_lock->slab_mutex->kernfs_mutex
> + *
> + * In the worest case, it might be mis-calculated while doing NUMA node
> + * hotplug, but it shall be corrected by later reads of the same files.
> + */
> #ifdef CONFIG_SLUB_DEBUG
> if (flags & SO_ALL) {
> struct kmem_cache_node *n;
No objection to removing the {get,put}_online_mems() but the comment
doesn't match the kernel style. I actually don't think we need the
comment at all, actually.
> @@ -4879,7 +4887,6 @@ static ssize_t show_slab_objects(struct kmem_cache *s,
> x += sprintf(buf + x, " N%d=%lu",
> node, nodes[node]);
> #endif
> - put_online_mems();
> kfree(nodes);
> return x + sprintf(buf + x, "\n");
> }
next prev parent reply other threads:[~2019-10-03 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 19:44 [PATCH] mm/slub: fix a deadlock in show_slab_objects() Qian Cai
2019-10-03 19:56 ` David Rientjes [this message]
2019-10-03 20:07 ` Qian Cai
2019-10-03 20:27 ` David Rientjes
2019-10-04 8:13 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910031255100.88296@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).