From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_TONAME_EQ_TOLOCAL_HDRS_LCASE,PDS_TONAME_EQ_TOLOCAL_SHORT,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE14C43215 for ; Mon, 18 Nov 2019 21:22:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04ECA222DD for ; Mon, 18 Nov 2019 21:22:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eyjv0+S1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04ECA222DD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83FFE6B0005; Mon, 18 Nov 2019 16:22:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F1376B0006; Mon, 18 Nov 2019 16:22:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 706376B0007; Mon, 18 Nov 2019 16:22:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 5A9266B0005 for ; Mon, 18 Nov 2019 16:22:41 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id D0DC2180AD81A for ; Mon, 18 Nov 2019 21:22:40 +0000 (UTC) X-FDA: 76170672480.10.nose81_17597bf28e54a X-HE-Tag: nose81_17597bf28e54a X-Filterd-Recvd-Size: 3764 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Nov 2019 21:22:40 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id a10so1861636pju.10 for ; Mon, 18 Nov 2019 13:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=aSzFRLe2mDa0I96NWr1Lb6uvkLNDlqVI+nwWNFi/OEk=; b=eyjv0+S1cjWe1v6TECX9BBS+aBKSQiJjLuO3CpsTCHblcQJ/4D2wGwYWb+bAGP8sTs 0ReqYhdSOr6mT5JOn3Iy3NOVROesnesfQa2xk36Tnd79QRNNfb42p4rRqI1FCO+/Brmo joTkiFb/CTfaMcBAGYu0wsvXywYIYKFFe3SbGvSyVZXa2k/5df9rRFmfE0fC3rxLl0BA Ki/OjjNQwbVoodENxWTblMist3V2jbx6nZofoWjcuHiINB1Qn4yXDmvKfgfMpqPxEnc+ /l3ZBJs6iKzuC/+4OL9Ilwiz8/g09lHipIBFtRDh8im7KN4JIPK2PmOLOZECjpyyso34 jyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=aSzFRLe2mDa0I96NWr1Lb6uvkLNDlqVI+nwWNFi/OEk=; b=nS7WOcktF8/0IvTpw2VhuBQNJSauS9Jg0kcb+byboPO72Ft0Q/i23efyhkA3zCfQgL OvwYCqPXUJbGD6XxlSPDH5EVLWaY9merwrjd5jYcAqTJOfcs0AJOQUa7Kqte3+Kj/mR1 a/ckR3JwjQk+7Vx7SSw34e5nTBsNYvwd73927uiq++m4Mg3p0nE59bwUVgvhOF7JY+HE sJ96WiR18BagojaXYlfAymyz0WBYvGIR6PDGUYKGffsvoQEec5m6gQ4dAmtJ0KXhBAcI 6RvKHtIkedPnT3ejsHmmqEITyMebCDnpCN4uBxxvk7P3B9V1ntjQmACpcN36MP6RwH7c 0Kmw== X-Gm-Message-State: APjAAAXaOhvJzYpEvoT4U3VPn+YLxaZfIIw5Pw2v7eqNEBaEuzZpbys+ ZUf6bjAWMW3afXlMk5u3VpliiQ== X-Google-Smtp-Source: APXvYqymUoerdhYLn0Q+giAK++AaRTfGyW+rKfYQM0polVwI6u08y0l3FMzgDkwlKyLq/t0ajER5ew== X-Received: by 2002:a17:90a:25a1:: with SMTP id k30mr1487308pje.9.1574112159125; Mon, 18 Nov 2019 13:22:39 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id x25sm20832290pfq.73.2019.11.18.13.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 13:22:38 -0800 (PST) Date: Mon, 18 Nov 2019 13:22:37 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: linmiaohe cc: akpm@linux-foundation.org, richardw.yang@linux.intel.com, sfr@canb.auug.org.au, rppt@linux.ibm.com, jannh@google.com, steve.capper@arm.com, catalin.marinas@arm.com, aarcange@redhat.com, walken@google.com, dave.hansen@linux.intel.com, tiny.windzz@gmail.com, jhubbard@nvidia.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm: get rid of odd jump labels in find_mergeable_anon_vma() In-Reply-To: <1574079844-17493-1-git-send-email-linmiaohe@huawei.com> Message-ID: References: <1574079844-17493-1-git-send-email-linmiaohe@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 18 Nov 2019, linmiaohe wrote: > From: Miaohe Lin > > The jump labels try_prev and none are not really needed > in find_mergeable_anon_vma(), eliminate them to improve > readability. > > Reviewed-by: David Hildenbrand > Reviewed-by: John Hubbard > Signed-off-by: Miaohe Lin Acked-by: David Rientjes