From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C80AC35669 for ; Sat, 22 Feb 2020 03:40:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C34F20707 for ; Sat, 22 Feb 2020 03:40:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C34F20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 97F456B0008; Fri, 21 Feb 2020 22:40:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 92FFD6B000A; Fri, 21 Feb 2020 22:40:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CBF6B000C; Fri, 21 Feb 2020 22:40:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 71FF06B0008 for ; Fri, 21 Feb 2020 22:40:33 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 28C4B180AD804 for ; Sat, 22 Feb 2020 03:40:33 +0000 (UTC) X-FDA: 76516360746.18.toy38_7934cb9ebc244 X-HE-Tag: toy38_7934cb9ebc244 X-Filterd-Recvd-Size: 1810 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sat, 22 Feb 2020 03:40:32 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 706373F75F; Sat, 22 Feb 2020 03:40:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 6E5213F624; Sat, 22 Feb 2020 03:40:32 +0000 (UTC) Date: Sat, 22 Feb 2020 03:40:32 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: qiwuchen55@gmail.com cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH v2] mm/slub.c: replace kmem_cache->cpu_partial with wrapped APIs In-Reply-To: <1582079562-17980-1-git-send-email-qiwuchen55@gmail.com> Message-ID: References: <1582079562-17980-1-git-send-email-qiwuchen55@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.001157, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 19 Feb 2020, qiwuchen55@gmail.com wrote: > diff --git a/mm/slub.c b/mm/slub.c > index 17dc00e..1eb888c 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2284,7 +2284,7 @@ static void put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) > if (oldpage) { > pobjects = oldpage->pobjects; > pages = oldpage->pages; > - if (drain && pobjects > s->cpu_partial) { > + if (drain && pobjects > slub_cpu_partial(s)) { > unsigned long flags; > /* > * partial array is full. Move the existing Maybe its better to not generate code for put_cpu_partial() instead of using macros there if per cpu partials are disabled?