From: Paul Walmsley <paul.walmsley@sifive.com>
To: Atish Patra <atish.patra@wdc.com>, Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>,
Changbin Du <changbin.du@intel.com>,
Anup Patel <anup@brainfault.org>,
Palmer Dabbelt <palmer@sifive.com>,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>,
linux-mm@kvack.org, Borislav Petkov <bp@alien8.de>,
Vlastimil Babka <vbabka@suse.cz>, Gary Guo <gary@garyguo.net>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-riscv@lists.infradead.org,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH v3 1/3] x86: Move DEBUG_TLBFLUSH option.
Date: Thu, 27 Jun 2019 22:47:37 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1906272236550.3867@viisi.sifive.com> (raw)
In-Reply-To: <20190429212750.26165-2-atish.patra@wdc.com>
On Mon, 29 Apr 2019, Atish Patra wrote:
> CONFIG_DEBUG_TLBFLUSH was added in
>
> 'commit 3df3212f9722 ("x86/tlb: add tlb_flushall_shift knob into debugfs")'
> to support tlb_flushall_shift knob. The knob was removed in
>
> 'commit e9f4e0a9fe27 ("x86/mm: Rip out complicated, out-of-date, buggy
> TLB flushing")'.
> However, the debug option was never removed from Kconfig. It was reused
> in commit
>
> '9824cf9753ec ("mm: vmstats: tlb flush counters")'
> but the commit text was never updated accordingly.
>
> Update the Kconfig option description as per its current usage.
>
> Take this opportunity to make this kconfig option a common option as it
> touches the common vmstat code. Introduce another arch specific config
> HAVE_ARCH_DEBUG_TLBFLUSH that can be selected to enable this config.
Looks like this one still needs to be merged or acked by one of the x86
maintainers?
- Paul
next prev parent reply other threads:[~2019-06-28 5:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 21:27 [PATCH v3 0/3] TLB flush counters Atish Patra
2019-04-29 21:27 ` [PATCH v3 1/3] x86: Move DEBUG_TLBFLUSH option Atish Patra
2019-06-28 5:47 ` Paul Walmsley [this message]
2019-04-29 21:27 ` [PATCH v3 2/3] RISC-V: Enable TLBFLUSH counters for debug kernel Atish Patra
2019-04-29 21:27 ` [PATCH v3 3/3] RISC-V: Update tlb flush counters Atish Patra
2019-06-28 5:47 ` Paul Walmsley
2019-06-28 16:37 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1906272236550.3867@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=akpm@linux-foundation.org \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=bp@alien8.de \
--cc=changbin.du@intel.com \
--cc=gary@garyguo.net \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@redhat.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).