From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=aGFf=KU=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 829DBC4707F
	for <linux-mm@archiver.kernel.org>; Tue, 25 May 2021 09:12:21 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 19B7D61408
	for <linux-mm@archiver.kernel.org>; Tue, 25 May 2021 09:12:21 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19B7D61408
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gentwo.de
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id A357C6B006C; Tue, 25 May 2021 05:12:20 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id A0B9D6B006E; Tue, 25 May 2021 05:12:20 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 8FAAF6B0070; Tue, 25 May 2021 05:12:20 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218])
	by kanga.kvack.org (Postfix) with ESMTP id 5F9CA6B006C
	for <linux-mm@kvack.org>; Tue, 25 May 2021 05:12:20 -0400 (EDT)
Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id E5C7398A1
	for <linux-mm@kvack.org>; Tue, 25 May 2021 09:12:19 +0000 (UTC)
X-FDA: 78179187198.18.66DDFC7
Received: from gentwo.de (vmi485042.contaboserver.net [161.97.139.209])
	by imf21.hostedemail.com (Postfix) with ESMTP id D36FDE00080A
	for <linux-mm@kvack.org>; Tue, 25 May 2021 09:12:11 +0000 (UTC)
Received: by gentwo.de (Postfix, from userid 1001)
	id D377CB0084B; Tue, 25 May 2021 11:12:17 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by gentwo.de (Postfix) with ESMTP id CDE87B00814;
	Tue, 25 May 2021 11:12:17 +0200 (CEST)
Date: Tue, 25 May 2021 11:12:17 +0200 (CEST)
From: Christoph Lameter <cl@gentwo.de>
To: Vlastimil Babka <vbabka@suse.cz>
cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
    David Rientjes <rientjes@google.com>, Pekka Enberg <penberg@kernel.org>, 
    Joonsoo Kim <iamjoonsoo.kim@lge.com>, 
    Sebastian Andrzej Siewior <bigeasy@linutronix.de>, 
    Thomas Gleixner <tglx@linutronix.de>, 
    Mel Gorman <mgorman@techsingularity.net>, 
    Jesper Dangaard Brouer <brouer@redhat.com>, 
    Peter Zijlstra <peterz@infradead.org>, Jann Horn <jannh@google.com>
Subject: Re: [RFC 07/26] mm, slub: return slab page from get_partial() and
 set c->page afterwards
In-Reply-To: <20210524233946.20352-8-vbabka@suse.cz>
Message-ID: <alpine.DEB.2.22.394.2105251110550.107680@gentwo.de>
References: <20210524233946.20352-1-vbabka@suse.cz> <20210524233946.20352-8-vbabka@suse.cz>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: D36FDE00080A
Authentication-Results: imf21.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=pass (imf21.hostedemail.com: domain of cl@gentwo.de designates 161.97.139.209 as permitted sender) smtp.mailfrom=cl@gentwo.de
X-Rspamd-Server: rspam04
X-Stat-Signature: zxaedbg8z8t5fon773b8ffjar83c1k7x
X-HE-Tag: 1621933931-624275
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On Tue, 25 May 2021, Vlastimil Babka wrote:

> The function get_partial() finds a suitable page on a partial list, acquires
> and returns its freelist and assigns the page pointer to kmem_cache_node.
	in kmem_cache_cpu ??

> In later patch we will need more control over the kmem_cache_node assignment,

kmem_cache_cpu?

> so instead return the page pointer to get_partial()'s caller and assign it
> there. No functional change as all of this still happens with disabled irq.

Instead of passing a kmem_cache_cpu pointer pass a pointer to a pointer to
a page ....