From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566E5C43457 for ; Tue, 13 Oct 2020 19:28:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9F49208D5 for ; Tue, 13 Oct 2020 19:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QJDFWLm9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9F49208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E143A6B005D; Tue, 13 Oct 2020 15:28:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9E866B0062; Tue, 13 Oct 2020 15:28:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3E146B0068; Tue, 13 Oct 2020 15:28:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id B5BA76B005D for ; Tue, 13 Oct 2020 15:28:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7ECA2180AD811 for ; Tue, 13 Oct 2020 19:28:19 +0000 (UTC) X-FDA: 77367888318.20.fang09_010ae7a27205 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 61F8B180C07AF for ; Tue, 13 Oct 2020 19:28:19 +0000 (UTC) X-HE-Tag: fang09_010ae7a27205 X-Filterd-Recvd-Size: 3759 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 19:28:18 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id y14so287323pgf.12 for ; Tue, 13 Oct 2020 12:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=XGODVd8VkNSh8S84Wy0CghHqd0aFoaKdhs2B2qvJRwU=; b=QJDFWLm9JSrh/of7EIAurbQWhS26t3KiBiOYedmnmy5W/mdATsMGEThFkfuueGBiuD yUx1IWye8xXZ5sZSqRsm7uTgnhlhfgCInmdC1BBsnn3PuEIBlmJNZsAgXq9S7zqq0S+k zpgr/O1j/KEq5Hw+fxDBQIwzBRl+pO5bhGB5/7QtKTCJD+aD13xRuYup8hwes+FPXZ8b mHxg4A0iKwEsTeY5xl8BTKeTkxO4qwYgfcqQw1zOCb2g+eBsH/TGzwa8Knmrs+DjzrRa zBVL/4EvNgN+SEuUAdMs2M80hAWa/LAyVCDi8dhXt9t33NkGO9eMsNnF7GkJT+mRbIrA e/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=XGODVd8VkNSh8S84Wy0CghHqd0aFoaKdhs2B2qvJRwU=; b=sQqj9dmeBTEL0sOCI/7l/i0TbT4qIUAomXDi7ADTcCNnMKBkR263gnw8gZTv7kx+KL QPEIkd3ducKJxRvOpGLUZOY6aSSiG5ImrGdRoKB+JL7glVXKhXyUcj0p0UADvlcidW6e 3OC1KQzfYciTDGFbg5g1j0TDggTueBnqmTE9oUaK/p2XkMEcJl/ehi5bHgRxLa23LDMg w/a87tnMyJ5AWJ8dn6x4tUom0+twu8m+qpFmlxD4ylbC/BLzs5ze0WTHah0yRQ/YEmC1 m6Flh0Ypa3Pr2Rh49oozP8WSyY1V/SQfblMJ/X/jhT6GBj7tcSx8Ej7hsfX7ul2Mo5mG il3A== X-Gm-Message-State: AOAM532ALlEQoYQvO9nXVo7UcQDrnCEQL9V7nQr07MykW55Mh7EYdPvr GG0YCktiiWcX5OSJSVbwMdSc8Q== X-Google-Smtp-Source: ABdhPJy2evLKaGL1nBwO+26TFfdymcOWCpNx62svTg8d0nxs5ceQ34ZURql6eqJr6Kw1O+7SRZw3Nw== X-Received: by 2002:a05:6a00:44:b029:152:8967:1b2a with SMTP id i4-20020a056a000044b029015289671b2amr1158045pfk.48.1602617297742; Tue, 13 Oct 2020 12:28:17 -0700 (PDT) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id s23sm413493pgl.47.2020.10.13.12.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 12:28:16 -0700 (PDT) Date: Tue, 13 Oct 2020 12:28:15 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Muchun Song cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, shakeelb@google.com, guro@fb.com, vbabka@suse.cz, laoar.shao@gmail.com, chris@chrisdown.name, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcontrol: Remove unused mod_memcg_obj_state() In-Reply-To: <20201013153504.92602-1-songmuchun@bytedance.com> Message-ID: References: <20201013153504.92602-1-songmuchun@bytedance.com> User-Agent: Alpine 2.23 (DEB 453 2020-06-18) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Oct 2020, Muchun Song wrote: > Since commit: > > 991e7673859e ("mm: memcontrol: account kernel stack per node") > > There is no user of the mod_memcg_obj_state(). This patch just remove > it. Also rework type of the idx parameter of the mod_objcg_state() > from int to enum node_stat_item. > > Signed-off-by: Muchun Song Acked-by: David Rientjes