From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59006C3A589 for ; Thu, 15 Aug 2019 22:28:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 15F1E206C1 for ; Thu, 15 Aug 2019 22:28:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15F1E206C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=namei.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A99426B0005; Thu, 15 Aug 2019 18:28:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A49DD6B0006; Thu, 15 Aug 2019 18:28:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938616B0007; Thu, 15 Aug 2019 18:28:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 761CF6B0005 for ; Thu, 15 Aug 2019 18:28:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0EEDB55FAE for ; Thu, 15 Aug 2019 22:28:04 +0000 (UTC) X-FDA: 75826101288.05.toes25_c29011ef6b07 X-HE-Tag: toes25_c29011ef6b07 X-Filterd-Recvd-Size: 4422 Received: from namei.org (namei.org [65.99.196.166]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Aug 2019 22:28:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by namei.org (8.14.4/8.14.4) with ESMTP id x7FMR7wY025897; Thu, 15 Aug 2019 22:27:07 GMT Date: Fri, 16 Aug 2019 08:27:07 +1000 (AEST) From: James Morris To: Mark Salyzyn cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-team@android.com, Stephen Smalley , linux-security-module@vger.kernel.org, stable@vger.kernel.org, Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , David Howells , Chris Mason , Josef Bacik , David Sterba , Jeff Layton , Sage Weil , Ilya Dryomov , Steve French , Tyler Hicks , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , David Woodhouse , Richard Weinberger , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Alexander Viro , Phillip Lougher , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Hugh Dickins , "David S. Miller" , Serge Hallyn , Mimi Zohar , Paul Moore , Eric Paris , Casey Schaufler , Andrew Morton , Vyacheslav Dubeyko , =?ISO-8859-15?Q?Ernesto_A=2E_Fern=E1ndez?= , Mathieu Malaterre , v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH] Add flags option to get xattr method paired to __vfs_getxattr In-Reply-To: <69889dec-5440-1472-ed57-380f45547581@android.com> Message-ID: References: <20190812193320.200472-1-salyzyn@android.com> <20190813084801.GA972@kroah.com> <69889dec-5440-1472-ed57-380f45547581@android.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Aug 2019, Mark Salyzyn wrote: > Good Idea, but using the same argument structure for set and get I would be > concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. > struct getxattr_args { > struct dentry *dentry; > struct inode *inode; > const char *name; > void *buffer; > size_t size; > int flags; Does 'get' need flags? -- James Morris