From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9345C3F2C6 for ; Tue, 3 Mar 2020 06:34:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C28321775 for ; Tue, 3 Mar 2020 06:34:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RT+Kea4i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C28321775 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 348D26B0005; Tue, 3 Mar 2020 01:34:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D2906B0006; Tue, 3 Mar 2020 01:34:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19AA46B0007; Tue, 3 Mar 2020 01:34:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id F19126B0005 for ; Tue, 3 Mar 2020 01:34:04 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D551C8248D51 for ; Tue, 3 Mar 2020 06:34:04 +0000 (UTC) X-FDA: 76553086008.30.hall35_2398162b2e10d X-HE-Tag: hall35_2398162b2e10d X-Filterd-Recvd-Size: 4554 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Mar 2020 06:34:04 +0000 (UTC) Received: by mail-ot1-f43.google.com with SMTP id x97so1921300ota.6 for ; Mon, 02 Mar 2020 22:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=nd/TEeW4LQOvJMaEt1rZVabT2kTJB3dRDcejupbt5xY=; b=RT+Kea4iOHlH9H/H9pNH1Sk5JZ4dns1gAbgYhpwbXqqZbzVX5jEh1et1qoLilG5wVs oO2JK/0A0BWeTpwrk38qIZ6XZ4P3iBdLicT+oqLeMT/lp5vTN+FuRTu9OOkmhkC8cJca VNnFYWcAPZnYcrYLsnEGl2OTcQKWgZgulNDfrJbAPifq7V9ST4c9TsnqL5L3xl31itA7 zTqGIMx5oodNwYKcTa39nYsVUZd9viLRjg7pyd6NoVpKZ1KakGNLr2ZMf2jo0YkKKo7G qZSY6uQZE16aoTg0ZtnBdaWfz1YWULza/Pk+PtsfaW25hJEnjirgGc/h7Hl4hMWxRARM 8K9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=nd/TEeW4LQOvJMaEt1rZVabT2kTJB3dRDcejupbt5xY=; b=K+EDC7JAcKURXZ+b3H5tCZa8Y9KDCWLEygfjPMvhxWFIVV4Wx2hBJwg4o6RxQxClY0 x8HdA7OZcdo1HzH1sVxJmJsr6zcPlMBDQ4ptMwItucBJeX1WtdbSWXCBplG944+EuZ2d jfdHx46nftBeLLcoiUONlDzEzYDSTX7AIK8sUhwZX7CP3j4EJ4azt6rV7FRConO3XTNH YCZ82tq3qrV/ubJl67mx83iXGiR6icAOGolSseTXzoSM2vCysGD1oglWwBlQpM3kZ8cV crVZg9GpcG8D0m6Xok4Lo8nkQSZjoJyyUpNy+z9x1N0D5bvwoEs5KGb70pvUBOnRc6U3 N0KA== X-Gm-Message-State: ANhLgQ2+TMZr/i6ZjtM1D703PYHcqMXdCXMeD8dpK+mV/K3mHPq66IWz bLv5g8cil6J0k5mTKQ9YoqO6Rg== X-Google-Smtp-Source: ADFU+vt+oiBRDRmtU/BlPEpanrfpTiCQDOW8t3tex0y3+5iv9DRGttD0LyFJlWuDDjetCc5tLiQDxw== X-Received: by 2002:a05:6830:1203:: with SMTP id r3mr2352162otp.230.1583217243235; Mon, 02 Mar 2020 22:34:03 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id z10sm7243729oih.1.2020.03.02.22.34.01 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Mar 2020 22:34:02 -0800 (PST) Date: Mon, 2 Mar 2020 22:34:00 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Anshuman Khandual cc: linux-mm@kvack.org, "David S. Miller" , Alexey Dobriyan , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Hugh Dickins , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 3/3] mm/vma: Introduce some more VMA flag wrappers In-Reply-To: <1583131666-15531-4-git-send-email-anshuman.khandual@arm.com> Message-ID: References: <1583131666-15531-1-git-send-email-anshuman.khandual@arm.com> <1583131666-15531-4-git-send-email-anshuman.khandual@arm.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2 Mar 2020, Anshuman Khandual wrote: > This adds the following new VMA flag wrappers which will replace current > open encodings across various places. This should not have any functional > implications. > > vma_is_dontdump() > vma_is_noreserve() > vma_is_special() > vma_is_locked() > vma_is_mergeable() > vma_is_softdirty() > vma_is_thp() > vma_is_nothp() Why?? Please don't. I am not at all keen on your 1/3 and 2/3 (some of us actually like to see what the VM_ flags are where they're used, without having to chase through scattered wrappers hiding them), but this 3/3 particularly upset me. There is a good reason for the (hideously named) is_vm_hugetlb_page(vma): to save "#ifdef CONFIG_HUGETLB_PAGE"s all over (though I suspect the same could have been achieved much more nicely by #define VM_HUGETLB 0); but hiding all flags in vma_is_whatever()s is counter-productive churn. Improved readability? Not to my eyes. Hugh