From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107B8C433E0 for ; Tue, 2 Jun 2020 21:36:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9EFCB20679 for ; Tue, 2 Jun 2020 21:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kmF9Mk0l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EFCB20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE4AF80007; Tue, 2 Jun 2020 17:36:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E95178E0006; Tue, 2 Jun 2020 17:36:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9C580007; Tue, 2 Jun 2020 17:36:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id C30F48E0006 for ; Tue, 2 Jun 2020 17:36:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7E465181AEF00 for ; Tue, 2 Jun 2020 21:36:54 +0000 (UTC) X-FDA: 76885581948.09.frog31_76772db49fa27 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 58646180AD807 for ; Tue, 2 Jun 2020 21:36:54 +0000 (UTC) X-HE-Tag: frog31_76772db49fa27 X-Filterd-Recvd-Size: 4023 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 21:36:53 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id s21so4634229oic.9 for ; Tue, 02 Jun 2020 14:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=2nZCSlHwDgirkJDz3qzP+sn34b+j2FAnmoqRb4db9Uo=; b=kmF9Mk0lZxH9kOBlKtiXGIxiEQvjdN/aNPUMa+QlcYRqVncRNN1KnVqASyIB768M/P GDw9nWOFyMnvBQFJ61/q0mqgKSwUs9cT88o4zYOdVNUV0ejiG5TOPBxDwW+hb/rc/Qkx k3fZWns2bSYn/jyM1ddzWCIlQXlyZ6adLblCl0VoPAfkahxvi8+OQ+9Rl3jS+Hur7RLf E5lqClKhP23YBBgtfgKD6w+lS0et83zmRxANVKpKWDUacgJmz0X6y8ofkDvsX1Pb87YK jLsNCk2zxOX3MN3uPvDnlz3aWfUd9PoTOJBItb7hPt6usKn+ZL9F5NNvk9EO48tEMFRl IBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=2nZCSlHwDgirkJDz3qzP+sn34b+j2FAnmoqRb4db9Uo=; b=qqwpC6TDKjADhu8FCPJBeXHccrtsgMqwfSbF2BLfvXyIZ0CpYGqNsKDd64+J1cTwL+ +N9xAr9l/G5PFgImNgne/3HXntd9eZy1H/QNQtZ4GxQeggFuyKi5wkj+TBrdDyosc9I7 UrxbtCFAsHmSao/CnWcDaaP/RZT+rR0yJB6RCJ2Nz61PXqElvBeAZs/bGNVF+ui1/Nhv jMnGIN1ABI7reNF/h4E3oearPRvwCLAHHcvIWoAtUASvoCHytbPdVsWpUN49YGqw9vsH JIYEPbuYBZOuy7R+cN89AmSGSEMMvXrDCAZw3D8o8DwNy/acJvYCkgMtttdKhtnLCftB wieQ== X-Gm-Message-State: AOAM53255eHnKMJEqV/E2pXKpjX3cTWrZZXde0WKhqXdT7I3rj5pXc5a V/Ve/KQwznJBCfNbdaVpovxRfg== X-Google-Smtp-Source: ABdhPJzkwsbNArCTI3Y/mhFSeslEAW0mCipr504llWn5gCigF1/O+S5Zz6vSGdFqD30/k2c7KcfIaQ== X-Received: by 2002:aca:e1d6:: with SMTP id y205mr4502559oig.142.1591133812860; Tue, 02 Jun 2020 14:36:52 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a34sm20123otc.60.2020.06.02.14.36.49 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Tue, 02 Jun 2020 14:36:51 -0700 (PDT) Date: Tue, 2 Jun 2020 14:36:32 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds , Andrew Morton cc: dchinner@redhat.com, ebiggers@google.com, gaoxiang25@huawei.com, guoqing.jiang@cloud.ionos.com, jaegeuk@kernel.org, jhubbard@nvidia.com, johannes.thumshirn@wdc.com, joseph.qi@linux.alibaba.com, junxiao.bi@oracle.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, mszeredi@redhat.com, xiyou.wangcong@gmail.com, yuchao0@huawei.com, ziy@nvidia.com Subject: [PATCH] mm/migrate.c: attach_page_private already does the get_page Message-ID: User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: 58646180AD807 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just finished bisecting mmotm, to find why a test which used to take four minutes now took more than an hour: the __buffer_migrate_page() cleanup left behind a get_page() which attach_page_private() now does. Fixes: cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code") Signed-off-by: Hugh Dickins --- Fixes the 048/128 of last night's (or today's) incoming from akpm: sorry I didn't complete the bisection before it went into Linus's tree. mm/migrate.c | 1 - 1 file changed, 1 deletion(-) --- linux.git/mm/migrate.c 2020-06-02 14:04:49.098981268 -0700 +++ linux/mm/migrate.c 2020-06-02 14:07:20.431991495 -0700 @@ -798,7 +798,6 @@ recheck_buffers: goto unlock_buffers; attach_page_private(newpage, detach_page_private(page)); - get_page(newpage); bh = head; do {