From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73652C433DF for ; Thu, 11 Jun 2020 22:26:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F3CB2073E for ; Thu, 11 Jun 2020 22:26:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OzpB2OD9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F3CB2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7BB68D00A8; Thu, 11 Jun 2020 18:26:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2C318D00A0; Thu, 11 Jun 2020 18:26:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC708D00A8; Thu, 11 Jun 2020 18:26:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 740978D00A0 for ; Thu, 11 Jun 2020 18:26:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2EA7D8A1B5 for ; Thu, 11 Jun 2020 22:26:19 +0000 (UTC) X-FDA: 76918365678.15.straw67_370329626dd7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id DC8E51814B0C1 for ; Thu, 11 Jun 2020 22:26:18 +0000 (UTC) X-HE-Tag: straw67_370329626dd7 X-Filterd-Recvd-Size: 8576 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 11 Jun 2020 22:26:18 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id 25so6895854oiy.13 for ; Thu, 11 Jun 2020 15:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=GzFRhux1wSgI812RbpDpAhu3GXlBa7Bd4rcSyefPhVA=; b=OzpB2OD9k6LHz7ctmh2NEbz3y65CGLWLCVnma5Ps+TheGsbwt1vtfty1l3R3pGnYi5 9kuK0m7QLaiGniJz2VRtt96/6QrJfTA4qQDIRq75mHWD7qH3gXO4fDgzfxRAKoaUa08+ g8jWn+o/OFWX7N7K1X9s2lzB6POD5vvemgqI7vA6/6BlOEUxvWa/knoa9Oy/1qf9IhmA 5SOlMrILU6p5Wwb9ABnnoDRYXG+L3ijF/V8ltXVNzXsW2KL8DuzZOo4feCoTLLzZRh4j pYvE9MrzQirUE0i9K12igcNi4L53ZGAPfU2j01WCpFNaecw5hXl7S4TXNSLNaoLRaalx 6NPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=GzFRhux1wSgI812RbpDpAhu3GXlBa7Bd4rcSyefPhVA=; b=AxT7zvOaCi1803qztIuxFG18PNjUNYgGhcanECbd/6QbS+o5iim9HTJq/NDvq3+6T9 HDKM3vXQQUvHLqYFO9RD/iIzeCaRWy9ZnlCxLzY4qUVeVWDaUd301elZ4jy3LsdjxuHC CJPVyAK5YBJy3m6HhG4vQ7qV7B3GltuuR2kHatqs/AygJncqaWCmsbie5lNUijj+v9Xk rvW7Ppp6cPSMKSYe6eXgXl3dF5f8+5w1yLIR9mtOcv14Q9yP4Gd0blVM8IlcSYnPmV3Y bYXis1qPvBO7LpOfLJBgt7pWgpD/66l4m2/kvPMsH7mHAoRQx/rCTTLqcGziiJGrmZ24 JyFA== X-Gm-Message-State: AOAM533GbgvKjP4uDEkGPswFZp1vgJE6w/L2yCIY4ZM8FIopcgrI56nN CmQ3g0gXjNtfA0JE3UIeF9rvww== X-Google-Smtp-Source: ABdhPJzOGXq9awTs6f6SrHd8AbBVBmRp+c0JvL2f3Ys+E1G7lVWVJ4FnYj92vCFLqGFElzt7dToGlw== X-Received: by 2002:aca:ea43:: with SMTP id i64mr146837oih.51.1591914377498; Thu, 11 Jun 2020 15:26:17 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id p13sm951911otp.58.2020.06.11.15.26.15 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Thu, 11 Jun 2020 15:26:16 -0700 (PDT) Date: Thu, 11 Jun 2020 15:26:14 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Alex Shi cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Subject: Re: [PATCH v12 00/16] per memcg lru lock In-Reply-To: <1591856209-166869-1-git-send-email-alex.shi@linux.alibaba.com> Message-ID: References: <1591856209-166869-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: DC8E51814B0C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 11 Jun 2020, Alex Shi wrote: > This is a new version which bases on v5.8, No, not even v5.8-rc1 has come out yet. v12 applied cleanly on 2dca74a40e1e7ff45079d85fc507769383039b9d but I didn't check the build. > only change mm/compaction.c > since mm-compaction-avoid-vm_bug_onpageslab-in-page_mapcount.patch > removed. > > Johannes Weiner has suggested: > "So here is a crazy idea that may be worth exploring: > > Right now, pgdat->lru_lock protects both PageLRU *and* the lruvec's > linked list. > > Can we make PageLRU atomic and use it to stabilize the lru_lock > instead, and then use the lru_lock only serialize list operations? > ..." It was well worth exploring, and may help in a few cases; Johannes's memcg swap simplifications have helped a lot more; but crashes under rotate_reclaimable_page() show that this series still does not give enough protection from mem_cgroup_move_account(). I'll send a couple of fixes to compaction bugs in reply to this: with those in, compaction appears to be solid. Hugh > > With new memcg charge path and this solution, we could isolate > LRU pages to exclusive visit them in compaction, page migration, reclaim, > memcg move_accunt, huge page split etc scenarios while keeping pages' > memcg stable. Then possible to change per node lru locking to per memcg > lru locking. As to pagevec_lru_move_fn funcs, it would be safe to let > pages remain on lru list, lru lock could guard them for list integrity. > > The patchset includes 3 parts: > 1, some code cleanup and minimum optimization as a preparation. > 2, use TestCleanPageLRU as page isolation's precondition > 3, replace per node lru_lock with per memcg per node lru_lock > > The 3rd part moves per node lru_lock into lruvec, thus bring a lru_lock for > each of memcg per node. So on a large machine, each of memcg don't > have to suffer from per node pgdat->lru_lock competition. They could go > fast with their self lru_lock > > Following Daniel Jordan's suggestion, I have run 208 'dd' with on 104 > containers on a 2s * 26cores * HT box with a modefied case: > https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice > > With this patchset, the readtwice performance increased about 80% > in concurrent containers. > > Thanks Hugh Dickins and Konstantin Khlebnikov, they both brought this > idea 8 years ago, and others who give comments as well: Daniel Jordan, > Mel Gorman, Shakeel Butt, Matthew Wilcox etc. > > Thanks for Testing support from Intel 0day and Rong Chen, Fengguang Wu, > and Yun Wang. Hugh Dickins also shared his kbuild-swap case. Thanks! > > > Alex Shi (14): > mm/vmscan: remove unnecessary lruvec adding > mm/page_idle: no unlikely double check for idle page counting > mm/compaction: correct the comments of compact_defer_shift > mm/compaction: rename compact_deferred as compact_should_defer > mm/thp: move lru_add_page_tail func to huge_memory.c > mm/thp: clean up lru_add_page_tail > mm/thp: narrow lru locking > mm/memcg: add debug checking in lock_page_memcg > mm/lru: introduce TestClearPageLRU > mm/compaction: do page isolation first in compaction > mm/mlock: reorder isolation sequence during munlock > mm/lru: replace pgdat lru_lock with lruvec lock > mm/lru: introduce the relock_page_lruvec function > mm/pgdat: remove pgdat lru_lock > > Hugh Dickins (2): > mm/vmscan: use relock for move_pages_to_lru > mm/lru: revise the comments of lru_lock > > Documentation/admin-guide/cgroup-v1/memcg_test.rst | 15 +- > Documentation/admin-guide/cgroup-v1/memory.rst | 8 +- > Documentation/trace/events-kmem.rst | 2 +- > Documentation/vm/unevictable-lru.rst | 22 +-- > include/linux/compaction.h | 4 +- > include/linux/memcontrol.h | 92 +++++++++++ > include/linux/mm_types.h | 2 +- > include/linux/mmzone.h | 6 +- > include/linux/page-flags.h | 1 + > include/linux/swap.h | 4 +- > include/trace/events/compaction.h | 2 +- > mm/compaction.c | 96 +++++++----- > mm/filemap.c | 4 +- > mm/huge_memory.c | 51 +++++-- > mm/memcontrol.c | 87 ++++++++++- > mm/mlock.c | 93 ++++++------ > mm/mmzone.c | 1 + > mm/page_alloc.c | 1 - > mm/page_idle.c | 8 - > mm/rmap.c | 2 +- > mm/swap.c | 112 ++++---------- > mm/swap_state.c | 6 +- > mm/vmscan.c | 168 +++++++++++---------- > mm/workingset.c | 4 +- > 24 files changed, 481 insertions(+), 310 deletions(-) > > -- > 1.8.3.1