From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0ABC433E0 for ; Sat, 1 Aug 2020 02:17:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE11720838 for ; Sat, 1 Aug 2020 02:17:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kOp5n2iZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE11720838 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 738CA8D0067; Fri, 31 Jul 2020 22:17:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E9668D000B; Fri, 31 Jul 2020 22:17:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 600878D0067; Fri, 31 Jul 2020 22:17:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 4B13F8D000B for ; Fri, 31 Jul 2020 22:17:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DCF691EF1 for ; Sat, 1 Aug 2020 02:17:21 +0000 (UTC) X-FDA: 77100387882.04.hill35_150416426f88 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id A8262800AD08 for ; Sat, 1 Aug 2020 02:17:21 +0000 (UTC) X-HE-Tag: hill35_150416426f88 X-Filterd-Recvd-Size: 3904 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Sat, 1 Aug 2020 02:17:21 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id c12so15485561qtn.9 for ; Fri, 31 Jul 2020 19:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=551gxb/V4cTHIiiIvEHAlAkEOZo6GSnjWtQQen+5b6w=; b=kOp5n2iZXKZcz2c1X475lqnIm8vIuCa31L9u9JzJGWOkwWQbIQLlZ+H1amAAkf7QHz XgJ44qXJ+jM3HedbEquCiofO6qhNMjEnMpuqlRXhrGPiz62cxjy+LBGVuJGGZiD5cI79 sNV/5JsZtDcTbbGvs8Xx/qDgH4VKyZTgGqM1tXIbCvO+fKPIWWCy55t6XmV+OJ/7WbID ab4tZEkFPTd1ROZ/MT0fTdfVNwA2ucD+CJ0qbNV/nyTcMshplVmt9Ic2H/yoffvBXkjT /09Eg4qld3E0biyLZHdIXHcXQOvs+NPZwv0mWR23SQWtkTsnYJIsP0PUYtD5hSB3n496 8ndQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=551gxb/V4cTHIiiIvEHAlAkEOZo6GSnjWtQQen+5b6w=; b=O5xzTZC45vleXbd4UPFQv9TwdOU23Fya1cfzmzQT6YAFVy2rS98nl/o8CrgAuQXzgb /kb1G3BX1qtebgaQxxXnYenXKxXcPzoqb1693ozaCFtBuUK9C61TdWyv/P9u88bNGLhi bxNR+6FFW3WIqFZ0qNmDrK/sgU7ce687957NkCEPjJiaqV3OV6mYvAek0neVuDfnHKjD amUYbd7OzNggzT9AsQCS7bit9td1Dyjf7fB3UIHPRtiXsWxldaPUsUrWjMM23M0mWbFp 5qSnN7uaMDXFVOsfW7vyxL36cUE7n6GSRUvJuaJkV2/js2mK16ScDk3JAZXM6evgEZam z3dA== X-Gm-Message-State: AOAM530RHZ/fiVjKeWH1ob3ONu7f4r6zjVd3KdrG3lZF/L89J/EJXLNc +ud1V1eR2HZwtR4W5sJa0uTa9A== X-Google-Smtp-Source: ABdhPJz3gH++78Vvmmq9ZZ1hzxWOKmU7mlavMunGl3Se40mVR64wiolL/i1HG7NMo1VevX15NFmYRQ== X-Received: by 2002:ac8:7402:: with SMTP id p2mr6521959qtq.19.1596248240453; Fri, 31 Jul 2020 19:17:20 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 78sm11130904qke.81.2020.07.31.19.17.18 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Fri, 31 Jul 2020 19:17:19 -0700 (PDT) Date: Fri, 31 Jul 2020 19:17:05 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Roman Gushchin cc: Hugh Dickins , Andrew Morton , Johannes Weiner , Michal Hocko , Vlastimil Babka , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: vmstat: fix /proc/sys/vm/stat_refresh generating false warnings In-Reply-To: <20200801011821.GA859734@carbon.dhcp.thefacebook.com> Message-ID: References: <20200714173920.3319063-1-guro@fb.com> <20200730162348.GA679955@carbon.dhcp.thefacebook.com> <20200801011821.GA859734@carbon.dhcp.thefacebook.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Rspamd-Queue-Id: A8262800AD08 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 31 Jul 2020, Roman Gushchin wrote: > On Thu, Jul 30, 2020 at 09:06:55PM -0700, Hugh Dickins wrote: > > > > Though another alternative did occur to me overnight: we could > > scrap the logged warning, and show "nr_whatever -53" as output > > from /proc/sys/vm/stat_refresh: that too would be acceptable > > to me, and you redirect to /dev/null. > > It sounds like a good idea to me. Do you want me to prepare a patch? Yes, if you like that one best, please do prepare a patch - thanks! Hugh