From: Hugh Dickins <hughd@google.com> To: Andrew Morton <akpm@linux-foundation.org> Cc: Alex Shi <alex.shi@linux.alibaba.com>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@suse.com>, Mike Kravetz <mike.kravetz@oracle.com>, Shakeel Butt <shakeelb@google.com>, Matthew Wilcox <willy@infradead.org>, Qian Cai <cai@lca.pw>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/5] mm: migration of hugetlbfs page skip memcg Date: Sun, 30 Aug 2020 14:01:30 -0700 (PDT) Message-ID: <alpine.LSU.2.11.2008301359460.5954@eggly.anvils> (raw) In-Reply-To: <alpine.LSU.2.11.2008301343270.5954@eggly.anvils> hugetlbfs pages do not participate in memcg: so although they do find most of migrate_page_states() useful, it would be better if they did not call into mem_cgroup_migrate() - where Qian Cai reported that LTP's move_pages12 triggers the warning in Alex Shi's prospective commit "mm/memcg: warning on !memcg after readahead page charged". Signed-off-by: Hugh Dickins <hughd@google.com> --- This fixes a likely future warning, but is just a cleanup right now. mm/migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- 5.9-rc2/mm/migrate.c 2020-08-16 17:32:50.665507048 -0700 +++ linux/mm/migrate.c 2020-08-28 17:42:07.967278385 -0700 @@ -668,7 +668,8 @@ void migrate_page_states(struct page *ne copy_page_owner(page, newpage); - mem_cgroup_migrate(page, newpage); + if (!PageHuge(page)) + mem_cgroup_migrate(page, newpage); } EXPORT_SYMBOL(migrate_page_states);
next prev parent reply index Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-30 20:57 [PATCH 0/5] mm: fixes to past from future testing Hugh Dickins 2020-08-30 20:59 ` [PATCH 1/5] ksm: reinstate memcg charge on copied pages Hugh Dickins 2020-08-31 14:40 ` Shakeel Butt 2020-09-01 15:01 ` Johannes Weiner 2020-08-30 21:01 ` Hugh Dickins [this message] 2020-08-31 14:40 ` [PATCH 2/5] mm: migration of hugetlbfs page skip memcg Shakeel Butt 2020-09-01 15:02 ` Johannes Weiner 2020-08-30 21:08 ` [PATCH 4/5] mm: fix check_move_unevictable_pages() on THP Hugh Dickins 2020-08-31 14:44 ` Shakeel Butt 2020-09-01 2:04 ` Alex Shi 2020-09-01 3:59 ` Hugh Dickins 2020-09-01 15:57 ` Yang Shi 2020-08-30 21:09 ` [PATCH 5/5] mlock: fix unevictable_pgs event counts " Hugh Dickins 2020-08-31 14:45 ` Shakeel Butt 2020-09-01 15:41 ` Yang Shi 2020-09-01 2:28 ` [PATCH 0/5] mm: fixes to past from future testing Alex Shi 2020-09-01 4:08 ` Hugh Dickins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LSU.2.11.2008301359460.5954@eggly.anvils \ --to=hughd@google.com \ --cc=akpm@linux-foundation.org \ --cc=alex.shi@linux.alibaba.com \ --cc=cai@lca.pw \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=mike.kravetz@oracle.com \ --cc=shakeelb@google.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ linux-mm@kvack.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git