From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DD0C4727C for ; Tue, 22 Sep 2020 05:44:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1EC7923A9C for ; Tue, 22 Sep 2020 05:44:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="OCgfz6fy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EC7923A9C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 902636B00DE; Tue, 22 Sep 2020 01:44:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88AA56B00DF; Tue, 22 Sep 2020 01:44:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 753D46B00E0; Tue, 22 Sep 2020 01:44:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 5BDEF6B00DE for ; Tue, 22 Sep 2020 01:44:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 012961EE6 for ; Tue, 22 Sep 2020 05:44:21 +0000 (UTC) X-FDA: 77289607164.06.walk65_4116b4c2714b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id C26C2100A9386 for ; Tue, 22 Sep 2020 05:44:21 +0000 (UTC) X-HE-Tag: walk65_4116b4c2714b X-Filterd-Recvd-Size: 6323 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Sep 2020 05:44:21 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id i17so19762365oig.10 for ; Mon, 21 Sep 2020 22:44:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=VqM0C5aizd06EEJhbPcKDGQSZnlrNdjhm1j3MXU1V80=; b=OCgfz6fy1qQPxVmz3FNoiB4+LRJSLY2XeCFt6IARQmhRwm/sfZYsUv+N4gUa7j3oe0 iI8TK21X75WMXgA/oWIHyWGLTVX/UyWjTkPygXM01E7XHpWRo1ksBgMPlf6Dg2LTWkut 8iVQ/GrKomUCJyx+l5lRaIE9kijzB/RlhSJMgIA5jx2wW0Ik0QWJxo3N068QOeg7LJ8A xca37W+dQsM7pfSykEykegXvuqOnWYf1COCWncsk7ZO8g3gHy7/n1mB0L71KWd2nAjAq FmIbVNw/01E9uWvCkYQKreyCjuFeQVtKvYJsbZ4UBJSf6QGj6yO5Kh/S9VcryWOQJlC5 Vikw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=VqM0C5aizd06EEJhbPcKDGQSZnlrNdjhm1j3MXU1V80=; b=TLXTqEbLC6rm+TV0zd1eBRpO/BMWfLm7//b5nn1j0RFhODrjOOio9PCOhnqTDxlFZm SZ9ZWS/MEOcWGFfxY/fc/120S3X2UlDfFap7wvCFtt1ldxglBQ+IGZbQIyLoS0EnLq6F Dh+SF9UFzz1hES0qc84Tw0vA031PyXLIha7Y6+Khb5xFQpXPMNeppwf1pS0p44nwqmWF NtO2GeC+4YLbS42RNwGXFdtdrZh5+HozFHEQmZXOWtJdg7vvapz44r1bg7gvCmB9kIbW EIPEQ/ck2ja7J0Vl9BkdiF26B65vC7ddUGQRj0R7MgJMfCByvVpIiebcXDwIoyhfy38i aHpg== X-Gm-Message-State: AOAM532A7D4cR7UjBErLLnB0EanpD74s4KP2P2nZ2dVvxgZQ98MpvUvH Vy7ARpiGO5YFOoKu0cotueTciA== X-Google-Smtp-Source: ABdhPJz9mr06E8lR+a9ctR9n2j7lf85iEC1McaCI7ikNKeazb7Qs3U6uP/Z5VvAHxzga9O9Nc8N4/Q== X-Received: by 2002:aca:d9c2:: with SMTP id q185mr1715051oig.28.1600753460499; Mon, 21 Sep 2020 22:44:20 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id c19sm8114703ooq.35.2020.09.21.22.44.17 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 21 Sep 2020 22:44:19 -0700 (PDT) Date: Mon, 21 Sep 2020 22:44:16 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Alex Shi cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Andrey Ryabinin , Jann Horn Subject: Re: [PATCH v18 22/32] mm/vmscan: use relock for move_pages_to_lru In-Reply-To: <1598273705-69124-23-git-send-email-alex.shi@linux.alibaba.com> Message-ID: References: <1598273705-69124-1-git-send-email-alex.shi@linux.alibaba.com> <1598273705-69124-23-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Aug 2020, Alex Shi wrote: > From: Hugh Dickins > > Use the relock function to replace relocking action. And try to save few > lock times. > > Signed-off-by: Hugh Dickins > Signed-off-by: Alex Shi > Reviewed-by: Alexander Duyck NAK. Who wrote this rubbish? Oh, did I? Maybe something you extracted from my tarball. No, we don't need any of this now, as explained when going through 20/32. > Cc: Andrew Morton > Cc: Tejun Heo > Cc: Andrey Ryabinin > Cc: Jann Horn > Cc: Mel Gorman > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: cgroups@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > --- > mm/vmscan.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2c94790d4cb1..04ef94190530 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1848,15 +1848,15 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, > enum lru_list lru; > > while (!list_empty(list)) { > - struct lruvec *new_lruvec = NULL; > - > page = lru_to_page(list); > VM_BUG_ON_PAGE(PageLRU(page), page); > list_del(&page->lru); > if (unlikely(!page_evictable(page))) { > - spin_unlock_irq(&lruvec->lru_lock); > + if (lruvec) { > + spin_unlock_irq(&lruvec->lru_lock); > + lruvec = NULL; > + } > putback_lru_page(page); > - spin_lock_irq(&lruvec->lru_lock); > continue; > } > > @@ -1871,12 +1871,7 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, > * list_add(&page->lru,) > * list_add(&page->lru,) > */ > - new_lruvec = mem_cgroup_page_lruvec(page, page_pgdat(page)); > - if (new_lruvec != lruvec) { > - if (lruvec) > - spin_unlock_irq(&lruvec->lru_lock); > - lruvec = lock_page_lruvec_irq(page); > - } > + lruvec = relock_page_lruvec_irq(page, lruvec); > SetPageLRU(page); > > if (unlikely(put_page_testzero(page))) { > @@ -1885,8 +1880,8 @@ static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, > > if (unlikely(PageCompound(page))) { > spin_unlock_irq(&lruvec->lru_lock); > + lruvec = NULL; > destroy_compound_page(page); > - spin_lock_irq(&lruvec->lru_lock); > } else > list_add(&page->lru, &pages_to_free); > > -- > 1.8.3.1