From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEBBC4361B for ; Tue, 15 Dec 2020 02:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6AED4206CB for ; Tue, 15 Dec 2020 02:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AED4206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B61676B0036; Mon, 14 Dec 2020 21:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B11EE6B005D; Mon, 14 Dec 2020 21:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B1C56B0068; Mon, 14 Dec 2020 21:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 85FB06B0036 for ; Mon, 14 Dec 2020 21:16:49 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 522B51EE6 for ; Tue, 15 Dec 2020 02:16:49 +0000 (UTC) X-FDA: 77593903338.20.feast70_080f5282741f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 367DD180C07AF for ; Tue, 15 Dec 2020 02:16:49 +0000 (UTC) X-HE-Tag: feast70_080f5282741f X-Filterd-Recvd-Size: 5158 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 02:16:48 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id j12so17893731ota.7 for ; Mon, 14 Dec 2020 18:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=barWCp514FjI25PzXmxIiJLF9ZYJy6zAnVMGHuNnvjw=; b=eSfw5tE5a2wyn/jRdln7YAqK4uoJDzhoOSSzqwQ5qxbNTUu8xMlWjaXC7G3TEn4e8r uLpGMcOzcVFpNK3nmRELzDuOc45uXP0skLftpKCCwBENsio2lWi5P1Wgq7ikEROkQpWQ 3YbtThWQJ1IxnwaeruDgP25bwNonC1HTWo8kTUjSaF3Unc485ytQGNh3h82CaFGMHANU piMpvmtCW6oI0m9ysD4F2cWp1l3oXEFVwPlJ5D51AG1RA1eI2Wj8xrRzZLFicod9+PFm M/E9NqaLWYBojoQRlPJp6aAUV7d0J/UeDq0xB0AEniFLbz2HOFIn8J8CK/R7uHSboKd1 BqSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=barWCp514FjI25PzXmxIiJLF9ZYJy6zAnVMGHuNnvjw=; b=H2iVGmqRzX4oJyIdXpcYzJmmd7F5YoPqblDL9F1PTpYkBJECaBLTS7K42Px/8RP0/K 9LyLt/X/y0ti4ZXehJ24CnQPlthAgWHtm7DAmSD5oEWTwdS8DgjsnUqpJ8UpCK8VLuQV VrnHs0OSaTEiqvaSVAg3aURRDNH6ENRn2eRHTpO9HTydA1Op5z4tdnJpakXertzKGwNO J99mAGGh8k1I/JwE7/QsTnj19NO191J7G/HFe4eY4wlWyjeGItrrURl5j1XDLsYqh1kX fPPJZ5c3gXT0Yh12gq4jTocHgHGDO2mJLMZElcGPI0Urt2Wg7b4ZnmVjuXsiIoWWe7yv hjGw== X-Gm-Message-State: AOAM533pPysHRwhc2DJhRpKdLkSUVXgUREamH8xFti5e1pWqwkiRbqC4 +J+cKr9rd6VO9PUAc95KQkOTQw== X-Google-Smtp-Source: ABdhPJzRPydU4OJ/E6A2C8PdGop5Zh9B2jUkd0I+/UULhPwHa+kobZec9ipOyjV5B7KLcLPYyIAMIQ== X-Received: by 2002:a9d:63cd:: with SMTP id e13mr22108569otl.37.1607998607438; Mon, 14 Dec 2020 18:16:47 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j126sm4754700oib.13.2020.12.14.18.16.45 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 14 Dec 2020 18:16:47 -0800 (PST) Date: Mon, 14 Dec 2020 18:16:34 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Andrew Morton cc: Alex Shi , mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v21 00/19] per memcg lru lock In-Reply-To: <20201214164712.39da20f908c6199eb4cde961@linux-foundation.org> Message-ID: References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <20201214164712.39da20f908c6199eb4cde961@linux-foundation.org> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 14 Dec 2020, Andrew Morton wrote: > On Thu, 5 Nov 2020 16:55:30 +0800 Alex Shi wrote: > > > This version rebase on next/master 20201104, with much of Johannes's > > Acks and some changes according to Johannes comments. And add a new patch > > v21-0006-mm-rmap-stop-store-reordering-issue-on-page-mapp.patch to support > > v21-0007. > > I assume the consensus on this series is 'not yet"? Speaking for my part in the consensus: I don't share that assumption, the series by now is well-baked and well reviewed by enough people over more than enough versions, has been completely untroublesome since it entered mmotm/linux-next a month ago, not even any performance bleats from 0day, and has nothing to gain from any further delay. I think it was my fault that v20 didn't get into 5.10: I'd said "not yet" when you first tried a part of v19 or earlier in mmotm, and by the time I'd completed review it was too late in the cycle; Johannes and Vlastimil have gone over it since then, and I'd be glad to see it go ahead into 5.11 very soon. Silence on v21 meaning that it's good. Various of us have improvements or cleanups in mind or in private tree, but nothing to hold back what's already there. > > Also, did > https://lkml.kernel.org/r/0000000000000340a105b49441d3@google.com get > resolved? Alex found enough precedents for that, before inclusion of his series, so it should not discourage from moving his series forward. I have ignored that syzreport until now, but will take a quick try at the repro now, to see if I'm inspired - probably not, but we'll see. Hugh