From: Hugh Dickins <hughd@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Shakeel Butt <shakeelb@google.com>, Roman Gushchin <guro@fb.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] mm: page-writeback: simplify memcg handling in test_clear_page_writeback()
Date: Wed, 10 Feb 2021 08:22:00 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.2102100813050.8131@eggly.anvils> (raw)
In-Reply-To: <alpine.LSU.2.11.2102092058290.7553@eggly.anvils>
On Tue, 9 Feb 2021, Hugh Dickins wrote:
> On Tue, 9 Feb 2021, Johannes Weiner wrote:
>
> > Page writeback doesn't hold a page reference, which allows truncate to
> > free a page the second PageWriteback is cleared. This used to require
> > special attention in test_clear_page_writeback(), where we had to be
> > careful not to rely on the unstable page->memcg binding and look up
> > all the necessary information before clearing the writeback flag.
> >
> > Since commit 073861ed77b6 ("mm: fix VM_BUG_ON(PageTail) and
> > BUG_ON(PageWriteback)") test_clear_page_writeback() is called with an
> > explicit reference on the page, and this dance is no longer needed.
> >
> > Use unlock_page_memcg() and dec_lruvec_page_stat() directly.
>
> s/stat()/state()/
>
> This is a nice cleanup: I hadn't seen that connection at all.
>
> But I think you should take it further:
> __unlock_page_memcg() can then be static in mm/memcontrol.c,
> and its declarations deleted from include/linux/memcontrol.h?
And further: void lock_page_memcg(page), not returning memcg.
>
> And further: delete __dec_lruvec_state() and dec_lruvec_state()
> from include/linux/vmstat.h - unless you feel that every "inc"
> ought to be matched by a "dec", even when unused.
>
> >
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>
> Acked-by: Hugh Dickins <hughd@google.com>
>
> > ---
> > mm/page-writeback.c | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > index eb34d204d4ee..f6c2c3165d4d 100644
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -2722,12 +2722,9 @@ EXPORT_SYMBOL(clear_page_dirty_for_io);
> > int test_clear_page_writeback(struct page *page)
> > {
> > struct address_space *mapping = page_mapping(page);
> > - struct mem_cgroup *memcg;
> > - struct lruvec *lruvec;
> > int ret;
> >
> > - memcg = lock_page_memcg(page);
> > - lruvec = mem_cgroup_page_lruvec(page, page_pgdat(page));
> > + lock_page_memcg(page);
> > if (mapping && mapping_use_writeback_tags(mapping)) {
> > struct inode *inode = mapping->host;
> > struct backing_dev_info *bdi = inode_to_bdi(inode);
> > @@ -2755,11 +2752,11 @@ int test_clear_page_writeback(struct page *page)
> > ret = TestClearPageWriteback(page);
> > }
> > if (ret) {
> > - dec_lruvec_state(lruvec, NR_WRITEBACK);
> > + dec_lruvec_page_state(page, NR_WRITEBACK);
> > dec_zone_page_state(page, NR_ZONE_WRITE_PENDING);
> > inc_node_page_state(page, NR_WRITTEN);
> > }
> > - __unlock_page_memcg(memcg);
> > + unlock_page_memcg(page);
> > return ret;
> > }
> >
> > --
> > 2.30.0
>
next prev parent reply other threads:[~2021-02-10 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 21:45 [PATCH] mm: page-writeback: simplify memcg handling in test_clear_page_writeback() Johannes Weiner
2021-02-10 5:16 ` Hugh Dickins
2021-02-10 16:22 ` Hugh Dickins [this message]
2021-02-10 17:44 ` [PATCH v2] " Johannes Weiner
2021-02-10 20:14 ` Hugh Dickins
2021-02-10 22:59 ` Shakeel Butt
2021-02-11 0:33 ` Johannes Weiner
2021-02-12 10:05 ` Michal Hocko
2021-02-10 13:46 ` [PATCH] " Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2102100813050.8131@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).