From: Hugh Dickins <hughd@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] mm: /proc//sys/vm/stat_refresh stop checking monotonic numa stats
Date: Thu, 25 Feb 2021 15:15:42 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.2102251514110.13363@eggly.anvils> (raw)
In-Reply-To: <alpine.LSU.2.11.2102251502240.13363@eggly.anvils>
All of the VM NUMA stats are event counts, incremented never decremented:
it is not very useful for vmstat_refresh() to check them throughout their
first aeon, then warn on them throughout their next.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
mm/vmstat.c | 9 ---------
1 file changed, 9 deletions(-)
--- vmstat3/mm/vmstat.c 2021-02-25 12:42:15.000000000 -0800
+++ vmstat4/mm/vmstat.c 2021-02-25 12:44:20.000000000 -0800
@@ -1854,15 +1854,6 @@ int vmstat_refresh(struct ctl_table *tab
__func__, zone_stat_name(i), val);
}
}
-#ifdef CONFIG_NUMA
- for (i = 0; i < NR_VM_NUMA_STAT_ITEMS; i++) {
- val = atomic_long_read(&vm_numa_stat[i]);
- if (val < 0) {
- pr_warn("%s: %s %ld\n",
- __func__, numa_stat_name(i), val);
- }
- }
-#endif
for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) {
/*
* Skip checking stats known to go negative occasionally.
next prev parent reply other threads:[~2021-02-25 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 23:10 [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Hugh Dickins
2021-02-25 23:12 ` [PATCH 2/4] mm: no more EINVAL from /proc/sys/vm/stat_refresh Hugh Dickins
2021-03-01 0:38 ` Roman Gushchin
2021-02-25 23:14 ` [PATCH 3/4] mm: /proc/sys/vm/stat_refresh skip checking known negative stats Hugh Dickins
2021-03-01 0:53 ` Roman Gushchin
2021-03-01 22:08 ` Hugh Dickins
2021-03-02 0:34 ` Roman Gushchin
2021-03-02 6:03 ` [PATCH v2 " Hugh Dickins
2021-03-04 2:25 ` Roman Gushchin
2021-02-25 23:15 ` Hugh Dickins [this message]
2021-03-01 0:53 ` [PATCH 4/4] mm: /proc//sys/vm/stat_refresh stop checking monotonic numa stats Roman Gushchin
2021-03-01 0:37 ` [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.2102251514110.13363@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).