From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441ECC2B9F4 for ; Tue, 22 Jun 2021 12:01:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C683A60698 for ; Tue, 22 Jun 2021 12:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C683A60698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 693436B006C; Tue, 22 Jun 2021 08:01:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66AC66B0072; Tue, 22 Jun 2021 08:01:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50AF56B0073; Tue, 22 Jun 2021 08:01:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 1B8016B006C for ; Tue, 22 Jun 2021 08:01:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ACF198249980 for ; Tue, 22 Jun 2021 12:01:41 +0000 (UTC) X-FDA: 78281220402.10.4740B72 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf15.hostedemail.com (Postfix) with ESMTP id BF062A00385A for ; Tue, 22 Jun 2021 12:01:39 +0000 (UTC) Received: by mail-il1-f181.google.com with SMTP id k5so4572105ilv.8 for ; Tue, 22 Jun 2021 05:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OFqOzSYFoPLWrBxvS0YkOHpdFEiSDZ2rlvc92Jihv8g=; b=q6fOqKMGVCHgYvZPkc2svRtiS/wX6DOiznLpWTifRUbUr/TIi9WZezRwF/41EnS/7x U5A/x0RK2RBAuNEizoP0I6ke7XTn1yq59BtOR4H1R1DrcBpB2dpUTu/9CW40eSzx8WLR gqT3BVpV9ig7m1ilG2deXUA5VCTl8aZVczrnSf00otVrfjEjnLBK2Ep9VHeAZWU3oQv0 tCQp1XmgvNE6xRFD1E2w5YDm2I7jzVJ+QLdYdCdyB4yfZmlFz81C4t41nenLVgvTS7kO Y1wPGocOWHB5bhPfP6hS2813di9U3AElN+q9UvRdGNjf/WmJn64v8wjqAKW4a5sarGZ4 TUSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OFqOzSYFoPLWrBxvS0YkOHpdFEiSDZ2rlvc92Jihv8g=; b=NtEB1/7r2wLcaa/fXEQFgm+05akSeYD8QrHIHZJx5hTPxG1ePYLWgkO4OnzJiYpgKW dUFfdhGn1EE7aKCsvWYwOTFG5GeJeEeO2HpjpD5uCRlMSx79GnJ0uoKf9Gk11rxSXP8D 2M4gLIo9dvMQnhBLQSJpU2KQDx2EyknQL0DYQn01vucuM/OZKRu7himQxEn9+4Rzkuvv Ssu+Z5Wz747Z2cTE67U8pG3sfHIhjpUjqfwLvU/02FoGArgQUWUQCv1hUK2eA9mVfitG OWdMImKznFfTIE9RYcyIPNYJ7lcew8kqqRnfNuvFie6dRZHpOxJAm0XK74Xg8aKPd3+Z xZEQ== X-Gm-Message-State: AOAM5331xG4lP2b0cpxHrN65rqcfs+eGCafAntSV/eGZQ2+WASvx9bxw kXJ6/JfIXaJKmrYRdiaNo2V47v1mGkZtXQ== X-Google-Smtp-Source: ABdhPJxDJxjrWiRNF1zPI7qFQNVxAJNwDE+7ishrKMI8+/F4eripuvDaH/uEpcS7zXK4aJSWw7dfrQ== X-Received: by 2002:a05:6e02:972:: with SMTP id q18mr2545052ilt.88.1624363298499; Tue, 22 Jun 2021 05:01:38 -0700 (PDT) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id c8sm1187927iln.48.2021.06.22.05.01.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 05:01:38 -0700 (PDT) Subject: Re: [linux-next:master 8371/11714] drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:438:10: error: implicit declaration of function 'rmnet_map_ipv6_dl_csum_trailer'; did you mean 'rmnet_map_ipv4_dl_csum_trailer'? To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List References: <202106220742.gO0aGJgU-lkp@intel.com> From: Alex Elder Message-ID: Date: Tue, 22 Jun 2021 07:01:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <202106220742.gO0aGJgU-lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=q6fOqKMG; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf15.hostedemail.com: domain of elder@linaro.org designates 209.85.166.181 as permitted sender) smtp.mailfrom=elder@linaro.org X-Stat-Signature: yy4mrc87ixcrgi6rzgtcg11zim9hdpya X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BF062A00385A X-HE-Tag: 1624363299-661013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/21/21 6:57 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 889bab4c367a0ef58208fd80fafa74bb6e2dca26 > commit: 75db5b07f8c393c216fd20f7adc9a167fc684c23 [8371/11714] net: qualcomm: rmnet: eliminate some ifdefs > config: nds32-randconfig-s031-20210621 (attached as .config) > compiler: nds32le-linux-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-341-g8af24329-dirty > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=75db5b07f8c393c216fd20f7adc9a167fc684c23 I believe this problem has already been fixed, in a newer commit: 21ef9d6746f03 net: qualcomm: rmnet: always expose a few functions -Alex > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 75db5b07f8c393c216fd20f7adc9a167fc684c23 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=nds32 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > Note: the linux-next/master HEAD 889bab4c367a0ef58208fd80fafa74bb6e2dca26 builds fine. > It may have been fixed somewhere. > > All errors (new ones prefixed by >>): > > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_checksum_downlink_packet': >>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:438:10: error: implicit declaration of function 'rmnet_map_ipv6_dl_csum_trailer'; did you mean 'rmnet_map_ipv4_dl_csum_trailer'? [-Werror=implicit-function-declaration] > 438 | return rmnet_map_ipv6_dl_csum_trailer(skb, csum_trailer, priv); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | rmnet_map_ipv4_dl_csum_trailer > drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c: In function 'rmnet_map_v4_checksum_uplink_packet': >>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:472:3: error: implicit declaration of function 'rmnet_map_ipv6_ul_csum_header'; did you mean 'rmnet_map_ipv4_ul_csum_header'? [-Werror=implicit-function-declaration] > 472 | rmnet_map_ipv6_ul_csum_header(iphdr, ul_header, skb); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | rmnet_map_ipv4_ul_csum_header > cc1: some warnings being treated as errors > > > vim +438 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 410 > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 411 /* Validates packet checksums. Function takes a pointer to > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 412 * the beginning of a buffer which contains the IP payload + > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 413 * padding + checksum trailer. > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 414 * Only IPv4 and IPv6 are supported along with TCP & UDP. > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 415 * Fragmented or tunneled packets are not supported. > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 416 */ > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 417 int rmnet_map_checksum_downlink_packet(struct sk_buff *skb, u16 len) > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 418 { > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 419 struct rmnet_priv *priv = netdev_priv(skb->dev); > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 420 struct rmnet_map_dl_csum_trailer *csum_trailer; > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 421 > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 422 if (unlikely(!(skb->dev->features & NETIF_F_RXCSUM))) { > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 423 priv->stats.csum_sw++; > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 424 return -EOPNOTSUPP; > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 425 } > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 426 > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 427 csum_trailer = (struct rmnet_map_dl_csum_trailer *)(skb->data + len); > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 428 > cc1b21ba6251c8 Alex Elder 2021-03-15 429 if (!(csum_trailer->flags & MAP_CSUM_DL_VALID_FLAG)) { > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 430 priv->stats.csum_valid_unset++; > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 431 return -EINVAL; > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 432 } > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 433 > 75db5b07f8c393 Alex Elder 2021-06-11 434 if (skb->protocol == htons(ETH_P_IP)) > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 435 return rmnet_map_ipv4_dl_csum_trailer(skb, csum_trailer, priv); > 75db5b07f8c393 Alex Elder 2021-06-11 436 > 75db5b07f8c393 Alex Elder 2021-06-11 437 if (IS_ENABLED(CONFIG_IPV6) && skb->protocol == htons(ETH_P_IPV6)) > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 @438 return rmnet_map_ipv6_dl_csum_trailer(skb, csum_trailer, priv); > 75db5b07f8c393 Alex Elder 2021-06-11 439 > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 440 priv->stats.csum_err_invalid_ip_version++; > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 441 > 75db5b07f8c393 Alex Elder 2021-06-11 442 return -EPROTONOSUPPORT; > bbd21b247cb596 Subash Abhinov Kasiviswanathan 2018-01-07 443 } > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 444 > b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 445 static void rmnet_map_v4_checksum_uplink_packet(struct sk_buff *skb, > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 446 struct net_device *orig_dev) > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 447 { > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 448 struct rmnet_priv *priv = netdev_priv(orig_dev); > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 449 struct rmnet_map_ul_csum_header *ul_header; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 450 void *iphdr; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 451 > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 452 ul_header = (struct rmnet_map_ul_csum_header *) > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 453 skb_push(skb, sizeof(struct rmnet_map_ul_csum_header)); > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 454 > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 455 if (unlikely(!(orig_dev->features & > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 456 (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM)))) > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 457 goto sw_csum; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 458 > 75db5b07f8c393 Alex Elder 2021-06-11 459 if (skb->ip_summed != CHECKSUM_PARTIAL) > 75db5b07f8c393 Alex Elder 2021-06-11 460 goto sw_csum; > 75db5b07f8c393 Alex Elder 2021-06-11 461 > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 462 iphdr = (char *)ul_header + > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 463 sizeof(struct rmnet_map_ul_csum_header); > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 464 > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 465 if (skb->protocol == htons(ETH_P_IP)) { > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 466 rmnet_map_ipv4_ul_csum_header(iphdr, ul_header, skb); > b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 467 priv->stats.csum_hw++; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 468 return; > 75db5b07f8c393 Alex Elder 2021-06-11 469 } > 75db5b07f8c393 Alex Elder 2021-06-11 470 > 75db5b07f8c393 Alex Elder 2021-06-11 471 if (IS_ENABLED(CONFIG_IPV6) && skb->protocol == htons(ETH_P_IPV6)) { > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 @472 rmnet_map_ipv6_ul_csum_header(iphdr, ul_header, skb); > b6e5d27e32ef60 Sharath Chandra Vurukala 2021-06-02 473 priv->stats.csum_hw++; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 474 return; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 475 } > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 476 > 75db5b07f8c393 Alex Elder 2021-06-11 477 priv->stats.csum_err_invalid_ip_version++; > 75db5b07f8c393 Alex Elder 2021-06-11 478 > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 479 sw_csum: > 86ca860e12ec0f Alex Elder 2021-03-15 480 memset(ul_header, 0, sizeof(*ul_header)); > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 481 > bbde32d38bfbbc Subash Abhinov Kasiviswanathan 2018-05-15 482 priv->stats.csum_sw++; > 5eb5f8608ef118 Subash Abhinov Kasiviswanathan 2018-01-07 483 } > e1d9a90a9bfdb0 Sharath Chandra Vurukala 2021-06-02 484 > > :::::: The code at line 438 was first introduced by commit > :::::: bbde32d38bfbbc4a6970498c7470a8a817122735 net: qualcomm: rmnet: Add support for ethtool private stats > > :::::: TO: Subash Abhinov Kasiviswanathan > :::::: CC: David S. Miller > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >