linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Paul Walmsley <paul.walmsley@sifive.com>, alex@ghiti.fr
Cc: "Mark Rutland" <Mark.Rutland@arm.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	linux-mm@kvack.org, "Albert Ou" <aou@eecs.berkeley.edu>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-riscv@lists.infradead.org, "Will Deacon" <will@kernel.org>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	x86@kernel.org, "Ingo Molnar" <mingo@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	linux-kernel@vger.kernel.org, "James Morse" <james.morse@arm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH v11 07/22] riscv: mm: Add p?d_leaf() definitions
Date: Wed, 9 Oct 2019 11:55:43 +0100	[thread overview]
Message-ID: <b0ed95cd-703f-9ac2-a2e8-9a059f4095f9@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1910081431310.11044@viisi.sifive.com>

On 08/10/2019 22:33, Paul Walmsley wrote:
> On Mon, 7 Oct 2019, Steven Price wrote:
> 
>> walk_page_range() is going to be allowed to walk page tables other than
>> those of user space. For this it needs to know when it has reached a
>> 'leaf' entry in the page tables. This information is provided by the
>> p?d_leaf() functions/macros.
>>
>> For riscv a page is a leaf page when it has a read, write or execute bit
>> set on it.
>>
>> CC: Palmer Dabbelt <palmer@sifive.com>
>> CC: Albert Ou <aou@eecs.berkeley.edu>
>> CC: linux-riscv@lists.infradead.org
>> Signed-off-by: Steven Price <steven.price@arm.com>
> 
> Acked-by: Paul Walmsley <paul.walmsley@sifive.com> # for arch/riscv  
> 
> Alex has a good point, but probably the right thing to do is to replace 
> the contents of the arch/riscv/mm/hugetlbpage.c p{u,m}d_huge() functions 
> with calls to Steven's new static inline functions.

The intention is to create new functions that are not dependent on
hugepage support in user space. hugetlbpage.c is only built if
CONFIG_HUGETLB_PAGE is defined.

As you say - the p{u,m}d_huge() functions can be reimplemented using the
new static inline functions if desired.

Thanks for the review.

Steve

> 
> - Paul
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 



  reply	other threads:[~2019-10-09 10:55 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 15:38 [PATCH v11 00/22] Generic page walk and ptdump Steven Price
2019-10-07 15:38 ` [PATCH v11 01/22] mm: Add generic p?d_leaf() macros Steven Price
2019-10-07 15:38 ` [PATCH v11 02/22] arc: mm: Add p?d_leaf() definitions Steven Price
2019-10-08 20:19   ` Vineet Gupta
2019-10-07 15:38 ` [PATCH v11 03/22] arm: " Steven Price
2019-10-07 15:38 ` [PATCH v11 04/22] arm64: " Steven Price
2019-10-07 15:38 ` [PATCH v11 05/22] mips: " Steven Price
2019-10-07 15:38 ` [PATCH v11 06/22] powerpc: " Steven Price
2019-10-07 15:38 ` [PATCH v11 07/22] riscv: " Steven Price
2019-10-08 11:31   ` Alex Ghiti
2019-10-08 21:33   ` Paul Walmsley
2019-10-09 10:55     ` Steven Price [this message]
2019-10-07 15:38 ` [PATCH v11 08/22] s390: " Steven Price
2019-10-07 15:38 ` [PATCH v11 09/22] sparc: " Steven Price
2019-10-07 15:38 ` [PATCH v11 10/22] x86: " Steven Price
2019-10-07 15:38 ` [PATCH v11 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-10-07 15:38 ` [PATCH v11 12/22] mm: pagewalk: Allow walking without vma Steven Price
2019-10-07 15:38 ` [PATCH v11 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-10-07 15:38 ` [PATCH v11 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-10-07 16:10   ` Jason Gunthorpe
2019-10-07 16:20     ` Steven Price
2019-10-07 18:11       ` Jason Gunthorpe
2019-10-09 11:00         ` Steven Price
2019-10-07 15:38 ` [PATCH v11 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price
2019-10-07 15:38 ` [PATCH v11 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-10-07 15:38 ` [PATCH v11 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-10-07 15:38 ` [PATCH v11 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-10-07 15:38 ` [PATCH v11 19/22] mm: Add generic ptdump Steven Price
2019-10-07 15:38 ` [PATCH v11 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-10-07 15:38 ` [PATCH v11 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-10-07 15:38 ` [PATCH v11 22/22] arm64: mm: Display non-present entries in ptdump Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0ed95cd-703f-9ac2-a2e8-9a059f4095f9@arm.com \
    --to=steven.price@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jglisse@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).