From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org
Cc: akpm@linux-foundation.org
Subject: Re: [PATCH] mm/mempolicy: Move VMA address bound checks inside mpol_misplaced()
Date: Fri, 1 Sep 2017 17:51:18 +0530 [thread overview]
Message-ID: <b28e0081-6e10-2d55-7414-afb0574a11a1@linux.vnet.ibm.com> (raw)
In-Reply-To: <8e40fafd-dcee-9baa-738e-1a870ee54b41@linux.vnet.ibm.com>
On 09/01/2017 05:47 PM, Anshuman Khandual wrote:
> On 09/01/2017 02:35 PM, Vlastimil Babka wrote:
>> On 09/01/2017 09:02 AM, Anshuman Khandual wrote:
>>> The VMA address bound checks are applicable to all memory policy modes,
>>> not just MPOL_INTERLEAVE.
>>
>> But only MPOL_INTERLEAVE actually uses addr and vma->vm_start.
>
> I thought them to be just general sanity checks.
>
>>
>>> Hence move it to the front and make it common.
>>>
>>> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
>>
>> I would just remove them instead. Together with the BUG_ON(!vma). Looks
>> like just leftover from development.
>
> sure, resend with suggested changes.
I meant, I will resend the patch with suggested changes.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-01 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 7:02 [PATCH] mm/mempolicy: Move VMA address bound checks inside mpol_misplaced() Anshuman Khandual
2017-09-01 9:05 ` Vlastimil Babka
2017-09-01 12:17 ` Anshuman Khandual
2017-09-01 12:21 ` Anshuman Khandual [this message]
2017-09-01 13:01 ` [PATCH] mm/mempolicy: Remove BUG_ON() checks for VMA " Anshuman Khandual
2017-09-01 13:16 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28e0081-6e10-2d55-7414-afb0574a11a1@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).