From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A81C433E6 for ; Tue, 2 Mar 2021 09:05:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB3DE64F0B for ; Tue, 2 Mar 2021 09:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3DE64F0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8FAE8D00EC; Tue, 2 Mar 2021 04:04:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B40158D0063; Tue, 2 Mar 2021 04:04:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2EC18D00EC; Tue, 2 Mar 2021 04:04:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 8BEB08D0063 for ; Tue, 2 Mar 2021 04:04:58 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 59A12180ACF75 for ; Tue, 2 Mar 2021 09:04:58 +0000 (UTC) X-FDA: 77874349476.04.81ABDB7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DA2E02000392 for ; Tue, 2 Mar 2021 09:04:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614675896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zKR5m0U4Kyxf0YAKbBROA6h6lzGB5mUnbgoPuKmwmCE=; b=Ri029l5LveeM5bAhi08nTtTCpvtqnXX/bBETngBQc1TFQdkkHTC2B0r889HvAEIcHmTKhQ t1L7J3PyQ/v4JBbubbKv+9ZfugbvJobJtNvCSkl01wrVpWrkYzFf5Yg+LRkPW3zuoTKYqb j6KGvo+6bvPP4qUGq1iHmGQP7ZUVAqo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-DqEAEwDGNXOLgLHqx4u4gA-1; Tue, 02 Mar 2021 04:04:54 -0500 X-MC-Unique: DqEAEwDGNXOLgLHqx4u4gA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2A22750743; Tue, 2 Mar 2021 09:04:52 +0000 (UTC) Received: from [10.36.114.189] (ovpn-114-189.ams2.redhat.com [10.36.114.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF1D457; Tue, 2 Mar 2021 09:04:48 +0000 (UTC) Subject: Re: [PATCH v1] microblaze: tag highmem_setup() with __meminit To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel test robot , Andrew Morton , Michal Simek , Mike Rapoport , Thomas Gleixner , Arvind Sankar , Ira Weiny , Randy Dunlap , Anshuman Khandual References: <20210301114749.47914-1-david@redhat.com> <20210301221846.GA4744@localhost.localdomain> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 2 Mar 2021 10:04:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210301221846.GA4744@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DA2E02000392 X-Stat-Signature: h15ae436dhwaiqd61x616eakq34uurip Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614675896-915531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.03.21 23:18, Oscar Salvador wrote: > On Mon, Mar 01, 2021 at 12:47:49PM +0100, David Hildenbrand wrote: >> With commit a0cd7a7c4bc0 ("mm: simplify free_highmem_page() and >> free_reserved_page()") the kernel test robot complains about a warning: >> >> WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in >> reference from the function highmem_setup() to the function >> .meminit.text:memblock_is_reserved() >> >> This has been broken ever since microblaze added highmem support, >> because memblock_is_reserved() was already tagged with "__init" back then - >> most probably the function always got inlined, so we never stumbled over >> it. > > It might be good to point out that we need __meminit instead of __init > because microblaze platform does not define CONFIG_ARCH_KEEP_MEMBLOCK, > and __init_memblock fallsback to that. > > (I had to go and look as I was puzzled :-) ) > > Reviewed-by: Oscar Salvador Thanks! Whoever feels like picking this up (@Andrew?) can you add "We need __meminit because __init_memblock defaults to that without CONFIG_ARCH_KEEP_MEMBLOCK" and __init_memblock is not used outside memblock code. -- Thanks, David / dhildenb