From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 880F9C433E0 for ; Fri, 19 Mar 2021 13:45:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1773A64E99 for ; Fri, 19 Mar 2021 13:45:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1773A64E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A001E6B0072; Fri, 19 Mar 2021 09:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0806B007B; Fri, 19 Mar 2021 09:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DBA06B007D; Fri, 19 Mar 2021 09:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 612AD6B0072 for ; Fri, 19 Mar 2021 09:45:24 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1D7EC1EF1 for ; Fri, 19 Mar 2021 13:45:24 +0000 (UTC) X-FDA: 77936745768.34.EE3D4FC Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf15.hostedemail.com (Postfix) with ESMTP id AD180A0009D9 for ; Fri, 19 Mar 2021 13:45:23 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id b83so10077488lfd.11 for ; Fri, 19 Mar 2021 06:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CrdgYAIit68h21frWi2ZVer6TtigI0fqgyoc16zz0Io=; b=tPYUzv/xKUBsLh1NGzoqXhfQNLyRmfQwj+tNEcLeIWzPjq8lyGlFyU2N6kNXfOWeNd fsHjXQcSb3ZzbXGLkE33Ss+nH3TbSLhYlzooJ36/3ieWbrdfBH1W5NjW19wXZix4AqUp 2knS9YwX9CLH0TyETD/A/9OH+/YGC3I/Ii35TIATWMkAlSS0CNfKfK6CUiKiYWrFfTCh Dx8PHQjZzq+HdawjImlYY6XXXC1anpHlb2SmhFWnX/uxnuLaTCoDBfWNZ0H2LdUXDFfd km94tay1J/6VU08qGbnKILB752/apws1Sf+ZzmbjhKf6sZqGE14bmjyO2uKVjvM0dHi6 VqwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CrdgYAIit68h21frWi2ZVer6TtigI0fqgyoc16zz0Io=; b=GGsgB1n+O1axrJPX7BAQ7tq0zTyI5wE8HW0bFrb1JyfWYDOuWwWdbjRuD3WwYV/tr3 g31WHKWYGNgf5P6s2wtpSA302AOQ3ezMIF5gGc/2Mjp9mTsWoa8yFng3m+1VCP7D/WcM yQptUKdL6HWq7D2JmupQoqbxpXo4tAvtK1U1Clds/Rn12OhYR+WXaSs12v4X0joqLEb2 07RHhpvuuXVkKVz8gntZjK1EUOiAnvM2GWiFtycJMftBDQuwiR13UouR7ztn045jz7tz QgSUOGkALw9gUmsXTMirjLB2SFxzgkgfPX3Z+GaaDxsuDPX2ERAIe3dt/63Kg8p34utP kyYA== X-Gm-Message-State: AOAM533hMGf62kXHHp1tDu+lGPf0dCRqaOz7BuUMvCuzr/bm5e8D85W5 m/7b2n4HXiL7sbGDHx1Gfj4= X-Google-Smtp-Source: ABdhPJxfx9OTueeAe3Wr0OSGXEVnA61+I9fHIrcN6kyLmBD7u4yIyDFTFFqfxSUAO6+5AQ5NI81poA== X-Received: by 2002:ac2:4c8c:: with SMTP id d12mr894834lfl.1.1616161522150; Fri, 19 Mar 2021 06:45:22 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-52.dynamic.spd-mgts.ru. [109.252.193.52]) by smtp.googlemail.com with ESMTPSA id h17sm631164lfc.289.2021.03.19.06.45.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 06:45:21 -0700 (PDT) Subject: Re: [PATCH v4] mm: cma: support sysfs To: Greg Kroah-Hartman Cc: Minchan Kim , Andrew Morton , linux-mm , LKML , joaodias@google.com, willy@infradead.org, david@redhat.com, surenb@google.com, John Hubbard , Nicolas Chauvet , "linux-tegra@vger.kernel.org" References: <20210309062333.3216138-1-minchan@kernel.org> From: Dmitry Osipenko Message-ID: Date: Fri, 19 Mar 2021 16:45:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: 7iazq3jz3p3jy7w39cahecmyrxwekjjt X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AD180A0009D9 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-lf1-f46.google.com; client-ip=209.85.167.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616161523-464310 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 19.03.2021 16:42, Greg Kroah-Hartman =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Fri, Mar 19, 2021 at 04:39:41PM +0300, Dmitry Osipenko wrote: >> 19.03.2021 15:44, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> ... >>>> #include >>>> +#include >>>> + >>>> +struct cma_stat { >>>> + spinlock_t lock; >>>> + /* the number of CMA page successful allocations */ >>>> + unsigned long nr_pages_succeeded; >>>> + /* the number of CMA page allocation failures */ >>>> + unsigned long nr_pages_failed; >>>> + struct kobject kobj; >>>> +}; >>>> =20 >>>> struct cma { >>>> unsigned long base_pfn; >>>> @@ -16,6 +26,9 @@ struct cma { >>>> struct debugfs_u32_array dfs_bitmap; >>>> #endif >>>> char name[CMA_MAX_NAME]; >>>> +#ifdef CONFIG_CMA_SYSFS >>>> + struct cma_stat *stat; >>>> +#endif >> >> What is the point of allocating stat dynamically? >=20 > Because static kobjects make me cry. >=20 I meant that it's already a part of struct cma, it looks like the stat could be embedded into struct cma and then kobj could be initialized separately.