From: Vlastimil Babka <vbabka@suse.cz>
To: David Hildenbrand <david@redhat.com>,
Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org
Cc: iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_isolation: don't putback unisolated page
Date: Tue, 7 Sep 2021 10:08:36 +0200 [thread overview]
Message-ID: <b4615b3c-8217-9f32-39c7-b91c9ec3cccb@suse.cz> (raw)
In-Reply-To: <c60dc5e2-6f19-3be8-56be-555033cc9ca4@redhat.com>
On 9/6/21 14:49, David Hildenbrand wrote:
> On 06.09.21 14:45, Miaohe Lin wrote:
>> On 2021/9/6 20:11, David Hildenbrand wrote:
>>> On 06.09.21 14:02, David Hildenbrand wrote:
>>>> On 04.09.21 11:18, Miaohe Lin wrote:
>>>>
>>>> Thanks!
>>>>
>>>> Reviewed-by: David Hildenbrand <david@redhat.com>
>>>>
>>>
>>> To make the confusion perfect (sorry) :D I tripple-checked:
>>>
>>> In unset_migratetype_isolate() we check that is_migrate_isolate_page(page) holds, otherwise we return.
>>>
>>> We call __isolate_free_page() only for such pages.
>>>
>>> __isolate_free_page() won't perform watermark checks on is_migrate_isolate().
>>>
>>> Consequently, __isolate_free_page() should never fail when called from unset_migratetype_isolate()
>>>
>>> If that's correct then we could instead maybe add a VM_BUG_ON() and a comment why this can't fail.
>>>
>>>
>>> Makes sense or am I missing something?
>>
>> I think you're right. __isolate_free_page() should never fail when called from unset_migratetype_isolate()
>> as explained by you. But it might be too fragile to reply on the failure conditions of __isolate_free_page().
>> If that changes, VM_BUG_ON() here might trigger unexpectedly. Or am I just over-worried as failure conditions
>> of __isolate_free_page() can hardly change?
>
> Maybe
>
> isolated_page = !!__isolate_free_page(page, order);
> /*
> * Isolating a free page in an isolated pageblock is expected to always
> * work as watermarks don't apply here.
> */
> VM_BUG_ON(isolated_page);
>
>
> VM_BUG_ON() allows us to detect any issues when testing. Combined with
> the comment it tells everybody messing with __isolate_free_page() what
> we expect in this function.
>
> In production system, we would handle it gracefully.
If this can be handled gracefully, then I'd rather go with VM_WARN_ON.
Maybe even WARN_ON_ONCE?
next prev parent reply other threads:[~2021-09-07 8:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 9:18 [PATCH] mm/page_isolation: don't putback unisolated page Miaohe Lin
2021-09-06 9:40 ` David Hildenbrand
2021-09-06 11:32 ` Miaohe Lin
2021-09-06 11:50 ` David Hildenbrand
2021-09-06 12:01 ` David Hildenbrand
2021-09-06 12:08 ` Miaohe Lin
2021-09-06 12:02 ` David Hildenbrand
2021-09-06 12:11 ` David Hildenbrand
2021-09-06 12:45 ` Miaohe Lin
2021-09-06 12:49 ` David Hildenbrand
2021-09-07 1:46 ` Miaohe Lin
2021-09-07 9:52 ` David Hildenbrand
2021-09-07 8:08 ` Vlastimil Babka [this message]
2021-09-07 9:56 ` David Hildenbrand
2021-09-08 22:42 ` John Hubbard
2021-09-09 8:56 ` David Hildenbrand
2021-09-09 9:07 ` Vlastimil Babka
2021-09-09 9:37 ` David Hildenbrand
2021-09-09 16:50 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4615b3c-8217-9f32-39c7-b91c9ec3cccb@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).