From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=n5cr=DK=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C3CC7C41604
	for <linux-mm@archiver.kernel.org>; Sat,  3 Oct 2020 22:31:35 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 3D40C206CD
	for <linux-mm@archiver.kernel.org>; Sat,  3 Oct 2020 22:31:34 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="f2t6y5Ax"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D40C206CD
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 520F46B005D; Sat,  3 Oct 2020 18:31:34 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 4D3348E0001; Sat,  3 Oct 2020 18:31:34 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 3C0896B0068; Sat,  3 Oct 2020 18:31:34 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229])
	by kanga.kvack.org (Postfix) with ESMTP id 001256B005D
	for <linux-mm@kvack.org>; Sat,  3 Oct 2020 18:31:33 -0400 (EDT)
Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with ESMTP id 77E433633
	for <linux-mm@kvack.org>; Sat,  3 Oct 2020 22:31:33 +0000 (UTC)
X-FDA: 77332062066.13.duck13_18097dd271b0
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin13.hostedemail.com (Postfix) with ESMTP id 57C8918140B70
	for <linux-mm@kvack.org>; Sat,  3 Oct 2020 22:31:33 +0000 (UTC)
X-HE-Tag: duck13_18097dd271b0
X-Filterd-Recvd-Size: 5882
Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143])
	by imf36.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Sat,  3 Oct 2020 22:31:32 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
	id <B5f78fb580000>; Sat, 03 Oct 2020 15:29:44 -0700
Received: from [10.2.58.214] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 3 Oct
 2020 22:31:15 +0000
Subject: Re: [PATCH v2 1/6] kselftests: vm: Add mremap tests
To: Kalesh Singh <kaleshsingh@google.com>
CC: Suren Baghdasaryan <surenb@google.com>, Minchan Kim <minchan@google.com>,
	Joel Fernandes <joelaf@google.com>, Lokesh Gidra <lokeshgidra@google.com>,
	"Cc: Android Kernel" <kernel-team@android.com>, Catalin Marinas
	<catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, the arch/x86 maintainers <x86@kernel.org>, "H. Peter Anvin"
	<hpa@zytor.com>, Andrew Morton <akpm@linux-foundation.org>, Shuah Khan
	<shuah@kernel.org>, Kees Cook <keescook@chromium.org>, Aneesh Kumar K.V
	<aneesh.kumar@linux.ibm.com>, Peter Zijlstra <peterz@infradead.org>, "Arnd
 Bergmann" <arnd@arndb.de>, Masahiro Yamada <masahiroy@kernel.org>, "Sami
 Tolvanen" <samitolvanen@google.com>, Frederic Weisbecker
	<frederic@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Hassan Naveed
	<hnaveed@wavecomp.com>, Christian Brauner <christian.brauner@ubuntu.com>,
	Mark Rutland <mark.rutland@arm.com>, Mark Brown <broonie@kernel.org>, "Mike
 Rapoport" <rppt@kernel.org>, Gavin Shan <gshan@redhat.com>, "Chris von
 Recklinghausen" <crecklin@redhat.com>, Jia He <justin.he@arm.com>, Zhenyu Ye
	<yezhenyu2@huawei.com>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>, Mina Almasry <almasrymina@google.com>, Ram
 Pai <linuxram@us.ibm.com>, Ralph Campbell <rcampbell@nvidia.com>, Sandipan
 Das <sandipan@linux.ibm.com>, Dave Hansen <dave.hansen@intel.com>, Colin Ian
 King <colin.king@canonical.com>, Masami Hiramatsu <mhiramat@kernel.org>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>, "Ira Weiny"
	<ira.weiny@intel.com>, SeongJae Park <sjpark@amazon.de>, Brian Geffon
	<bgeffon@google.com>, LKML <linux-kernel@vger.kernel.org>, "moderated
 list:ARM64 PORT (AARCH64 ARCHITECTURE)"
	<linux-arm-kernel@lists.infradead.org>, "open list:MEMORY MANAGEMENT"
	<linux-mm@kvack.org>, "open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>
References: <20201002162101.665549-1-kaleshsingh@google.com>
 <20201002162101.665549-2-kaleshsingh@google.com>
 <39b9988b-e196-926b-8d1f-dd474fb53f89@nvidia.com>
 <CAC_TJveSgd-=t49hqR3LN7G8PMPwdgN+qkQct3zS-N6=CW7uug@mail.gmail.com>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <b62f5c37-34f8-86e3-4f0c-bb5bf3c1eb08@nvidia.com>
Date: Sat, 3 Oct 2020 15:31:14 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAC_TJveSgd-=t49hqR3LN7G8PMPwdgN+qkQct3zS-N6=CW7uug@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1601764184; bh=pTS5Sd2YEmrpIORp3pmz9z2XZRtCg61Dcs3Ax9VOlss=;
	h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
	 MIME-Version:In-Reply-To:Content-Type:Content-Language:
	 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
	b=f2t6y5Axgm96/q/LPWxkMTp6K5hvXy3V8B4nPEYkIuNk0dHsdUSFVtVsc17M4i7/7
	 pjPpLq3blX55D3iecRPSGi5kBfW+d0kmWuqI2LkJJzPdbXI/TQ9MdMqytaLL+9Wuvu
	 iXkhjik9AOoKgGNXuK9ltowmpaI1bqpcboItGtLJieN3x6ayAJTDWPvGsS0hqwS2mg
	 CPB5uBGz8aw03djm7Q4ztxhF2+/wPlcu6nZNytzt2qX8d0lyPoaehJnnurxiAuGlpu
	 tnkUkpF6SwSLpZzHMLKUI8NuAkmCK4+4LdAJ0ei2cOLolrr0cLGmb08yIYzL2ZpPcq
	 SaJe5pUJ8Asdw==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 10/3/20 1:01 PM, Kalesh Singh wrote:
> On Sat, Oct 3, 2020 at 3:13 AM John Hubbard <jhubbard@nvidia.com> wrote:
...
>> A remaining nit: there are lots of > 80 col lines here. Only those lines
>> that contain printf output strings really need to be extra-long. The
>> others can all be easily made to fit.
> Thanks for the review John. I can fix the lines that don't need to be
>> 80 col. FWIW checkpatch now allows 100 col lines:
> https://lore.kernel.org/r/9c360bfa43580ce7726dd3d9d247f1216a690ef0.camel@perches.com

Yep, I watched that go by. The new guidelines match what I recommended here,
though.  It's slightly more nuanced than any sort of hard limit at either
80 or 100 lines, as you know from reading that--I'm just saying that out
loud for the benefit of others who may see this thread.

>> ...
>>> +
>>> +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
>>> +#define MIN(X, Y) ((X) < (Y) ? (X) : (Y))
>>
>>
>> Not really a comment on this patch, but: at least two other test suites
>> in selftests/ have had to recreate MIN() or min(), and probably a few
>> other common things as well. It would be nice to gather up some of these
>> common things into one of the shared header files in selftests/.
>>
>> I'm certainly not saying that this patchset has that responsibility,
>> though. Just pointing it out in case someone has a moment to clean up a
>> few here and there.
> Thanks for pointing this out. I'll leave it as a task for a separate
> patch if time permits or no one gets around to it before :-)
>>
Sound great. :)


thanks,
-- 
John Hubbard
NVIDIA