From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13097C433F5 for ; Mon, 13 Sep 2021 01:11:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6EBA960F56 for ; Mon, 13 Sep 2021 01:11:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6EBA960F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4532D6B0071; Sun, 12 Sep 2021 21:10:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 402DA6B0072; Sun, 12 Sep 2021 21:10:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F2146B0073; Sun, 12 Sep 2021 21:10:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 1D6366B0071 for ; Sun, 12 Sep 2021 21:10:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B9D3E181AF5C1 for ; Mon, 13 Sep 2021 01:10:58 +0000 (UTC) X-FDA: 78580770996.13.396A01F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id D6610D0000A1 for ; Mon, 13 Sep 2021 01:10:57 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H77gS27j6zVt2w; Mon, 13 Sep 2021 09:09:56 +0800 (CST) Received: from dggema766-chm.china.huawei.com (10.1.198.208) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Mon, 13 Sep 2021 09:10:53 +0800 Received: from [10.174.177.210] (10.174.177.210) by dggema766-chm.china.huawei.com (10.1.198.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Mon, 13 Sep 2021 09:10:53 +0800 Subject: Re: [PATCH] ramfs: fix mount source show for ramfs From: yangerkun To: Andrew Morton , Al Viro CC: , , , , , , References: <20210811122811.2288041-1-yangerkun@huawei.com> <720f6c7a-6745-98ad-5c71-7747857a7f01@huawei.com> <20210908153958.19054d439ae59ee3a7e41519@linux-foundation.org> Message-ID: Date: Mon, 13 Sep 2021 09:10:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [10.174.177.210] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema766-chm.china.huawei.com (10.1.198.208) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D6610D0000A1 Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of yangerkun@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=yangerkun@huawei.com X-Stat-Signature: iiwnym1mugz34oawappgghap59p9ammz X-HE-Tag: 1631495457-241180 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2021/9/9 16:37, yangerkun =E5=86=99=E9=81=93: >=20 >=20 > =E5=9C=A8 2021/9/9 6:39, Andrew Morton =E5=86=99=E9=81=93: >> On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun wro= te: >> >>> =E5=9C=A8 2021/8/11 20:28, yangerkun =E5=86=99=E9=81=93: >>>> ramfs_parse_param does not parse key "source", and will convert >>>> -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in >>>> vfs_parse_fs_param, which lead always "none" mount source for ramfs.= =20 >>>> Fix >>>> it by parse "source" in ramfs_parse_param. >>>> >>>> Signed-off-by: yangerkun >>>> --- >>>> =C2=A0=C2=A0 fs/ramfs/inode.c | 4 ++++ >>>> =C2=A0=C2=A0 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c >>>> index 65e7e56005b8..0d7f5f655fd8 100644 >>>> --- a/fs/ramfs/inode.c >>>> +++ b/fs/ramfs/inode.c >>>> @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context=20 >>>> *fc, struct fs_parameter *param) >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct ramfs_fs_info *fsi =3D f= c->s_fs_info; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int opt; >>>> +=C2=A0=C2=A0=C2=A0 opt =3D vfs_parse_fs_param_source(fc, param); >>>> +=C2=A0=C2=A0=C2=A0 if (opt !=3D -ENOPARAM) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return opt; >>>> + >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 opt =3D fs_parse(fc, ramfs_fs_p= arameters, param, &result); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (opt < 0) { >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* >>>> >> >> (top-posting repaired) >> >>> Hi, this patch seems still leave in linux-next, should we pull it to >>> mainline? >> >> I was hoping for a comment from Al? >=20 > Hi, Al, >=20 > Can you help to review this patch... Hi, Al, Sorry for the noise again, can you help to give some comments for this=20 patch. >=20 > Thanks, > Kun. >=20 >> . >> > .